* [PATCH 1/2] drm/imx: Remove imx_drm_crtc_vblank_get/_put()
@ 2016-07-18 7:44 Liu Ying
2016-07-18 7:44 ` [PATCH 2/2] drm/imx: Remove imx_drm_crtc_id() Liu Ying
2016-07-18 8:47 ` [PATCH 1/2] drm/imx: Remove imx_drm_crtc_vblank_get/_put() Philipp Zabel
0 siblings, 2 replies; 3+ messages in thread
From: Liu Ying @ 2016-07-18 7:44 UTC (permalink / raw)
To: dri-devel
There is no one calling imx_drm_crtc_vblank_get/_put() and
they are just two simple wrappers of drm_crtc_vblank_get/_put()
without doing any thing fancy - the drivers may call
drm_crtc_vblank_get/_put() directly. So, let's remove the two
wrappers.
Signed-off-by: Liu Ying <gnuiyl@gmail.com>
---
drivers/gpu/drm/imx/imx-drm-core.c | 12 ------------
drivers/gpu/drm/imx/imx-drm.h | 2 --
2 files changed, 14 deletions(-)
diff --git a/drivers/gpu/drm/imx/imx-drm-core.c b/drivers/gpu/drm/imx/imx-drm-core.c
index 9f7dafc..1fd1900 100644
--- a/drivers/gpu/drm/imx/imx-drm-core.c
+++ b/drivers/gpu/drm/imx/imx-drm-core.c
@@ -90,18 +90,6 @@ static int imx_drm_driver_unload(struct drm_device *drm)
return 0;
}
-int imx_drm_crtc_vblank_get(struct imx_drm_crtc *imx_drm_crtc)
-{
- return drm_crtc_vblank_get(imx_drm_crtc->crtc);
-}
-EXPORT_SYMBOL_GPL(imx_drm_crtc_vblank_get);
-
-void imx_drm_crtc_vblank_put(struct imx_drm_crtc *imx_drm_crtc)
-{
- drm_crtc_vblank_put(imx_drm_crtc->crtc);
-}
-EXPORT_SYMBOL_GPL(imx_drm_crtc_vblank_put);
-
void imx_drm_handle_vblank(struct imx_drm_crtc *imx_drm_crtc)
{
drm_crtc_handle_vblank(imx_drm_crtc->crtc);
diff --git a/drivers/gpu/drm/imx/imx-drm.h b/drivers/gpu/drm/imx/imx-drm.h
index 07d33e4..0049b77f 100644
--- a/drivers/gpu/drm/imx/imx-drm.h
+++ b/drivers/gpu/drm/imx/imx-drm.h
@@ -44,8 +44,6 @@ int imx_drm_init_drm(struct platform_device *pdev,
int preferred_bpp);
int imx_drm_exit_drm(void);
-int imx_drm_crtc_vblank_get(struct imx_drm_crtc *imx_drm_crtc);
-void imx_drm_crtc_vblank_put(struct imx_drm_crtc *imx_drm_crtc);
void imx_drm_handle_vblank(struct imx_drm_crtc *imx_drm_crtc);
void imx_drm_mode_config_init(struct drm_device *drm);
--
2.7.4
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 3+ messages in thread* [PATCH 2/2] drm/imx: Remove imx_drm_crtc_id()
2016-07-18 7:44 [PATCH 1/2] drm/imx: Remove imx_drm_crtc_vblank_get/_put() Liu Ying
@ 2016-07-18 7:44 ` Liu Ying
2016-07-18 8:47 ` [PATCH 1/2] drm/imx: Remove imx_drm_crtc_vblank_get/_put() Philipp Zabel
1 sibling, 0 replies; 3+ messages in thread
From: Liu Ying @ 2016-07-18 7:44 UTC (permalink / raw)
To: dri-devel
There is no one calling imx_drm_crtc_id() and it is just a simple
wrapper of drm_crtc_index() without doing any thing fancy - the
drivers may call drm_crtc_index() directly. So, let's remove the
wrapper.
Signed-off-by: Liu Ying <gnuiyl@gmail.com>
---
drivers/gpu/drm/imx/imx-drm-core.c | 6 ------
drivers/gpu/drm/imx/imx-drm.h | 2 --
2 files changed, 8 deletions(-)
diff --git a/drivers/gpu/drm/imx/imx-drm-core.c b/drivers/gpu/drm/imx/imx-drm-core.c
index 1fd1900..1aefced 100644
--- a/drivers/gpu/drm/imx/imx-drm-core.c
+++ b/drivers/gpu/drm/imx/imx-drm-core.c
@@ -58,12 +58,6 @@ static int legacyfb_depth = 16;
module_param(legacyfb_depth, int, 0444);
#endif
-unsigned int imx_drm_crtc_id(struct imx_drm_crtc *crtc)
-{
- return drm_crtc_index(crtc->crtc);
-}
-EXPORT_SYMBOL_GPL(imx_drm_crtc_id);
-
static void imx_drm_driver_lastclose(struct drm_device *drm)
{
struct imx_drm_device *imxdrm = drm->dev_private;
diff --git a/drivers/gpu/drm/imx/imx-drm.h b/drivers/gpu/drm/imx/imx-drm.h
index 0049b77f..bdaa381 100644
--- a/drivers/gpu/drm/imx/imx-drm.h
+++ b/drivers/gpu/drm/imx/imx-drm.h
@@ -13,8 +13,6 @@ struct drm_plane;
struct imx_drm_crtc;
struct platform_device;
-unsigned int imx_drm_crtc_id(struct imx_drm_crtc *crtc);
-
struct imx_crtc_state {
struct drm_crtc_state base;
u32 bus_format;
--
2.7.4
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH 1/2] drm/imx: Remove imx_drm_crtc_vblank_get/_put()
2016-07-18 7:44 [PATCH 1/2] drm/imx: Remove imx_drm_crtc_vblank_get/_put() Liu Ying
2016-07-18 7:44 ` [PATCH 2/2] drm/imx: Remove imx_drm_crtc_id() Liu Ying
@ 2016-07-18 8:47 ` Philipp Zabel
1 sibling, 0 replies; 3+ messages in thread
From: Philipp Zabel @ 2016-07-18 8:47 UTC (permalink / raw)
To: Liu Ying; +Cc: dri-devel
Hi Liu,
Am Montag, den 18.07.2016, 15:44 +0800 schrieb Liu Ying:
> There is no one calling imx_drm_crtc_vblank_get/_put() and
> they are just two simple wrappers of drm_crtc_vblank_get/_put()
> without doing any thing fancy - the drivers may call
> drm_crtc_vblank_get/_put() directly. So, let's remove the two
> wrappers.
>
> Signed-off-by: Liu Ying <gnuiyl@gmail.com>
Applied both, thank you.
regards
Philipp
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-07-18 8:47 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-07-18 7:44 [PATCH 1/2] drm/imx: Remove imx_drm_crtc_vblank_get/_put() Liu Ying
2016-07-18 7:44 ` [PATCH 2/2] drm/imx: Remove imx_drm_crtc_id() Liu Ying
2016-07-18 8:47 ` [PATCH 1/2] drm/imx: Remove imx_drm_crtc_vblank_get/_put() Philipp Zabel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox