From: "Pandiyan, Dhinakaran" <dhinakaran.pandiyan@intel.com>
To: "chris@chris-wilson.co.uk" <chris@chris-wilson.co.uk>
Cc: "intel-gfx@lists.freedesktop.org"
<intel-gfx@lists.freedesktop.org>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>
Subject: Re: [PATCH 1/4] drm/i915/dp: Add debug messages to print DP link training pattern
Date: Thu, 4 Aug 2016 16:51:22 +0000 [thread overview]
Message-ID: <1470330331.10898.12.camel@dk-H97M-D3H> (raw)
In-Reply-To: <20160804030712.GA9872@nuc-i3427.alporthouse.com>
On Thu, 2016-08-04 at 04:07 +0100, Chris Wilson wrote:
> On Wed, Aug 03, 2016 at 08:07:38PM -0700, Dhinakaran Pandiyan wrote:
> > @@ -2588,7 +2592,7 @@ _intel_dp_set_link_train(struct intel_dp *intel_dp,
> > *DP |= DP_LINK_TRAIN_PAT_2_CPT;
> > break;
> > case DP_TRAINING_PATTERN_3:
> > - DRM_ERROR("DP training pattern 3 not supported\n");
> > + DRM_ERROR("TPS3 not supported, using TPS2 instead\n");
> > *DP |= DP_LINK_TRAIN_PAT_2_CPT;
> > break;
> > }
> > @@ -2613,7 +2617,7 @@ _intel_dp_set_link_train(struct intel_dp *intel_dp,
> > if (IS_CHERRYVIEW(dev)) {
> > *DP |= DP_LINK_TRAIN_PAT_3_CHV;
> > } else {
> > - DRM_ERROR("DP training pattern 3 not supported\n");
> > + DRM_ERROR("TPS3 not supported, using TPS2 instead\n");
> > *DP |= DP_LINK_TRAIN_PAT_2;
>
> Given that you have a fallback plan and if the fallback plan fails you
> alert the user with an error already, these aren't errors but debug.
> -Chris
>
I will make that change. Thanks for the review.
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2016-08-04 16:51 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-04 3:07 [PATCH 0/4] Improve logging for DP link training Dhinakaran Pandiyan
2016-08-04 3:07 ` [PATCH 1/4] drm/i915/dp: Add debug messages to print DP link training pattern Dhinakaran Pandiyan
2016-08-04 3:07 ` [Intel-gfx] " Chris Wilson
2016-08-04 16:51 ` Pandiyan, Dhinakaran [this message]
2016-08-04 3:07 ` [PATCH 2/4] drm/i915/dp: Switch to using the DRM function for reading DP link status Dhinakaran Pandiyan
2016-08-04 3:11 ` Chris Wilson
2016-08-04 5:48 ` Ville Syrjälä
2016-08-04 3:07 ` [PATCH 3/4] drm/dp: Clarify clock recovery and channel equalization failures Dhinakaran Pandiyan
2016-08-04 3:12 ` Chris Wilson
2016-08-04 16:50 ` Pandiyan, Dhinakaran
2016-08-04 17:07 ` [Intel-gfx] " chris
2016-08-04 3:07 ` [PATCH 4/4] drm/i915/dp: Dump DP link status when link training stages fails Dhinakaran Pandiyan
2016-08-04 7:46 ` [Intel-gfx] " Jani Nikula
2016-08-04 16:46 ` Pandiyan, Dhinakaran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1470330331.10898.12.camel@dk-H97M-D3H \
--to=dhinakaran.pandiyan@intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox