[PATCH V2] drm/panel: simple: Fix bus flags for ortustech com43h4m85ulc

[PATCH V2] drm/panel: simple: Fix bus flags for ortustech com43h4m85ulc

[Marek Vasut]

This display expects DE pin and data lines to be active high,
add the necessary flags.

Signed-off-by: Marek Vasut <marex@denx.de>
Cc: Philipp Zabel <p.zabel@pengutronix.de>
Cc: Thierry Reding <treding@nvidia.com>
---
V2: Add DRM_BUS_FLAG_PIXDATA_POSEDGE to cater for the video data.
---
 drivers/gpu/drm/panel/panel-simple.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
index 3a7bdf1..cb34f95 100644
--- a/drivers/gpu/drm/panel/panel-simple.c
+++ b/drivers/gpu/drm/panel/panel-simple.c
@@ -1198,6 +1198,7 @@ static const struct panel_desc ortustech_com43h4m85ulc = {
 		.height = 93,
 	},
 	.bus_format = MEDIA_BUS_FMT_RGB888_1X24,
+	.bus_flags = DRM_BUS_FLAG_DE_HIGH | DRM_BUS_FLAG_PIXDATA_POSEDGE,
 };
 
 static const struct drm_display_mode qd43003c0_40_mode = {
-- 
2.9.3

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH V2] drm/panel: simple: Fix bus flags for ortustech com43h4m85ulc

[Thierry Reding]

[-- Attachment #1.1: Type: text/plain, Size: 734 bytes --]

On Fri, Aug 26, 2016 at 06:26:00PM +0200, Marek Vasut wrote:
> This display expects DE pin and data lines to be active high,
> add the necessary flags.
> 
> Signed-off-by: Marek Vasut <marex@denx.de>
> Cc: Philipp Zabel <p.zabel@pengutronix.de>
> Cc: Thierry Reding <treding@nvidia.com>
> ---
> V2: Add DRM_BUS_FLAG_PIXDATA_POSEDGE to cater for the video data.
> ---
>  drivers/gpu/drm/panel/panel-simple.c | 1 +
>  1 file changed, 1 insertion(+)

Applied, thanks. I did add Philipp's Reviewed-by from v1, which I assume
would stand since he had suggested the PIXDATA_POSEDGE. I've Cc'ed him
now (it seems your v2 post didn't include him) so he can speak up if he
wants me to remove the Reviewed-by again.

Thierry

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 801 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH V2] drm/panel: simple: Fix bus flags for ortustech com43h4m85ulc

[Philipp Zabel]

Hi Thierry,

Am Freitag, den 16.09.2016, 17:17 +0200 schrieb Thierry Reding:
> On Fri, Aug 26, 2016 at 06:26:00PM +0200, Marek Vasut wrote:
> > This display expects DE pin and data lines to be active high,
> > add the necessary flags.
> > 
> > Signed-off-by: Marek Vasut <marex@denx.de>
> > Cc: Philipp Zabel <p.zabel@pengutronix.de>
> > Cc: Thierry Reding <treding@nvidia.com>
> > ---
> > V2: Add DRM_BUS_FLAG_PIXDATA_POSEDGE to cater for the video data.
> > ---
> >  drivers/gpu/drm/panel/panel-simple.c | 1 +
> >  1 file changed, 1 insertion(+)
> 
> Applied, thanks. I did add Philipp's Reviewed-by from v1, which I assume
> would stand since he had suggested the PIXDATA_POSEDGE. I've Cc'ed him
> now (it seems your v2 post didn't include him) so he can speak up if he
> wants me to remove the Reviewed-by again.
> 
> Thierry

I received v2, just didn't think to re-assert the Reviewed-by. Thank you
for bringing it to my attention, I agree with your deduction.

regards
Philipp

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel