From: Lucas Stach <l.stach@pengutronix.de>
To: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Daniel Vetter <daniel.vetter@intel.com>,
DRI Development <dri-devel@lists.freedesktop.org>
Subject: Re: [PATCH 2/4] drm/fsl: don't use drm_put_dev
Date: Tue, 13 Dec 2016 11:53:53 +0100 [thread overview]
Message-ID: <1481626433.2313.14.camel@pengutronix.de> (raw)
In-Reply-To: <20161208110739.24417-2-daniel.vetter@ffwll.ch>
Am Donnerstag, den 08.12.2016, 12:07 +0100 schrieb Daniel Vetter:
> fsl is already fully demidlayered in the probe function, but for
> convenience stuck with drm_put_dev. Call the unregister/unref parts
> separately, to make sure this driver works correct.
>
> Cc: Stefan Agner <stefan@agner.ch>
> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
> ---
> drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c b/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c
> index 320e4728c9b9..d36bf4f8b3de 100644
> --- a/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c
> +++ b/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c
> @@ -426,7 +426,8 @@ static int fsl_dcu_drm_remove(struct platform_device *pdev)
>
> clk_disable_unprepare(fsl_dev->clk);
> clk_unregister(fsl_dev->pix_clk);
> - drm_put_dev(fsl_dev->drm);
> + drm_dev_unregister(fsl_dev->drm);
> + drm_dev_unref(fsl_dev->drm);
Why not make it work correctly instead of the mechanical change? I.e.
move the drm_dev_unregister() up 2 lines.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2016-12-13 10:53 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-08 11:07 [PATCH 1/4] drm/etnaviv: Use drm_dev_unref, not drm_put_dev Daniel Vetter
2016-12-08 11:07 ` [PATCH 2/4] drm/fsl: don't use drm_put_dev Daniel Vetter
2016-12-13 10:53 ` Lucas Stach [this message]
2016-12-13 17:12 ` Daniel Vetter
2016-12-13 17:54 ` [PATCH] " Daniel Vetter
2016-12-13 17:57 ` Lucas Stach
2016-12-13 21:26 ` Daniel Vetter
2016-12-13 23:29 ` Stefan Agner
2016-12-08 11:07 ` [PATCH 3/4] drm/mediatek: " Daniel Vetter
2016-12-13 10:55 ` Lucas Stach
2016-12-13 17:14 ` Daniel Vetter
2016-12-08 11:07 ` [PATCH 4/4] drm/vc4: Don't " Daniel Vetter
2016-12-09 23:44 ` Eric Anholt
2016-12-13 10:52 ` [PATCH 1/4] drm/etnaviv: Use drm_dev_unref, not drm_put_dev Lucas Stach
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1481626433.2313.14.camel@pengutronix.de \
--to=l.stach@pengutronix.de \
--cc=daniel.vetter@ffwll.ch \
--cc=daniel.vetter@intel.com \
--cc=dri-devel@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox