[PATCH 1/4] drm/etnaviv: Use drm_dev_unref, not drm_put_dev

[PATCH 1/4] drm/etnaviv: Use drm_dev_unref, not drm_put_dev

[Daniel Vetter]

drm_put_dev is the old midlayer-broken device cleanup function, but
etnaviv has a proper unbind function which first unregisters and then
drops the final reference. No functional change since
drm_dev_unregister happens to be idempotent.

Cc: Lucas Stach <l.stach@pengutronix.de>
Cc: Russell King <linux+etnaviv@armlinux.org.uk>
Cc: Christian Gmeiner <christian.gmeiner@gmail.com>
Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
---
 drivers/gpu/drm/etnaviv/etnaviv_drv.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/etnaviv/etnaviv_drv.c b/drivers/gpu/drm/etnaviv/etnaviv_drv.c
index 00368b14d08d..30d70ed143f7 100644
--- a/drivers/gpu/drm/etnaviv/etnaviv_drv.c
+++ b/drivers/gpu/drm/etnaviv/etnaviv_drv.c
@@ -592,7 +592,7 @@ static void etnaviv_unbind(struct device *dev)
 	drm->dev_private = NULL;
 	kfree(priv);
 
-	drm_put_dev(drm);
+	drm_dev_unref(drm);
 }
 
 static const struct component_master_ops etnaviv_master_ops = {
-- 
2.10.2

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[PATCH 2/4] drm/fsl: don't use drm_put_dev

[Daniel Vetter]

fsl is already fully demidlayered in the probe function, but for
convenience stuck with drm_put_dev. Call the unregister/unref parts
separately, to make sure this driver works correct.

Cc: Stefan Agner <stefan@agner.ch>
Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
---
 drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c b/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c
index 320e4728c9b9..d36bf4f8b3de 100644
--- a/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c
+++ b/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c
@@ -426,7 +426,8 @@ static int fsl_dcu_drm_remove(struct platform_device *pdev)
 
 	clk_disable_unprepare(fsl_dev->clk);
 	clk_unregister(fsl_dev->pix_clk);
-	drm_put_dev(fsl_dev->drm);
+	drm_dev_unregister(fsl_dev->drm);
+	drm_dev_unref(fsl_dev->drm);
 
 	return 0;
 }
-- 
2.10.2

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[PATCH 3/4] drm/mediatek: don't use drm_put_dev

[Daniel Vetter]

fsl is already fully demidlayered in the probe function, but for
convenience stuck with drm_put_dev. Call the unregister/unref parts
separately, to make sure this driver works correct.

Cc: Philipp Zabel <p.zabel@pengutronix.de>
Cc: CK Hu <ck.hu@mediatek.com>
Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
---
 drivers/gpu/drm/mediatek/mtk_drm_drv.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/mediatek/mtk_drm_drv.c b/drivers/gpu/drm/mediatek/mtk_drm_drv.c
index 4b7fe7eaec01..b5f88e6d078e 100644
--- a/drivers/gpu/drm/mediatek/mtk_drm_drv.c
+++ b/drivers/gpu/drm/mediatek/mtk_drm_drv.c
@@ -321,7 +321,8 @@ static void mtk_drm_unbind(struct device *dev)
 {
 	struct mtk_drm_private *private = dev_get_drvdata(dev);
 
-	drm_put_dev(private->drm);
+	drm_dev_unregister(private->drm);
+	drm_dev_unref(private->drm);
 	private->drm = NULL;
 }
 
-- 
2.10.2

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[PATCH 4/4] drm/vc4: Don't use drm_put_dev

[Daniel Vetter]

vc4 already has a proper load sequence, but the unload one needed some
fixups: First unregister, and last drop the final ref.

Cc: Eric Anholt <eric@anholt.net>
Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
---
 drivers/gpu/drm/vc4/vc4_drv.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/vc4/vc4_drv.c b/drivers/gpu/drm/vc4/vc4_drv.c
index 1dab9e5b3689..bfaf4e36f7ae 100644
--- a/drivers/gpu/drm/vc4/vc4_drv.c
+++ b/drivers/gpu/drm/vc4/vc4_drv.c
@@ -277,12 +277,14 @@ static void vc4_drm_unbind(struct device *dev)
 	struct drm_device *drm = platform_get_drvdata(pdev);
 	struct vc4_dev *vc4 = to_vc4_dev(drm);
 
+	drm_dev_unregister(drm);
+
 	if (vc4->fbdev)
 		drm_fbdev_cma_fini(vc4->fbdev);
 
 	drm_mode_config_cleanup(drm);
 
-	drm_put_dev(drm);
+	drm_dev_unref(drm);
 }
 
 static const struct component_master_ops vc4_drm_ops = {
-- 
2.10.2

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH 4/4] drm/vc4: Don't use drm_put_dev

[Eric Anholt]

[-- Attachment #1.1: Type: text/plain, Size: 300 bytes --]

Daniel Vetter <daniel.vetter@ffwll.ch> writes:

> vc4 already has a proper load sequence, but the unload one needed some
> fixups: First unregister, and last drop the final ref.
>
> Cc: Eric Anholt <eric@anholt.net>
> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>

Pulled this one.  Thanks!

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH 1/4] drm/etnaviv: Use drm_dev_unref, not drm_put_dev

[Lucas Stach]

Am Donnerstag, den 08.12.2016, 12:07 +0100 schrieb Daniel Vetter:
> drm_put_dev is the old midlayer-broken device cleanup function, but
> etnaviv has a proper unbind function which first unregisters and then
> drops the final reference. No functional change since
> drm_dev_unregister happens to be idempotent.
> 
> Cc: Lucas Stach <l.stach@pengutronix.de>
> Cc: Russell King <linux+etnaviv@armlinux.org.uk>
> Cc: Christian Gmeiner <christian.gmeiner@gmail.com>
> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>

Reviewed-by: Lucas Stach <l.stach@pengutronix.de>
> ---
>  drivers/gpu/drm/etnaviv/etnaviv_drv.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/etnaviv/etnaviv_drv.c b/drivers/gpu/drm/etnaviv/etnaviv_drv.c
> index 00368b14d08d..30d70ed143f7 100644
> --- a/drivers/gpu/drm/etnaviv/etnaviv_drv.c
> +++ b/drivers/gpu/drm/etnaviv/etnaviv_drv.c
> @@ -592,7 +592,7 @@ static void etnaviv_unbind(struct device *dev)
>  	drm->dev_private = NULL;
>  	kfree(priv);
>  
> -	drm_put_dev(drm);
> +	drm_dev_unref(drm);
>  }
>  
>  static const struct component_master_ops etnaviv_master_ops = {


_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH 2/4] drm/fsl: don't use drm_put_dev

[Lucas Stach]

Am Donnerstag, den 08.12.2016, 12:07 +0100 schrieb Daniel Vetter:
> fsl is already fully demidlayered in the probe function, but for
> convenience stuck with drm_put_dev. Call the unregister/unref parts
> separately, to make sure this driver works correct.
> 
> Cc: Stefan Agner <stefan@agner.ch>
> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
> ---
>  drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c b/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c
> index 320e4728c9b9..d36bf4f8b3de 100644
> --- a/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c
> +++ b/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c
> @@ -426,7 +426,8 @@ static int fsl_dcu_drm_remove(struct platform_device *pdev)
>  
>  	clk_disable_unprepare(fsl_dev->clk);
>  	clk_unregister(fsl_dev->pix_clk);
> -	drm_put_dev(fsl_dev->drm);
> +	drm_dev_unregister(fsl_dev->drm);
> +	drm_dev_unref(fsl_dev->drm);

Why not make it work correctly instead of the mechanical change? I.e.
move the drm_dev_unregister() up 2 lines.


_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH 3/4] drm/mediatek: don't use drm_put_dev

[Lucas Stach]

Am Donnerstag, den 08.12.2016, 12:07 +0100 schrieb Daniel Vetter:
> fsl is already fully demidlayered in the probe function, but for
  ^ mediatek not fsl-dcu

> convenience stuck with drm_put_dev. Call the unregister/unref parts
> separately, to make sure this driver works correct.
> 
I don't really see the benefit here, except you want to get rid of
drm_dev_put() completely from the core. But whatever:

Reviewed-by: Lucas Stach <l.stach@pengutronix.de>

> Cc: Philipp Zabel <p.zabel@pengutronix.de>
> Cc: CK Hu <ck.hu@mediatek.com>
> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
> ---
>  drivers/gpu/drm/mediatek/mtk_drm_drv.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/mediatek/mtk_drm_drv.c b/drivers/gpu/drm/mediatek/mtk_drm_drv.c
> index 4b7fe7eaec01..b5f88e6d078e 100644
> --- a/drivers/gpu/drm/mediatek/mtk_drm_drv.c
> +++ b/drivers/gpu/drm/mediatek/mtk_drm_drv.c
> @@ -321,7 +321,8 @@ static void mtk_drm_unbind(struct device *dev)
>  {
>  	struct mtk_drm_private *private = dev_get_drvdata(dev);
>  
> -	drm_put_dev(private->drm);
> +	drm_dev_unregister(private->drm);
> +	drm_dev_unref(private->drm);
>  	private->drm = NULL;
>  }
>  


_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH 2/4] drm/fsl: don't use drm_put_dev

[Daniel Vetter]

On Tue, Dec 13, 2016 at 11:53:53AM +0100, Lucas Stach wrote:
> Am Donnerstag, den 08.12.2016, 12:07 +0100 schrieb Daniel Vetter:
> > fsl is already fully demidlayered in the probe function, but for
> > convenience stuck with drm_put_dev. Call the unregister/unref parts
> > separately, to make sure this driver works correct.
> > 
> > Cc: Stefan Agner <stefan@agner.ch>
> > Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
> > ---
> >  drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> > 
> > diff --git a/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c b/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c
> > index 320e4728c9b9..d36bf4f8b3de 100644
> > --- a/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c
> > +++ b/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c
> > @@ -426,7 +426,8 @@ static int fsl_dcu_drm_remove(struct platform_device *pdev)
> >  
> >  	clk_disable_unprepare(fsl_dev->clk);
> >  	clk_unregister(fsl_dev->pix_clk);
> > -	drm_put_dev(fsl_dev->drm);
> > +	drm_dev_unregister(fsl_dev->drm);
> > +	drm_dev_unref(fsl_dev->drm);
> 
> Why not make it work correctly instead of the mechanical change? I.e.
> move the drm_dev_unregister() up 2 lines.

I have a rebased v2 here which does that, because upstream fsl changed
that. Will resend.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH 3/4] drm/mediatek: don't use drm_put_dev

[Daniel Vetter]

On Tue, Dec 13, 2016 at 11:55:32AM +0100, Lucas Stach wrote:
> Am Donnerstag, den 08.12.2016, 12:07 +0100 schrieb Daniel Vetter:
> > fsl is already fully demidlayered in the probe function, but for
>   ^ mediatek not fsl-dcu
> 
> > convenience stuck with drm_put_dev. Call the unregister/unref parts
> > separately, to make sure this driver works correct.
> > 
> I don't really see the benefit here, except you want to get rid of
> drm_dev_put() completely from the core. But whatever:

Yeah, that's the idea. Also I like probe/remove paths to be symmetric,
this achieves this.

> Reviewed-by: Lucas Stach <l.stach@pengutronix.de>

Merged this and the etnaviv patch to drm-misc, thanks for your review.
-Daniel

> 
> > Cc: Philipp Zabel <p.zabel@pengutronix.de>
> > Cc: CK Hu <ck.hu@mediatek.com>
> > Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
> > ---
> >  drivers/gpu/drm/mediatek/mtk_drm_drv.c | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> > 
> > diff --git a/drivers/gpu/drm/mediatek/mtk_drm_drv.c b/drivers/gpu/drm/mediatek/mtk_drm_drv.c
> > index 4b7fe7eaec01..b5f88e6d078e 100644
> > --- a/drivers/gpu/drm/mediatek/mtk_drm_drv.c
> > +++ b/drivers/gpu/drm/mediatek/mtk_drm_drv.c
> > @@ -321,7 +321,8 @@ static void mtk_drm_unbind(struct device *dev)
> >  {
> >  	struct mtk_drm_private *private = dev_get_drvdata(dev);
> >  
> > -	drm_put_dev(private->drm);
> > +	drm_dev_unregister(private->drm);
> > +	drm_dev_unref(private->drm);
> >  	private->drm = NULL;
> >  }
> >  
> 
> 

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[PATCH] drm/fsl: don't use drm_put_dev

[Daniel Vetter]

fsl is already fully demidlayered in the probe function, but for
convenience stuck with drm_put_dev. Call the unregister/unref parts
separately, to make sure this driver works correct.

v2: Rebase.

Cc: Lucas Stach <l.stach@pengutronix.de>
Cc: Stefan Agner <stefan@agner.ch>
Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
---
 drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c b/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c
index 537ca159ffe5..0b35da73c2b0 100644
--- a/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c
+++ b/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c
@@ -434,7 +434,8 @@ static int fsl_dcu_drm_remove(struct platform_device *pdev)
 {
 	struct fsl_dcu_drm_device *fsl_dev = platform_get_drvdata(pdev);
 
-	drm_put_dev(fsl_dev->drm);
+	drm_dev_unregister(fsl_dev->drm);
+	drm_dev_unref(fsl_dev->drm);
 	clk_disable_unprepare(fsl_dev->clk);
 	clk_unregister(fsl_dev->pix_clk);
 
-- 
2.11.0

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH] drm/fsl: don't use drm_put_dev

[Lucas Stach]

Am Dienstag, den 13.12.2016, 18:54 +0100 schrieb Daniel Vetter:
> fsl is already fully demidlayered in the probe function, but for
> convenience stuck with drm_put_dev. Call the unregister/unref parts
> separately, to make sure this driver works correct.
> 
> v2: Rebase.
> 
> Cc: Lucas Stach <l.stach@pengutronix.de>
> Cc: Stefan Agner <stefan@agner.ch>
> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>

Reviewed-by: Lucas Stach <l.stach@pengutronix.de>

> ---
>  drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c b/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c
> index 537ca159ffe5..0b35da73c2b0 100644
> --- a/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c
> +++ b/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c
> @@ -434,7 +434,8 @@ static int fsl_dcu_drm_remove(struct platform_device *pdev)
>  {
>  	struct fsl_dcu_drm_device *fsl_dev = platform_get_drvdata(pdev);
>  
> -	drm_put_dev(fsl_dev->drm);
> +	drm_dev_unregister(fsl_dev->drm);
> +	drm_dev_unref(fsl_dev->drm);
>  	clk_disable_unprepare(fsl_dev->clk);
>  	clk_unregister(fsl_dev->pix_clk);
>  


_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH] drm/fsl: don't use drm_put_dev

[Daniel Vetter]

On Tue, Dec 13, 2016 at 06:57:59PM +0100, Lucas Stach wrote:
> Am Dienstag, den 13.12.2016, 18:54 +0100 schrieb Daniel Vetter:
> > fsl is already fully demidlayered in the probe function, but for
> > convenience stuck with drm_put_dev. Call the unregister/unref parts
> > separately, to make sure this driver works correct.
> > 
> > v2: Rebase.
> > 
> > Cc: Lucas Stach <l.stach@pengutronix.de>
> > Cc: Stefan Agner <stefan@agner.ch>
> > Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
> 
> Reviewed-by: Lucas Stach <l.stach@pengutronix.de>

Ok, applied this one now too, thanks for your review.
-Daniel

> 
> > ---
> >  drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> > 
> > diff --git a/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c b/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c
> > index 537ca159ffe5..0b35da73c2b0 100644
> > --- a/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c
> > +++ b/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c
> > @@ -434,7 +434,8 @@ static int fsl_dcu_drm_remove(struct platform_device *pdev)
> >  {
> >  	struct fsl_dcu_drm_device *fsl_dev = platform_get_drvdata(pdev);
> >  
> > -	drm_put_dev(fsl_dev->drm);
> > +	drm_dev_unregister(fsl_dev->drm);
> > +	drm_dev_unref(fsl_dev->drm);
> >  	clk_disable_unprepare(fsl_dev->clk);
> >  	clk_unregister(fsl_dev->pix_clk);
> >  
> 
> 

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH] drm/fsl: don't use drm_put_dev

[Stefan Agner]

On 2016-12-13 13:26, Daniel Vetter wrote:
> On Tue, Dec 13, 2016 at 06:57:59PM +0100, Lucas Stach wrote:
>> Am Dienstag, den 13.12.2016, 18:54 +0100 schrieb Daniel Vetter:
>> > fsl is already fully demidlayered in the probe function, but for
>> > convenience stuck with drm_put_dev. Call the unregister/unref parts
>> > separately, to make sure this driver works correct.
>> >
>> > v2: Rebase.
>> >
>> > Cc: Lucas Stach <l.stach@pengutronix.de>
>> > Cc: Stefan Agner <stefan@agner.ch>
>> > Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
>>
>> Reviewed-by: Lucas Stach <l.stach@pengutronix.de>
> 

Sorry for the delay.

> Ok, applied this one now too, thanks for your review.
> -Daniel

FWIW, just tested it now and looks good to me

Acked-by: Stefan Agner <stefan@agner.ch>

--
Stefan

> 
>>
>> > ---
>> >  drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c | 3 ++-
>> >  1 file changed, 2 insertions(+), 1 deletion(-)
>> >
>> > diff --git a/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c b/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c
>> > index 537ca159ffe5..0b35da73c2b0 100644
>> > --- a/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c
>> > +++ b/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c
>> > @@ -434,7 +434,8 @@ static int fsl_dcu_drm_remove(struct platform_device *pdev)
>> >  {
>> >  	struct fsl_dcu_drm_device *fsl_dev = platform_get_drvdata(pdev);
>> >
>> > -	drm_put_dev(fsl_dev->drm);
>> > +	drm_dev_unregister(fsl_dev->drm);
>> > +	drm_dev_unref(fsl_dev->drm);
>> >  	clk_disable_unprepare(fsl_dev->clk);
>> >  	clk_unregister(fsl_dev->pix_clk);
>> >
>>
>>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel