* [PATCH libdrm] tests: kms: screen probe: Get screen mode when con->count_modes is nonzero
@ 2017-11-17 4:47 Liu Ying
0 siblings, 0 replies; only message in thread
From: Liu Ying @ 2017-11-17 4:47 UTC (permalink / raw)
To: dri-devel; +Cc: Thierry Reding
We should not get screen mode when a connector has no modes,
but just leave it be zero.
This may avoid the segmentation fault issue when a connector
status is disconnected, which is caused by memory copying
from a NULL connector mode pointer to a screen mode.
Signed-off-by: Liu Ying <gnuiyl@gmail.com>
---
tests/kms/libkms-test-screen.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/tests/kms/libkms-test-screen.c b/tests/kms/libkms-test-screen.c
index 3369022..9ecf032 100644
--- a/tests/kms/libkms-test-screen.c
+++ b/tests/kms/libkms-test-screen.c
@@ -46,7 +46,8 @@ static void kms_screen_probe(struct kms_screen *screen)
else
screen->connected = false;
- memcpy(&screen->mode, &con->modes[0], sizeof(drmModeModeInfo));
+ if (con->count_modes)
+ memcpy(&screen->mode, &con->modes[0], sizeof(drmModeModeInfo));
screen->width = screen->mode.hdisplay;
screen->height = screen->mode.vdisplay;
--
2.7.4
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2017-11-17 6:20 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-11-17 4:47 [PATCH libdrm] tests: kms: screen probe: Get screen mode when con->count_modes is nonzero Liu Ying
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox