* [PATCH v1 06/15] drm/bridge: analogix-anx78xx: Remove duplicate NULL check [not found] <20171031142149.32512-1-andriy.shevchenko@linux.intel.com> @ 2017-10-31 14:21 ` Andy Shevchenko 2017-10-31 14:21 ` [PATCH v1 07/15] drm/i2c/sil164: " Andy Shevchenko 2017-10-31 14:21 ` [PATCH v1 08/15] drm/i2c: tda998x: " Andy Shevchenko 2 siblings, 0 replies; 6+ messages in thread From: Andy Shevchenko @ 2017-10-31 14:21 UTC (permalink / raw) To: linux-i2c, Wolfram Sang Cc: Andy Shevchenko, Archit Taneja, Andrzej Hajda, Laurent Pinchart, David Airlie, dri-devel Since i2c_unregister_device() became NULL-aware we may remove duplicate NULL check. Cc: Archit Taneja <architt@codeaurora.org> Cc: Andrzej Hajda <a.hajda@samsung.com> Cc: Laurent Pinchart <Laurent.pinchart@ideasonboard.com> Cc: David Airlie <airlied@linux.ie> Cc: dri-devel@lists.freedesktop.org Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> --- drivers/gpu/drm/bridge/analogix-anx78xx.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/bridge/analogix-anx78xx.c b/drivers/gpu/drm/bridge/analogix-anx78xx.c index 9385eb0b1ee4..e2925e425f90 100644 --- a/drivers/gpu/drm/bridge/analogix-anx78xx.c +++ b/drivers/gpu/drm/bridge/analogix-anx78xx.c @@ -1303,8 +1303,7 @@ static void unregister_i2c_dummy_clients(struct anx78xx *anx78xx) unsigned int i; for (i = 0; i < ARRAY_SIZE(anx78xx->i2c_dummy); i++) - if (anx78xx->i2c_dummy[i]) - i2c_unregister_device(anx78xx->i2c_dummy[i]); + i2c_unregister_device(anx78xx->i2c_dummy[i]); } static const struct regmap_config anx78xx_regmap_config = { -- 2.14.2 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH v1 07/15] drm/i2c/sil164: Remove duplicate NULL check [not found] <20171031142149.32512-1-andriy.shevchenko@linux.intel.com> 2017-10-31 14:21 ` [PATCH v1 06/15] drm/bridge: analogix-anx78xx: Remove duplicate NULL check Andy Shevchenko @ 2017-10-31 14:21 ` Andy Shevchenko 2017-10-31 14:21 ` [PATCH v1 08/15] drm/i2c: tda998x: " Andy Shevchenko 2 siblings, 0 replies; 6+ messages in thread From: Andy Shevchenko @ 2017-10-31 14:21 UTC (permalink / raw) To: linux-i2c, Wolfram Sang; +Cc: Andy Shevchenko, David Airlie, dri-devel Since i2c_unregister_device() became NULL-aware we may remove duplicate NULL check. Cc: David Airlie <airlied@linux.ie> Cc: dri-devel@lists.freedesktop.org Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> --- drivers/gpu/drm/i2c/sil164_drv.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i2c/sil164_drv.c b/drivers/gpu/drm/i2c/sil164_drv.c index ecaa58757529..c52d7a3af786 100644 --- a/drivers/gpu/drm/i2c/sil164_drv.c +++ b/drivers/gpu/drm/i2c/sil164_drv.c @@ -326,8 +326,7 @@ sil164_encoder_destroy(struct drm_encoder *encoder) { struct sil164_priv *priv = to_sil164_priv(encoder); - if (priv->duallink_slave) - i2c_unregister_device(priv->duallink_slave); + i2c_unregister_device(priv->duallink_slave); kfree(priv); drm_i2c_encoder_destroy(encoder); -- 2.14.2 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH v1 08/15] drm/i2c: tda998x: Remove duplicate NULL check [not found] <20171031142149.32512-1-andriy.shevchenko@linux.intel.com> 2017-10-31 14:21 ` [PATCH v1 06/15] drm/bridge: analogix-anx78xx: Remove duplicate NULL check Andy Shevchenko 2017-10-31 14:21 ` [PATCH v1 07/15] drm/i2c/sil164: " Andy Shevchenko @ 2017-10-31 14:21 ` Andy Shevchenko 2017-10-31 17:03 ` Russell King - ARM Linux 2 siblings, 1 reply; 6+ messages in thread From: Andy Shevchenko @ 2017-10-31 14:21 UTC (permalink / raw) To: linux-i2c, Wolfram Sang Cc: Andy Shevchenko, Russell King, David Airlie, dri-devel Since i2c_unregister_device() became NULL-aware we may remove duplicate NULL check. Cc: Russell King <linux@armlinux.org.uk> Cc: David Airlie <airlied@linux.ie> Cc: dri-devel@lists.freedesktop.org Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> --- drivers/gpu/drm/i2c/tda998x_drv.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i2c/tda998x_drv.c b/drivers/gpu/drm/i2c/tda998x_drv.c index 4d1f45acf2cd..7a349e85f964 100644 --- a/drivers/gpu/drm/i2c/tda998x_drv.c +++ b/drivers/gpu/drm/i2c/tda998x_drv.c @@ -1602,8 +1602,7 @@ static int tda998x_create(struct i2c_client *client, struct tda998x_priv *priv) /* if encoder_init fails, the encoder slave is never registered, * so cleanup here: */ - if (priv->cec) - i2c_unregister_device(priv->cec); + i2c_unregister_device(priv->cec); return -ENXIO; } -- 2.14.2 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH v1 08/15] drm/i2c: tda998x: Remove duplicate NULL check 2017-10-31 14:21 ` [PATCH v1 08/15] drm/i2c: tda998x: " Andy Shevchenko @ 2017-10-31 17:03 ` Russell King - ARM Linux 2018-01-18 15:21 ` Ville Syrjälä 0 siblings, 1 reply; 6+ messages in thread From: Russell King - ARM Linux @ 2017-10-31 17:03 UTC (permalink / raw) To: Andy Shevchenko; +Cc: linux-i2c, Wolfram Sang, David Airlie, dri-devel On Tue, Oct 31, 2017 at 04:21:42PM +0200, Andy Shevchenko wrote: > Since i2c_unregister_device() became NULL-aware we may remove duplicate > NULL check. > > Cc: Russell King <linux@armlinux.org.uk> Acked-by: Russell King <rmk+kernel@armlinux.org.uk> Thanks. > Cc: David Airlie <airlied@linux.ie> > Cc: dri-devel@lists.freedesktop.org > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > --- > drivers/gpu/drm/i2c/tda998x_drv.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/i2c/tda998x_drv.c b/drivers/gpu/drm/i2c/tda998x_drv.c > index 4d1f45acf2cd..7a349e85f964 100644 > --- a/drivers/gpu/drm/i2c/tda998x_drv.c > +++ b/drivers/gpu/drm/i2c/tda998x_drv.c > @@ -1602,8 +1602,7 @@ static int tda998x_create(struct i2c_client *client, struct tda998x_priv *priv) > /* if encoder_init fails, the encoder slave is never registered, > * so cleanup here: > */ > - if (priv->cec) > - i2c_unregister_device(priv->cec); > + i2c_unregister_device(priv->cec); > return -ENXIO; > } > > -- > 2.14.2 > -- RMK's Patch system: http://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line in suburbia: sync at 8.8Mbps down 630kbps up According to speedtest.net: 8.21Mbps down 510kbps up ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v1 08/15] drm/i2c: tda998x: Remove duplicate NULL check 2017-10-31 17:03 ` Russell King - ARM Linux @ 2018-01-18 15:21 ` Ville Syrjälä 2018-01-18 15:27 ` Andy Shevchenko 0 siblings, 1 reply; 6+ messages in thread From: Ville Syrjälä @ 2018-01-18 15:21 UTC (permalink / raw) To: Russell King - ARM Linux Cc: Andy Shevchenko, David Airlie, linux-i2c, dri-devel, Wolfram Sang On Tue, Oct 31, 2017 at 05:03:43PM +0000, Russell King - ARM Linux wrote: > On Tue, Oct 31, 2017 at 04:21:42PM +0200, Andy Shevchenko wrote: > > Since i2c_unregister_device() became NULL-aware we may remove duplicate > > NULL check. > > > > Cc: Russell King <linux@armlinux.org.uk> > > Acked-by: Russell King <rmk+kernel@armlinux.org.uk> commit 7b43dd19c9b1 ("i2c: Make i2c_unregister_device() NULL-aware") seems to be the thing that makes this possible. So these three patches lgtm -> pushed to drm-misc-next. > > Thanks. > > > Cc: David Airlie <airlied@linux.ie> > > Cc: dri-devel@lists.freedesktop.org > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > > --- > > drivers/gpu/drm/i2c/tda998x_drv.c | 3 +-- > > 1 file changed, 1 insertion(+), 2 deletions(-) > > > > diff --git a/drivers/gpu/drm/i2c/tda998x_drv.c b/drivers/gpu/drm/i2c/tda998x_drv.c > > index 4d1f45acf2cd..7a349e85f964 100644 > > --- a/drivers/gpu/drm/i2c/tda998x_drv.c > > +++ b/drivers/gpu/drm/i2c/tda998x_drv.c > > @@ -1602,8 +1602,7 @@ static int tda998x_create(struct i2c_client *client, struct tda998x_priv *priv) > > /* if encoder_init fails, the encoder slave is never registered, > > * so cleanup here: > > */ > > - if (priv->cec) > > - i2c_unregister_device(priv->cec); > > + i2c_unregister_device(priv->cec); > > return -ENXIO; > > } > > > > -- > > 2.14.2 > > > > -- > RMK's Patch system: http://www.armlinux.org.uk/developer/patches/ > FTTC broadband for 0.8mile line in suburbia: sync at 8.8Mbps down 630kbps up > According to speedtest.net: 8.21Mbps down 510kbps up > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel -- Ville Syrjälä Intel OTC ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v1 08/15] drm/i2c: tda998x: Remove duplicate NULL check 2018-01-18 15:21 ` Ville Syrjälä @ 2018-01-18 15:27 ` Andy Shevchenko 0 siblings, 0 replies; 6+ messages in thread From: Andy Shevchenko @ 2018-01-18 15:27 UTC (permalink / raw) To: Ville Syrjälä, Russell King - ARM Linux Cc: David Airlie, linux-i2c, dri-devel, Wolfram Sang On Thu, 2018-01-18 at 17:21 +0200, Ville Syrjälä wrote: > On Tue, Oct 31, 2017 at 05:03:43PM +0000, Russell King - ARM Linux > wrote: > > On Tue, Oct 31, 2017 at 04:21:42PM +0200, Andy Shevchenko wrote: > > > Since i2c_unregister_device() became NULL-aware we may remove > > > duplicate > > > NULL check. > > > > > > Cc: Russell King <linux@armlinux.org.uk> > > > > Acked-by: Russell King <rmk+kernel@armlinux.org.uk> > > commit 7b43dd19c9b1 ("i2c: Make i2c_unregister_device() NULL-aware") > seems to be the thing that makes this possible. So these three > patches lgtm -> pushed to drm-misc-next. > Thanks, Ville! > > > > Thanks. > > > > > Cc: David Airlie <airlied@linux.ie> > > > Cc: dri-devel@lists.freedesktop.org > > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > > > --- > > > drivers/gpu/drm/i2c/tda998x_drv.c | 3 +-- > > > 1 file changed, 1 insertion(+), 2 deletions(-) > > > > > > diff --git a/drivers/gpu/drm/i2c/tda998x_drv.c > > > b/drivers/gpu/drm/i2c/tda998x_drv.c > > > index 4d1f45acf2cd..7a349e85f964 100644 > > > --- a/drivers/gpu/drm/i2c/tda998x_drv.c > > > +++ b/drivers/gpu/drm/i2c/tda998x_drv.c > > > @@ -1602,8 +1602,7 @@ static int tda998x_create(struct i2c_client > > > *client, struct tda998x_priv *priv) > > > /* if encoder_init fails, the encoder slave is never > > > registered, > > > * so cleanup here: > > > */ > > > - if (priv->cec) > > > - i2c_unregister_device(priv->cec); > > > + i2c_unregister_device(priv->cec); > > > return -ENXIO; > > > } > > > > > > -- > > > 2.14.2 > > > > > > > -- > > RMK's Patch system: http://www.armlinux.org.uk/developer/patches/ > > FTTC broadband for 0.8mile line in suburbia: sync at 8.8Mbps down > > 630kbps up > > According to speedtest.net: 8.21Mbps down 510kbps up > > _______________________________________________ > > dri-devel mailing list > > dri-devel@lists.freedesktop.org > > https://lists.freedesktop.org/mailman/listinfo/dri-devel > > -- Andy Shevchenko <andriy.shevchenko@linux.intel.com> Intel Finland Oy ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-01-18 15:27 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20171031142149.32512-1-andriy.shevchenko@linux.intel.com>
2017-10-31 14:21 ` [PATCH v1 06/15] drm/bridge: analogix-anx78xx: Remove duplicate NULL check Andy Shevchenko
2017-10-31 14:21 ` [PATCH v1 07/15] drm/i2c/sil164: " Andy Shevchenko
2017-10-31 14:21 ` [PATCH v1 08/15] drm/i2c: tda998x: " Andy Shevchenko
2017-10-31 17:03 ` Russell King - ARM Linux
2018-01-18 15:21 ` Ville Syrjälä
2018-01-18 15:27 ` Andy Shevchenko
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox