[PATCH] drm/etnaviv: fix for 64bit seqno change

[PATCH] drm/etnaviv: fix for 64bit seqno change

[Christian König]

The fence seqno is now 64bit, fixes build warning.

Signed-off-by: Christian König <christian.koenig@amd.com>
---
 drivers/gpu/drm/etnaviv/etnaviv_gem.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/etnaviv/etnaviv_gem.c b/drivers/gpu/drm/etnaviv/etnaviv_gem.c
index 1fa74226db91..5c48915f492d 100644
--- a/drivers/gpu/drm/etnaviv/etnaviv_gem.c
+++ b/drivers/gpu/drm/etnaviv/etnaviv_gem.c
@@ -449,7 +449,7 @@ static void etnaviv_gem_describe_fence(struct dma_fence *fence,
 	const char *type, struct seq_file *m)
 {
 	if (!test_bit(DMA_FENCE_FLAG_SIGNALED_BIT, &fence->flags))
-		seq_printf(m, "\t%9s: %s %s seq %u\n",
+		seq_printf(m, "\t%9s: %s %s seq %llu\n",
 			   type,
 			   fence->ops->get_driver_name(fence),
 			   fence->ops->get_timeline_name(fence),
-- 
2.14.1

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH] drm/etnaviv: fix for 64bit seqno change

[Alex Deucher]

On Fri, Dec 7, 2018 at 2:11 PM Christian König
<ckoenig.leichtzumerken@gmail.com> wrote:
>
> The fence seqno is now 64bit, fixes build warning.
>
> Signed-off-by: Christian König <christian.koenig@amd.com>

Acked-by: Alex Deucher <alexander.deucher@amd.com>

> ---
>  drivers/gpu/drm/etnaviv/etnaviv_gem.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/etnaviv/etnaviv_gem.c b/drivers/gpu/drm/etnaviv/etnaviv_gem.c
> index 1fa74226db91..5c48915f492d 100644
> --- a/drivers/gpu/drm/etnaviv/etnaviv_gem.c
> +++ b/drivers/gpu/drm/etnaviv/etnaviv_gem.c
> @@ -449,7 +449,7 @@ static void etnaviv_gem_describe_fence(struct dma_fence *fence,
>         const char *type, struct seq_file *m)
>  {
>         if (!test_bit(DMA_FENCE_FLAG_SIGNALED_BIT, &fence->flags))
> -               seq_printf(m, "\t%9s: %s %s seq %u\n",
> +               seq_printf(m, "\t%9s: %s %s seq %llu\n",
>                            type,
>                            fence->ops->get_driver_name(fence),
>                            fence->ops->get_timeline_name(fence),
> --
> 2.14.1
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH] drm/etnaviv: fix for 64bit seqno change

[kbuild test robot]

[-- Attachment #1: Type: text/plain, Size: 1939 bytes --]

Hi Christian,

I love your patch! Perhaps something to improve:

[auto build test WARNING on linus/master]
[also build test WARNING on v4.20-rc5 next-20181207]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Christian-K-nig/drm-etnaviv-fix-for-64bit-seqno-change/20181208-062755
config: arm-allmodconfig (attached as .config)
compiler: arm-linux-gnueabi-gcc (Debian 7.2.0-11) 7.2.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        GCC_VERSION=7.2.0 make.cross ARCH=arm 

All warnings (new ones prefixed by >>):

   drivers/gpu/drm/etnaviv/etnaviv_gem.c: In function 'etnaviv_gem_describe_fence':
>> drivers/gpu/drm/etnaviv/etnaviv_gem.c:452:38: warning: format '%llu' expects argument of type 'long long unsigned int', but argument 6 has type 'unsigned int' [-Wformat=]
      seq_printf(m, "\t%9s: %s %s seq %llu\n",
                                      ~~~^
                                      %u
   drivers/gpu/drm/etnaviv/etnaviv_gem.c:456:7:
          fence->seqno);
          ~~~~~~~~~~~~                    

vim +452 drivers/gpu/drm/etnaviv/etnaviv_gem.c

   446	
   447	#ifdef CONFIG_DEBUG_FS
   448	static void etnaviv_gem_describe_fence(struct dma_fence *fence,
   449		const char *type, struct seq_file *m)
   450	{
   451		if (!test_bit(DMA_FENCE_FLAG_SIGNALED_BIT, &fence->flags))
 > 452			seq_printf(m, "\t%9s: %s %s seq %llu\n",
   453				   type,
   454				   fence->ops->get_driver_name(fence),
   455				   fence->ops->get_timeline_name(fence),
   456				   fence->seqno);
   457	}
   458	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 67826 bytes --]

[-- Attachment #3: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH] drm/etnaviv: fix for 64bit seqno change

[Lucas Stach]

Am Freitag, den 07.12.2018, 20:11 +0100 schrieb Christian König:
> The fence seqno is now 64bit, fixes build warning.
> 
> Signed-off-by: Christian König <christian.koenig@amd.com>

Acked-by: Lucas Stach <l.stach@pengutronix.de> 

> ---
>  drivers/gpu/drm/etnaviv/etnaviv_gem.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/etnaviv/etnaviv_gem.c
> b/drivers/gpu/drm/etnaviv/etnaviv_gem.c
> index 1fa74226db91..5c48915f492d 100644
> --- a/drivers/gpu/drm/etnaviv/etnaviv_gem.c
> +++ b/drivers/gpu/drm/etnaviv/etnaviv_gem.c
> @@ -449,7 +449,7 @@ static void etnaviv_gem_describe_fence(struct
> dma_fence *fence,
>  	const char *type, struct seq_file *m)
>  {
>  	if (!test_bit(DMA_FENCE_FLAG_SIGNALED_BIT, &fence->flags))
> -		seq_printf(m, "\t%9s: %s %s seq %u\n",
> +		seq_printf(m, "\t%9s: %s %s seq %llu\n",
>  			   type,
>  			   fence->ops->get_driver_name(fence),
>  			   fence->ops->get_timeline_name(fence),
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel