[GIT PULL] drm/imx: pending update handling, plane zpos property

[GIT PULL] drm/imx: pending update handling, plane zpos property

[Philipp Zabel]

Hi Dave, Daniel,

please consider merging these imx-drm updates for v5.1.

The branch sits on top of yesterday's drm/imx fixes and adds support for
pending update handling, plane zpos property, builds under COMPILE_TEST
on all platforms.

regards
Philipp

The following changes since commit eb0200a4357da100064971689d3a0e9e3cf57f33:

  gpu: ipu-v3: pre: don't trigger update if buffer address doesn't change (2019-01-23 11:56:44 +0100)

are available in the Git repository at:

  git://git.pengutronix.de/pza/linux tags/imx-drm-next-2019-02-13

for you to fetch changes up to e4a2457f459bba3509bc8d9dd4b62f94a35f0fb7:

  drm/imx: only send commit done event when all state has been applied (2019-01-30 11:01:13 +0100)

----------------------------------------------------------------
drm/imx: handle pending updates better, add plane zpos property support

- Add a mechanism to only send commit done events once all pending
  updates have been applied. This closes a small race window where
  already armed events could fire even though the double buffered
  hardware update just missed the update window.
- Add plane zpos property support to allow placing the overlay plane
  behind the primary plane.
- Allow building imx-drm on all platforms under COMPILE_TEST.

----------------------------------------------------------------
Lucas Stach (4):
      gpu: ipu-v3: pre: add double buffer status readback
      gpu: ipu-v3: prg: add function to get channel configure status
      drm/imx: ipuv3-plane: add function to query atomic update status
      drm/imx: only send commit done event when all state has been applied

Philipp Zabel (3):
      drm/imx: ipuv3-plane: add zpos property
      drm/imx: imx-tve: depend on COMMON_CLK
      drm/imx: allow building under COMPILE_TEST

 drivers/gpu/drm/imx/Kconfig        |  3 +-
 drivers/gpu/drm/imx/imx-drm-core.c |  7 +---
 drivers/gpu/drm/imx/ipuv3-crtc.c   | 30 ++++++++++++++-
 drivers/gpu/drm/imx/ipuv3-plane.c  | 76 +++++++++++++++++++++++++-------------
 drivers/gpu/drm/imx/ipuv3-plane.h  |  2 +
 drivers/gpu/ipu-v3/ipu-pre.c       |  6 +++
 drivers/gpu/ipu-v3/ipu-prg.c       | 16 ++++++++
 drivers/gpu/ipu-v3/ipu-prv.h       |  1 +
 include/video/imx-ipu-v3.h         |  1 +
 9 files changed, 109 insertions(+), 33 deletions(-)
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [GIT PULL] drm/imx: pending update handling, plane zpos property

[Daniel Vetter]

On Wed, Feb 13, 2019 at 05:06:38PM +0100, Philipp Zabel wrote:
> Hi Dave, Daniel,
> 
> please consider merging these imx-drm updates for v5.1.
> 
> The branch sits on top of yesterday's drm/imx fixes and adds support for
> pending update handling, plane zpos property, builds under COMPILE_TEST
> on all platforms.

Fixes: tags aren't up to what sfr in linux-next is checking recently:

dim: 7e92397d3a83 ("drm/imx: ipuv3-plane: add zpos property"): mandatory review missing.
dim: bb867d219fda ("gpu: ipu-v3: Fix CSI offsets for imx53"): Fixes: SHA1 needs at least 12 digits:
dim:     2ffd48f2e7 ("gpu: ipu-v3: Add Camera Sensor Interface unit")
dim: 2c0408dd0d89 ("gpu: ipu-v3: Fix i.MX51 CSI control registers offset"): Fixes: SHA1 needs at least 12 digits:
dim:     2ffd48f2e7 ("gpu: ipu-v3: Add Camera Sensor Interface unit")
dim: 4fb873c9648e ("drm/imx: ignore plane updates on disabled crtcs"): mandatory review missing.

While you fix that, some 2nd pair of eyes on the 2 patches without r-b/a-b
tag would be nice too, so I don't have too :-)

Thanks, Daniel

> 
> regards
> Philipp
> 
> The following changes since commit eb0200a4357da100064971689d3a0e9e3cf57f33:
> 
>   gpu: ipu-v3: pre: don't trigger update if buffer address doesn't change (2019-01-23 11:56:44 +0100)
> 
> are available in the Git repository at:
> 
>   git://git.pengutronix.de/pza/linux tags/imx-drm-next-2019-02-13
> 
> for you to fetch changes up to e4a2457f459bba3509bc8d9dd4b62f94a35f0fb7:
> 
>   drm/imx: only send commit done event when all state has been applied (2019-01-30 11:01:13 +0100)
> 
> ----------------------------------------------------------------
> drm/imx: handle pending updates better, add plane zpos property support
> 
> - Add a mechanism to only send commit done events once all pending
>   updates have been applied. This closes a small race window where
>   already armed events could fire even though the double buffered
>   hardware update just missed the update window.
> - Add plane zpos property support to allow placing the overlay plane
>   behind the primary plane.
> - Allow building imx-drm on all platforms under COMPILE_TEST.
> 
> ----------------------------------------------------------------
> Lucas Stach (4):
>       gpu: ipu-v3: pre: add double buffer status readback
>       gpu: ipu-v3: prg: add function to get channel configure status
>       drm/imx: ipuv3-plane: add function to query atomic update status
>       drm/imx: only send commit done event when all state has been applied
> 
> Philipp Zabel (3):
>       drm/imx: ipuv3-plane: add zpos property
>       drm/imx: imx-tve: depend on COMMON_CLK
>       drm/imx: allow building under COMPILE_TEST
> 
>  drivers/gpu/drm/imx/Kconfig        |  3 +-
>  drivers/gpu/drm/imx/imx-drm-core.c |  7 +---
>  drivers/gpu/drm/imx/ipuv3-crtc.c   | 30 ++++++++++++++-
>  drivers/gpu/drm/imx/ipuv3-plane.c  | 76 +++++++++++++++++++++++++-------------
>  drivers/gpu/drm/imx/ipuv3-plane.h  |  2 +
>  drivers/gpu/ipu-v3/ipu-pre.c       |  6 +++
>  drivers/gpu/ipu-v3/ipu-prg.c       | 16 ++++++++
>  drivers/gpu/ipu-v3/ipu-prv.h       |  1 +
>  include/video/imx-ipu-v3.h         |  1 +
>  9 files changed, 109 insertions(+), 33 deletions(-)

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [GIT PULL] drm/imx: pending update handling, plane zpos property

[Philipp Zabel]

Hi Daniel,

On Thu, 2019-02-14 at 14:06 +0100, Daniel Vetter wrote:
> On Wed, Feb 13, 2019 at 05:06:38PM +0100, Philipp Zabel wrote:
> > Hi Dave, Daniel,
> > 
> > please consider merging these imx-drm updates for v5.1.
> > 
> > The branch sits on top of yesterday's drm/imx fixes and adds support for
> > pending update handling, plane zpos property, builds under COMPILE_TEST
> > on all platforms.
> 
> Fixes: tags aren't up to what sfr in linux-next is checking recently:

Unfortunatly I only got the warning once the patches were already merged
into drm-fixes, even though they had been in linux-next via imx-drm/next 
for a while.

> dim: 7e92397d3a83 ("drm/imx: ipuv3-plane: add zpos property"): mandatory review missing.

Apart from this one,

> dim: bb867d219fda ("gpu: ipu-v3: Fix CSI offsets for imx53"): Fixes: SHA1 needs at least 12 digits:
> dim:     2ffd48f2e7 ("gpu: ipu-v3: Add Camera Sensor Interface unit")
> dim: 2c0408dd0d89 ("gpu: ipu-v3: Fix i.MX51 CSI control registers offset"): Fixes: SHA1 needs at least 12 digits:
> dim:     2ffd48f2e7 ("gpu: ipu-v3: Add Camera Sensor Interface unit")
> dim: 4fb873c9648e ("drm/imx: ignore plane updates on disabled crtcs"): mandatory review missing.

these are part of the already merged imx-drm-fixes-2019-02-12 tag.
Should I fix and recreate the imx-drm-fixes tag, and if so, would you
replace the already merged patches in drm-fixes with the new tag?

regards
Philipp
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [GIT PULL] drm/imx: pending update handling, plane zpos property

[Daniel Vetter]

On Thu, Feb 14, 2019 at 03:19:18PM +0100, Philipp Zabel wrote:
> Hi Daniel,
> 
> On Thu, 2019-02-14 at 14:06 +0100, Daniel Vetter wrote:
> > On Wed, Feb 13, 2019 at 05:06:38PM +0100, Philipp Zabel wrote:
> > > Hi Dave, Daniel,
> > > 
> > > please consider merging these imx-drm updates for v5.1.
> > > 
> > > The branch sits on top of yesterday's drm/imx fixes and adds support for
> > > pending update handling, plane zpos property, builds under COMPILE_TEST
> > > on all platforms.
> > 
> > Fixes: tags aren't up to what sfr in linux-next is checking recently:
> 
> Unfortunatly I only got the warning once the patches were already merged
> into drm-fixes, even though they had been in linux-next via imx-drm/next 
> for a while.

That's why the checks are now in our maintainer tools too, to catch them
before they land anywhere.

> > dim: 7e92397d3a83 ("drm/imx: ipuv3-plane: add zpos property"): mandatory review missing.
> 
> Apart from this one,
> 
> > dim: bb867d219fda ("gpu: ipu-v3: Fix CSI offsets for imx53"): Fixes: SHA1 needs at least 12 digits:
> > dim:     2ffd48f2e7 ("gpu: ipu-v3: Add Camera Sensor Interface unit")
> > dim: 2c0408dd0d89 ("gpu: ipu-v3: Fix i.MX51 CSI control registers offset"): Fixes: SHA1 needs at least 12 digits:
> > dim:     2ffd48f2e7 ("gpu: ipu-v3: Add Camera Sensor Interface unit")
> > dim: 4fb873c9648e ("drm/imx: ignore plane updates on disabled crtcs"): mandatory review missing.
> 
> these are part of the already merged imx-drm-fixes-2019-02-12 tag.
> Should I fix and recreate the imx-drm-fixes tag, and if so, would you
> replace the already merged patches in drm-fixes with the new tag?

No rebasing of existing stuff ofc. I didn't even realize that this is also
partially in -fixes (yeah I know should have read the cover letter). Need
to wait for the next -rc to include those first so that there's a neat
backmerge I think, not sure. An ack on the zpos patch should still be
nice.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [GIT PULL] drm/imx: pending update handling, plane zpos property

[Daniel Vetter]

On Thu, Feb 14, 2019 at 03:50:57PM +0100, Daniel Vetter wrote:
> On Thu, Feb 14, 2019 at 03:19:18PM +0100, Philipp Zabel wrote:
> > Hi Daniel,
> > 
> > On Thu, 2019-02-14 at 14:06 +0100, Daniel Vetter wrote:
> > > On Wed, Feb 13, 2019 at 05:06:38PM +0100, Philipp Zabel wrote:
> > > > Hi Dave, Daniel,
> > > > 
> > > > please consider merging these imx-drm updates for v5.1.
> > > > 
> > > > The branch sits on top of yesterday's drm/imx fixes and adds support for
> > > > pending update handling, plane zpos property, builds under COMPILE_TEST
> > > > on all platforms.
> > > 
> > > Fixes: tags aren't up to what sfr in linux-next is checking recently:
> > 
> > Unfortunatly I only got the warning once the patches were already merged
> > into drm-fixes, even though they had been in linux-next via imx-drm/next 
> > for a while.
> 
> That's why the checks are now in our maintainer tools too, to catch them
> before they land anywhere.
> 
> > > dim: 7e92397d3a83 ("drm/imx: ipuv3-plane: add zpos property"): mandatory review missing.
> > 
> > Apart from this one,
> > 
> > > dim: bb867d219fda ("gpu: ipu-v3: Fix CSI offsets for imx53"): Fixes: SHA1 needs at least 12 digits:
> > > dim:     2ffd48f2e7 ("gpu: ipu-v3: Add Camera Sensor Interface unit")
> > > dim: 2c0408dd0d89 ("gpu: ipu-v3: Fix i.MX51 CSI control registers offset"): Fixes: SHA1 needs at least 12 digits:
> > > dim:     2ffd48f2e7 ("gpu: ipu-v3: Add Camera Sensor Interface unit")
> > > dim: 4fb873c9648e ("drm/imx: ignore plane updates on disabled crtcs"): mandatory review missing.
> > 
> > these are part of the already merged imx-drm-fixes-2019-02-12 tag.
> > Should I fix and recreate the imx-drm-fixes tag, and if so, would you
> > replace the already merged patches in drm-fixes with the new tag?
> 
> No rebasing of existing stuff ofc. I didn't even realize that this is also
> partially in -fixes (yeah I know should have read the cover letter). Need
> to wait for the next -rc to include those first so that there's a neat
> backmerge I think, not sure. An ack on the zpos patch should still be
> nice.

Discussed the "-fixes in -next" thing with Dave on irc, he's not a huge
fan of that approach either. Topic branch (if there is a need),
cherry-picking (with reasons), or just plain separate branches all
preferred to stacking -next on top of -fixes.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [GIT PULL] drm/imx: pending update handling, plane zpos property

[Philipp Zabel]

Hi Daniel,

On Thu, 2019-02-14 at 21:20 +0100, Daniel Vetter wrote:
> On Thu, Feb 14, 2019 at 03:50:57PM +0100, Daniel Vetter wrote:
> > On Thu, Feb 14, 2019 at 03:19:18PM +0100, Philipp Zabel wrote:
> > > Hi Daniel,
> > > 
> > > On Thu, 2019-02-14 at 14:06 +0100, Daniel Vetter wrote:
> > > > On Wed, Feb 13, 2019 at 05:06:38PM +0100, Philipp Zabel wrote:
> > > > > Hi Dave, Daniel,
> > > > > 
> > > > > please consider merging these imx-drm updates for v5.1.
> > > > > 
> > > > > The branch sits on top of yesterday's drm/imx fixes and adds support for
> > > > > pending update handling, plane zpos property, builds under COMPILE_TEST
> > > > > on all platforms.
> > > > 
> > > > Fixes: tags aren't up to what sfr in linux-next is checking recently:
> > > 
> > > Unfortunatly I only got the warning once the patches were already merged
> > > into drm-fixes, even though they had been in linux-next via imx-drm/next 
> > > for a while.
> > 
> > That's why the checks are now in our maintainer tools too, to catch them
> > before they land anywhere.

Excellent, thank you.

> > > > dim: 7e92397d3a83 ("drm/imx: ipuv3-plane: add zpos property"): mandatory review missing.
> > > 
> > > Apart from this one,
> > > 
> > > > dim: bb867d219fda ("gpu: ipu-v3: Fix CSI offsets for imx53"): Fixes: SHA1 needs at least 12 digits:
> > > > dim:     2ffd48f2e7 ("gpu: ipu-v3: Add Camera Sensor Interface unit")
> > > > dim: 2c0408dd0d89 ("gpu: ipu-v3: Fix i.MX51 CSI control registers offset"): Fixes: SHA1 needs at least 12 digits:
> > > > dim:     2ffd48f2e7 ("gpu: ipu-v3: Add Camera Sensor Interface unit")
> > > > dim: 4fb873c9648e ("drm/imx: ignore plane updates on disabled crtcs"): mandatory review missing.
> > > 
> > > these are part of the already merged imx-drm-fixes-2019-02-12 tag.
> > > Should I fix and recreate the imx-drm-fixes tag, and if so, would you
> > > replace the already merged patches in drm-fixes with the new tag?
> > 
> > No rebasing of existing stuff ofc. I didn't even realize that this is also
> > partially in -fixes (yeah I know should have read the cover letter). Need
> > to wait for the next -rc to include those first so that there's a neat
> > backmerge I think, not sure. An ack on the zpos patch should still be
> > nice.



> Discussed the "-fixes in -next" thing with Dave on irc, he's not a huge
> fan of that approach either. Topic branch (if there is a need),
> cherry-picking (with reasons), or just plain separate branches all
> preferred to stacking -next on top of -fixes.

Understood.

I'm embarrassed to realize that stacking the two wasn't even necessary.
I'll rebase the -next and send a proper pull request without the -fixes
in there.

regards
Philipp
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [GIT PULL] drm/imx: pending update handling, plane zpos property

[Daniel Vetter]

On Fri, Feb 15, 2019 at 11:17:53AM +0100, Philipp Zabel wrote:
> Hi Daniel,
> 
> On Thu, 2019-02-14 at 21:20 +0100, Daniel Vetter wrote:
> > On Thu, Feb 14, 2019 at 03:50:57PM +0100, Daniel Vetter wrote:
> > > On Thu, Feb 14, 2019 at 03:19:18PM +0100, Philipp Zabel wrote:
> > > > Hi Daniel,
> > > > 
> > > > On Thu, 2019-02-14 at 14:06 +0100, Daniel Vetter wrote:
> > > > > On Wed, Feb 13, 2019 at 05:06:38PM +0100, Philipp Zabel wrote:
> > > > > > Hi Dave, Daniel,
> > > > > > 
> > > > > > please consider merging these imx-drm updates for v5.1.
> > > > > > 
> > > > > > The branch sits on top of yesterday's drm/imx fixes and adds support for
> > > > > > pending update handling, plane zpos property, builds under COMPILE_TEST
> > > > > > on all platforms.
> > > > > 
> > > > > Fixes: tags aren't up to what sfr in linux-next is checking recently:
> > > > 
> > > > Unfortunatly I only got the warning once the patches were already merged
> > > > into drm-fixes, even though they had been in linux-next via imx-drm/next 
> > > > for a while.
> > > 
> > > That's why the checks are now in our maintainer tools too, to catch them
> > > before they land anywhere.
> 
> Excellent, thank you.
> 
> > > > > dim: 7e92397d3a83 ("drm/imx: ipuv3-plane: add zpos property"): mandatory review missing.
> > > > 
> > > > Apart from this one,
> > > > 
> > > > > dim: bb867d219fda ("gpu: ipu-v3: Fix CSI offsets for imx53"): Fixes: SHA1 needs at least 12 digits:
> > > > > dim:     2ffd48f2e7 ("gpu: ipu-v3: Add Camera Sensor Interface unit")
> > > > > dim: 2c0408dd0d89 ("gpu: ipu-v3: Fix i.MX51 CSI control registers offset"): Fixes: SHA1 needs at least 12 digits:
> > > > > dim:     2ffd48f2e7 ("gpu: ipu-v3: Add Camera Sensor Interface unit")
> > > > > dim: 4fb873c9648e ("drm/imx: ignore plane updates on disabled crtcs"): mandatory review missing.
> > > > 
> > > > these are part of the already merged imx-drm-fixes-2019-02-12 tag.
> > > > Should I fix and recreate the imx-drm-fixes tag, and if so, would you
> > > > replace the already merged patches in drm-fixes with the new tag?
> > > 
> > > No rebasing of existing stuff ofc. I didn't even realize that this is also
> > > partially in -fixes (yeah I know should have read the cover letter). Need
> > > to wait for the next -rc to include those first so that there's a neat
> > > backmerge I think, not sure. An ack on the zpos patch should still be
> > > nice.
> 
> 
> 
> > Discussed the "-fixes in -next" thing with Dave on irc, he's not a huge
> > fan of that approach either. Topic branch (if there is a need),
> > cherry-picking (with reasons), or just plain separate branches all
> > preferred to stacking -next on top of -fixes.
> 
> Understood.
> 
> I'm embarrassed to realize that stacking the two wasn't even necessary.
> I'll rebase the -next and send a proper pull request without the -fixes
> in there.

Either works, with the -rc6 close it's easy to backmerge now.

Thanks, Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[GIT PULL] drm/imx: pending update handling, plane zpos property

[Philipp Zabel]

please consider merging these imx-drm updates for v5.1.
Same content as the imx-drm-next-2019-02-13 pull request, but rebased
onto v5.0-rc7, with a Tested-by: on the zpos patch, and two commit typo
fixes in commit messages.

regards
Philipp

The following changes since commit a3b22b9f11d9fbc48b0291ea92259a5a810e9438:

  Linux 5.0-rc7 (2019-02-17 18:46:40 -0800)

are available in the Git repository at:

  git://git.pengutronix.de/pza/linux tags/imx-drm-next-2019-02-22

for you to fetch changes up to a0ea4ffff2662c10ca69d5e246adf5543fd945b9:

  drm/imx: only send commit done event when all state has been applied (2019-02-22 12:17:58 +0100)

----------------------------------------------------------------
drm/imx: handle pending updates better, add plane zpos property support

- Add a mechanism to only send commit done events once all pending
  updates have been applied. This closes a small race window where
  already armed events could fire even though the double buffered
  hardware update just missed the update window.
- Add plane zpos property support to allow placing the overlay plane
  behind the primary plane.
- Allow building imx-drm on all platforms under COMPILE_TEST.

----------------------------------------------------------------
Lucas Stach (4):
      gpu: ipu-v3: pre: add double buffer status readback
      gpu: ipu-v3: prg: add function to get channel configure status
      drm/imx: ipuv3-plane: add function to query atomic update status
      drm/imx: only send commit done event when all state has been applied

Philipp Zabel (3):
      drm/imx: ipuv3-plane: add zpos property
      drm/imx: imx-tve: depend on COMMON_CLK
      drm/imx: allow building under COMPILE_TEST

 drivers/gpu/drm/imx/Kconfig        |  3 +-
 drivers/gpu/drm/imx/imx-drm-core.c |  7 +---
 drivers/gpu/drm/imx/ipuv3-crtc.c   | 30 ++++++++++++++-
 drivers/gpu/drm/imx/ipuv3-plane.c  | 76 +++++++++++++++++++++++++-------------
 drivers/gpu/drm/imx/ipuv3-plane.h  |  2 +
 drivers/gpu/ipu-v3/ipu-pre.c       |  6 +++
 drivers/gpu/ipu-v3/ipu-prg.c       | 16 ++++++++
 drivers/gpu/ipu-v3/ipu-prv.h       |  1 +
 include/video/imx-ipu-v3.h         |  1 +
 9 files changed, 109 insertions(+), 33 deletions(-)
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel