From: Paul Cercueil <paul@crapouillou.net>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: Sam Ravnborg <sam@ravnborg.org>, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm/ingenic: Hardcode panel type to DPI
Date: Fri, 23 Aug 2019 23:30:09 +0200 [thread overview]
Message-ID: <1566595809.1871.0@crapouillou.net> (raw)
In-Reply-To: <20190823212353.29369-1-laurent.pinchart@ideasonboard.com>
Hi Laurent,
Le ven. 23 août 2019 à 23:23, Laurent Pinchart
<laurent.pinchart@ideasonboard.com> a écrit :
> The ingenic driver supports DPI panels only at the moment, so hardcode
> their type to DPI instead of Unknown.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> Paul, as the driver has been merged in v5.3-rc1, this is a candidate
> for
> a v5.3 fix. Keeping the connector type as unknown could cause a
> userspace dependency on it, preventing it from being changed later.
Makes sense.
Reviewed-by: Paul Cercueil <paul@crapouillou.net>
>
> diff --git a/drivers/gpu/drm/ingenic/ingenic-drm.c
> b/drivers/gpu/drm/ingenic/ingenic-drm.c
> index ce1fae3a78a9..2e2ed653e9c6 100644
> --- a/drivers/gpu/drm/ingenic/ingenic-drm.c
> +++ b/drivers/gpu/drm/ingenic/ingenic-drm.c
> @@ -675,10 +675,9 @@ static int ingenic_drm_probe(struct
> platform_device *pdev)
> return ret;
> }
>
> - if (panel) {
> + if (panel)
> bridge = devm_drm_panel_bridge_add(dev, panel,
> - DRM_MODE_CONNECTOR_Unknown);
> - }
> + DRM_MODE_CONNECTOR_DPI);
>
> priv->dma_hwdesc = dma_alloc_coherent(dev,
> sizeof(*priv->dma_hwdesc),
> &priv->dma_hwdesc_phys,
> --
> Regards,
>
> Laurent Pinchart
>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2019-08-23 21:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-23 21:23 [PATCH] drm/ingenic: Hardcode panel type to DPI Laurent Pinchart
2019-08-23 21:30 ` Paul Cercueil [this message]
2019-08-27 5:00 ` Sam Ravnborg
2019-08-29 10:03 ` Paul Cercueil
2019-08-29 14:46 ` Laurent Pinchart
2019-08-31 12:29 ` Paul Cercueil
2019-09-02 8:23 ` Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1566595809.1871.0@crapouillou.net \
--to=paul@crapouillou.net \
--cc=dri-devel@lists.freedesktop.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=sam@ravnborg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox