From: Sam Ravnborg <sam@ravnborg.org>
To: Paul Cercueil <paul@crapouillou.net>
Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm/ingenic: Hardcode panel type to DPI
Date: Tue, 27 Aug 2019 07:00:54 +0200 [thread overview]
Message-ID: <20190827050054.GA22071@ravnborg.org> (raw)
In-Reply-To: <1566595809.1871.0@crapouillou.net>
On Fri, Aug 23, 2019 at 11:30:09PM +0200, Paul Cercueil wrote:
> Hi Laurent,
>
>
> Le ven. 23 août 2019 à 23:23, Laurent Pinchart
> <laurent.pinchart@ideasonboard.com> a écrit :
> > The ingenic driver supports DPI panels only at the moment, so hardcode
> > their type to DPI instead of Unknown.
> >
> > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> > ---
> > Paul, as the driver has been merged in v5.3-rc1, this is a candidate for
> > a v5.3 fix. Keeping the connector type as unknown could cause a
> > userspace dependency on it, preventing it from being changed later.
>
> Makes sense.
>
> Reviewed-by: Paul Cercueil <paul@crapouillou.net>
In another mail we discuss CONNECTOR_PANEL. But we should not hold up
due to this.
Reviewed-by: Sam Ravnborg <sam@ravnborg.org>
Paul - will you apply to drm-misc-fixes?
Sam
>
>
> >
> > diff --git a/drivers/gpu/drm/ingenic/ingenic-drm.c
> > b/drivers/gpu/drm/ingenic/ingenic-drm.c
> > index ce1fae3a78a9..2e2ed653e9c6 100644
> > --- a/drivers/gpu/drm/ingenic/ingenic-drm.c
> > +++ b/drivers/gpu/drm/ingenic/ingenic-drm.c
> > @@ -675,10 +675,9 @@ static int ingenic_drm_probe(struct platform_device
> > *pdev)
> > return ret;
> > }
> >
> > - if (panel) {
> > + if (panel)
> > bridge = devm_drm_panel_bridge_add(dev, panel,
> > - DRM_MODE_CONNECTOR_Unknown);
> > - }
> > + DRM_MODE_CONNECTOR_DPI);
> >
> > priv->dma_hwdesc = dma_alloc_coherent(dev, sizeof(*priv->dma_hwdesc),
> > &priv->dma_hwdesc_phys,
> > --
> > Regards,
> >
> > Laurent Pinchart
> >
>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2019-08-27 5:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-23 21:23 [PATCH] drm/ingenic: Hardcode panel type to DPI Laurent Pinchart
2019-08-23 21:30 ` Paul Cercueil
2019-08-27 5:00 ` Sam Ravnborg [this message]
2019-08-29 10:03 ` Paul Cercueil
2019-08-29 14:46 ` Laurent Pinchart
2019-08-31 12:29 ` Paul Cercueil
2019-09-02 8:23 ` Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190827050054.GA22071@ravnborg.org \
--to=sam@ravnborg.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=paul@crapouillou.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox