Re: [RFC] drm: implement DRM_IOCTL_MODE_SETROTATION

[Jakob Bornecrantz <jakob@vmware.com>]

----- Original Message -----
> From: Paulo Zanoni <paulo.r.zanoni@intel.com>
> 
> This ioctl is used to signal the drivers that the screen is rotated,
> not to make the drivers rotate the screen.
>  - add a driver-specific "rotation_set" function
>  - implement Intel's rotation_set by setting the right values to the
>    PIPECONF registers.
> 
> The idea is that when user-space does rotation, it can call this
> ioctl to inform the Kernel that we have a rotation. This feature is
> needed by the KVMr feature of VPro.
> 
> Signed-off-by: Paulo Zanoni <paulo.r.zanoni@intel.com>

Couldn't this be done by just adding a property instead of a ioctl?

Also the name make it sound like you are setting the rotation and not
just setting a hint, so the word hit should probably be in the name.


Cheers Jakob.