[PATCH 0/1] Increase timeout in i915_gem_contexts selftests

[PATCH 0/1] Increase timeout in i915_gem_contexts selftests

[Matthew Brost]

Patch says it all. Seeing a failure in CI [1] and locally on certain TGL
machines with GuC submission enabled. Let's fix this so we can enable CI
on TGL with GuC submission.

Signed-off-by: Matthew Brost <matthew.brost@intel.com>

[1] https://patchwork.freedesktop.org/series/92984/#rev4

Matthew Brost (1):
  drm/i915/selftests: Increase timeout in i915_gem_contexts selftests

 drivers/gpu/drm/i915/gem/selftests/i915_gem_context.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
2.28.0

[PATCH 1/1] drm/i915/selftests: Increase timeout in i915_gem_contexts selftests

[Matthew Brost]

Like in the case of several other selftests, generating lots of requests
in a loop takes a bit longer with GuC submission. Increase a timeout in
i915_gem_contexts selftest to take this into account.

Signed-off-by: Matthew Brost <matthew.brost@intel.com>
---
 drivers/gpu/drm/i915/gem/selftests/i915_gem_context.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/gem/selftests/i915_gem_context.c b/drivers/gpu/drm/i915/gem/selftests/i915_gem_context.c
index 8eb5050f8cb3..4d2758718d21 100644
--- a/drivers/gpu/drm/i915/gem/selftests/i915_gem_context.c
+++ b/drivers/gpu/drm/i915/gem/selftests/i915_gem_context.c
@@ -94,7 +94,7 @@ static int live_nop_switch(void *arg)
 			rq = i915_request_get(this);
 			i915_request_add(this);
 		}
-		if (i915_request_wait(rq, 0, HZ / 5) < 0) {
+		if (i915_request_wait(rq, 0, HZ) < 0) {
 			pr_err("Failed to populated %d contexts\n", nctx);
 			intel_gt_set_wedged(&i915->gt);
 			i915_request_put(rq);
-- 
2.28.0

Re: [PATCH 1/1] drm/i915/selftests: Increase timeout in i915_gem_contexts selftests

[John Harrison]

On 7/26/2021 20:17, Matthew Brost wrote:
> Like in the case of several other selftests, generating lots of requests
> in a loop takes a bit longer with GuC submission. Increase a timeout in
> i915_gem_contexts selftest to take this into account.
>
> Signed-off-by: Matthew Brost <matthew.brost@intel.com>
Reviewed-by: John Harrison <John.C.Harrison@Intel.com>

> ---
>   drivers/gpu/drm/i915/gem/selftests/i915_gem_context.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/gem/selftests/i915_gem_context.c b/drivers/gpu/drm/i915/gem/selftests/i915_gem_context.c
> index 8eb5050f8cb3..4d2758718d21 100644
> --- a/drivers/gpu/drm/i915/gem/selftests/i915_gem_context.c
> +++ b/drivers/gpu/drm/i915/gem/selftests/i915_gem_context.c
> @@ -94,7 +94,7 @@ static int live_nop_switch(void *arg)
>   			rq = i915_request_get(this);
>   			i915_request_add(this);
>   		}
> -		if (i915_request_wait(rq, 0, HZ / 5) < 0) {
> +		if (i915_request_wait(rq, 0, HZ) < 0) {
>   			pr_err("Failed to populated %d contexts\n", nctx);
>   			intel_gt_set_wedged(&i915->gt);
>   			i915_request_put(rq);