From: Greg KH <greg@kroah.com>
To: Alex Deucher <alexdeucher@gmail.com>
Cc: Sergej Pupykin <ml@sergej.pp.ru>,
dri-devel@lists.freedesktop.org, stable@kernel.org
Subject: Re: [stable] [PATCH] drm/kms: remove spaces from connector names
Date: Wed, 8 Dec 2010 15:30:26 -0800 [thread overview]
Message-ID: <20101208233026.GA10898@kroah.com> (raw)
In-Reply-To: <1291850043-7742-1-git-send-email-alexdeucher@gmail.com>
On Wed, Dec 08, 2010 at 06:14:03PM -0500, Alex Deucher wrote:
> Grub doesn't parse spaces in parameters correctly, so
> this makes it impossible to force video= parameters
> for kms on the grub kernel command line.
>
> Reported-by: Sergej Pupykin <ml@sergej.pp.ru>
>
> Cc: Sergej Pupykin <ml@sergej.pp.ru>
> Signed-off-by: Alex Deucher <alexdeucher@gmail.com>
> Cc: stable@kernel.org
> ---
> drivers/gpu/drm/drm_crtc.c | 8 ++++----
> 1 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/drm_crtc.c b/drivers/gpu/drm/drm_crtc.c
> index 6985cb1..7ee7a2f 100644
> --- a/drivers/gpu/drm/drm_crtc.c
> +++ b/drivers/gpu/drm/drm_crtc.c
> @@ -156,12 +156,12 @@ static struct drm_conn_prop_enum_list drm_connector_enum_list[] =
> { DRM_MODE_CONNECTOR_SVIDEO, "SVIDEO", 0 },
> { DRM_MODE_CONNECTOR_LVDS, "LVDS", 0 },
> { DRM_MODE_CONNECTOR_Component, "Component", 0 },
> - { DRM_MODE_CONNECTOR_9PinDIN, "9-pin DIN", 0 },
What kernel version did these options first show up in? Does any
other tools rely on the spaces?
thanks,
greg k-h
next prev parent reply other threads:[~2010-12-08 23:30 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-08 23:14 [PATCH] drm/kms: remove spaces from connector names Alex Deucher
2010-12-08 23:30 ` Greg KH [this message]
2010-12-08 23:32 ` Dave Airlie
2010-12-09 17:18 ` Jesse Barnes
2010-12-09 17:33 ` Sergej Pupykin
2010-12-09 17:46 ` Jesse Barnes
2010-12-09 22:15 ` [stable] " Peter Stuge
2010-12-10 12:24 ` Sergej Pupykin
2010-12-10 18:05 ` Peter Stuge
2010-12-13 10:43 ` [stable] " Sergej Pupykin
2010-12-13 11:31 ` Sergej Pupykin
2010-12-09 0:01 ` Dave Airlie
2010-12-09 0:04 ` Alex Deucher
2010-12-09 0:09 ` [PATCH] drm/kms: remove spaces from connector names (v2) Alex Deucher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101208233026.GA10898@kroah.com \
--to=greg@kroah.com \
--cc=alexdeucher@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=ml@sergej.pp.ru \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).