Re: [PATCH] drm/kms: remove spaces from connector names

[Jesse Barnes <jbarnes@virtuousgeek.org>]

On Wed, 8 Dec 2010 15:30:26 -0800
Greg KH <greg@kroah.com> wrote:

> On Wed, Dec 08, 2010 at 06:14:03PM -0500, Alex Deucher wrote:
> > Grub doesn't parse spaces in parameters correctly, so
> > this makes it impossible to force video= parameters
> > for kms on the grub kernel command line.
> > 
> > Reported-by: Sergej Pupykin <ml@sergej.pp.ru>
> > 
> > Cc: Sergej Pupykin <ml@sergej.pp.ru>
> > Signed-off-by: Alex Deucher <alexdeucher@gmail.com>
> > Cc: stable@kernel.org
> > ---
> >  drivers/gpu/drm/drm_crtc.c |    8 ++++----
> >  1 files changed, 4 insertions(+), 4 deletions(-)
> > 
> > diff --git a/drivers/gpu/drm/drm_crtc.c b/drivers/gpu/drm/drm_crtc.c
> > index 6985cb1..7ee7a2f 100644
> > --- a/drivers/gpu/drm/drm_crtc.c
> > +++ b/drivers/gpu/drm/drm_crtc.c
> > @@ -156,12 +156,12 @@ static struct drm_conn_prop_enum_list drm_connector_enum_list[] =
> >  	{ DRM_MODE_CONNECTOR_SVIDEO, "SVIDEO", 0 },
> >  	{ DRM_MODE_CONNECTOR_LVDS, "LVDS", 0 },
> >  	{ DRM_MODE_CONNECTOR_Component, "Component", 0 },
> > -	{ DRM_MODE_CONNECTOR_9PinDIN, "9-pin DIN", 0 },
> 
> What kernel version did these options first show up in?  Does any
> other tools rely on the spaces?

And it's ugly; can't we fix grub instead?

-- 
Jesse Barnes, Intel Open Source Technology Center