dri-devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Jesse Barnes <jbarnes@virtuousgeek.org>
To: Keith Packard <keithp@keithp.com>
Cc: dri-devel@lists.freedesktop.org
Subject: Re: [RFC] drm: add overlays as first class KMS objects
Date: Mon, 25 Apr 2011 16:58:17 -0700	[thread overview]
Message-ID: <20110425165817.60ad730d@jbarnes-desktop> (raw)
In-Reply-To: <yunzkndgawl.fsf@aiko.keithp.com>

On Mon, 25 Apr 2011 16:37:46 -0700
Keith Packard <keithp@keithp.com> wrote:

> On Mon, 25 Apr 2011 16:22:16 -0700, Jesse Barnes <jbarnes@virtuousgeek.org> wrote:
> 
> > Yes, that matches my understanding as well.  I've deliberately made the
> > implementation flexible there though, under the assumption that some
> > hardware allows a plane to be directed at more than one CRTC (though
> > probably not simultaneously).
> 
> So you create a scanout buffer and assign it to the appropriate slot in
> the CRTC. Describing *how* the CRTC mixes pixels would be a good idea,
> so the ordering of the slots might be relevant, and they might have a
> blend mode (per-pixel alpha values, color key, separate alpha plane, etc).

Yeah, pixel blending and z order should be exposed.  I think that means
returning more info in the get_overlay_res ioctl.  Hm.. not sure of the
best way of representing that...

> > Arguably, this is something we should have done when the
> > connector/encoder split was done (making planes in general first class
> > objects).  But with today's code, treating a CRTC as a pixel pump and a
> > primary plane seems fine, with overlays tacked onto the side as
> > secondary pixel sources but tied to a specific CRTC.
> 
> I know of hardware that needs a lot more than one overlay...

Yeah I don't want to preclude that (and I don't think this
implementation does; it allows a many to one relationship between
overlays and CRTCs). TVs in particular can get messy since the z order
may be semi-fixed between certain planes, and blending may be limited to
different types at different layers.

-- 
Jesse Barnes, Intel Open Source Technology Center

  reply	other threads:[~2011-04-25 23:58 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-25 22:12 [RFC] drm: add overlays as first class KMS objects Jesse Barnes
2011-04-25 23:16 ` Keith Packard
2011-04-25 23:22   ` Jesse Barnes
2011-04-25 23:35     ` Stéphane Marchesin
2011-04-25 23:52       ` Jesse Barnes
2011-04-26  1:17         ` Keith Packard
2011-04-26  9:37         ` Alan Cox
2011-04-28 16:24       ` Rob Clark
2011-04-25 23:37     ` Keith Packard
2011-04-25 23:58       ` Jesse Barnes [this message]
2011-04-26  0:28     ` Alex Deucher
2011-04-26  0:33       ` Jesse Barnes
2011-04-26 14:01         ` Jerome Glisse
2011-04-26 14:16           ` Alan Cox
2011-04-26 15:11             ` Jerome Glisse
2011-04-26 15:29               ` Alan Cox
2011-04-26 10:01       ` Alan Cox
2011-04-26 15:16         ` Jesse Barnes
2011-04-28 16:32         ` Rob Clark
2011-04-26 15:20   ` Ville Syrjälä
2011-04-26 15:31     ` Jesse Barnes
2011-04-26 15:38     ` Alan Cox
2011-04-27 12:19 ` Daniel Vetter
2011-04-27 13:32   ` Jerome Glisse
2011-04-27 14:27     ` Daniel Vetter
2011-04-27 14:34       ` Chris Wilson
2011-04-27 14:50         ` Daniel Vetter
2011-04-27 14:56         ` Ville Syrjälä
2011-04-27 21:12   ` Jesse Barnes
2011-04-28  6:47     ` Daniel Vetter
2011-04-28 17:37     ` Jakob Bornecrantz
2011-04-28 17:03 ` Rob Clark
2011-04-28 17:54   ` Ville Syrjälä
2011-05-13 16:16 ` Daniel Vetter
2011-05-14  1:02   ` Jesse Barnes
2011-05-15  0:00     ` Clark, Rob
2011-05-17 18:35   ` Laurent Pinchart

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110425165817.60ad730d@jbarnes-desktop \
    --to=jbarnes@virtuousgeek.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=keithp@keithp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox