From: Jesse Barnes <jbarnes@virtuousgeek.org>
To: christopher.halse.rogers@canonical.com
Cc: dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 3/3] drm: Factor-out drm_emit_vblank_event code.
Date: Thu, 28 Apr 2011 13:36:17 -0700 [thread overview]
Message-ID: <20110428133617.18026c59@jbarnes-desktop> (raw)
In-Reply-To: <1303884659-739-3-git-send-email-christopher.halse.rogers@canonical.com>
On Wed, 27 Apr 2011 16:10:59 +1000
christopher.halse.rogers@canonical.com wrote:
> From: Christopher James Halse Rogers <christopher.halse.rogers@canonical.com>
>
> Signed-off-by: Christopher James Halse Rogers <christopher.halse.rogers@canonical.com>
> ---
> drivers/gpu/drm/drm_irq.c | 39 ++++++++++++++++-----------------------
> 1 files changed, 16 insertions(+), 23 deletions(-)
>
Oh I see you already addressed my last comment. :)
I think Michel is right about the put; the event queue holds the ref
and the emit should drop it, so keeping them together seems good to me.
Other than that,
Reviewed-by: Jesse Barnes <jbarnes@virtuousgeek.org>
same for the first patch now that you've addressed my cleanup issue.
--
Jesse Barnes, Intel Open Source Technology Center
next prev parent reply other threads:[~2011-04-28 20:36 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-27 6:10 [PATCH 1/3] drm: Send pending vblank events before disabling vblank christopher.halse.rogers
2011-04-27 6:10 ` [PATCH 2/3] drm: Warn if vblank state has become inconsistent christopher.halse.rogers
2011-04-27 8:38 ` Michel Dänzer
2011-04-27 6:10 ` [PATCH 3/3] drm: Factor-out drm_emit_vblank_event code christopher.halse.rogers
2011-04-27 8:36 ` Michel Dänzer
2011-04-27 8:48 ` Christopher James Halse Rogers
2011-04-27 9:06 ` Michel Dänzer
2011-04-28 20:36 ` Jesse Barnes [this message]
2011-04-29 3:57 ` [PATCH] drm: Factor-out drm_emit_vblank_event code. (v2) christopher.halse.rogers
2011-04-29 6:43 ` Michel Dänzer
2011-04-29 15:55 ` Marcin Slusarz
2011-05-01 23:55 ` Christopher James Halse Rogers
2011-05-02 0:09 ` [PATCH] drm: Factor-out drm_emit_vblank_event code. (v3) christopher.halse.rogers
2011-04-27 8:32 ` [PATCH 1/3] drm: Send pending vblank events before disabling vblank Michel Dänzer
2011-04-27 8:58 ` Christopher James Halse Rogers
2011-04-27 9:08 ` Michel Dänzer
2011-04-27 9:17 ` Christopher James Halse Rogers
2011-04-28 8:09 ` Christopher James Halse Rogers
2011-04-28 20:46 ` Jesse Barnes
2011-04-28 20:53 ` Jesse Barnes
2011-04-28 20:42 ` Jesse Barnes
2011-04-28 20:34 ` Jesse Barnes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110428133617.18026c59@jbarnes-desktop \
--to=jbarnes@virtuousgeek.org \
--cc=christopher.halse.rogers@canonical.com \
--cc=dri-devel@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox