Re: [PATCH] Pack swap complete bits into an XEvent

[Jesse Barnes <jbarnes-Y1mF5jBUw70BENJcbMCuUQ@public.gmane.org>]

On Thu, 28 Apr 2011 14:33:58 -0700
Eric Anholt <eric-WhKQ6XTQaPysTnJN9+BGXg@public.gmane.org> wrote:

> On Thu, 28 Apr 2011 13:27:19 -0700, Jesse Barnes <jbarnes-Y1mF5jBUw70BENJcbMCuUQ@public.gmane.org> wrote:
> > The defintion of the swap complete event was wrong; XEvents are only 32
> > bytes long, and with padding the swap event was longer.  So use some
> > creative packing to get all the bits we want transmitted.  Requires a
> > proto version bump.
> > ---
> >  configure.ac |    2 +-
> >  glxproto.h   |   13 +++++++++----
> >  2 files changed, 10 insertions(+), 5 deletions(-)
> > 
> > diff --git a/configure.ac b/configure.ac
> > index d88e6df..a3047e4 100644
> > --- a/configure.ac
> > +++ b/configure.ac
> > @@ -1,5 +1,5 @@
> >  AC_PREREQ([2.60])
> > -AC_INIT([GLProto], [1.4.12], [https://bugs.freedesktop.org/enter_bug.cgi?product=xorg])
> > +AC_INIT([GLProto], [1.4.13], [https://bugs.freedesktop.org/enter_bug.cgi?product=xorg])
> >  AM_INIT_AUTOMAKE([foreign dist-bzip2])
> >  AM_MAINTAINER_MODE
> >  
> > diff --git a/glxproto.h b/glxproto.h
> > index 0ff44e3..4a583c1 100644
> > --- a/glxproto.h
> > +++ b/glxproto.h
> > @@ -1370,18 +1370,23 @@ typedef struct {
> >      CARD32 unused2 B32;
> >  } xGLXPbufferClobberEvent;
> >  
> > +/* Note, this struct is too large for an Xevent, I fail -- jbarnes
> > + * So sbc_lo won't ever be sent.  We can use a generic event though without
> > + * size restrictions, thus xGLXBufferSwapComplete2.
> > + */
> 
> This comment doesn't seem to match the change.

double fail. will fix.

-- 
Jesse Barnes, Intel Open Source Technology Center
_______________________________________________
xorg-devel-go0+a7rfsptAfugRpC6u6w@public.gmane.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel