From: Jesse Barnes <jbarnes@virtuousgeek.org>
To: Wolfram Sang <w.sang@pengutronix.de>
Cc: dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: add check for valid init_clock_gating-pointer
Date: Thu, 16 Jun 2011 08:15:57 -0700 [thread overview]
Message-ID: <20110616081557.5f64f603@jbarnes-desktop> (raw)
In-Reply-To: <20110616132846.GE23579@pengutronix.de>
On Thu, 16 Jun 2011 15:28:46 +0200
Wolfram Sang <w.sang@pengutronix.de> wrote:
> > > Commit 6067aa (drm/i915: split clock gating init into per-chipset
> > > functions) unconditionally calls the newly created
> > > init_clock_gating-pointer. There is one case, however, where it does
> > > not get set:
> > >
> > > if (HAS_PCH_SPLIT(dev)) {
> > > ...
> > > } else
> > > dev_priv->display.update_wm = NULL;
> > > }
> >
> > We'll only hit this path on non-existent hardware. Since a clock
> > gating routine is required I'd rather just see the panic and add a new
> > routine at that time (i.e. what we normally do during bringup).
>
> How about BUG_ON(!ptr) in the init-routine for a bit more grace? And/or
> a warning in the else-block? It seems to happen to users...
Yeah, a BUG_ON would be fine.
--
Jesse Barnes, Intel Open Source Technology Center
next prev parent reply other threads:[~2011-06-16 15:16 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-15 22:24 [PATCH] drm/i915: add check for valid init_clock_gating-pointer Wolfram Sang
2011-06-15 22:30 ` Jesse Barnes
2011-06-16 13:28 ` Wolfram Sang
2011-06-16 15:15 ` Jesse Barnes [this message]
2011-06-16 15:47 ` Chris Wilson
2011-06-19 19:22 ` Wolfram Sang
2011-06-19 20:04 ` Chris Wilson
2011-06-20 16:10 ` [PATCH] drm/i915: gracefully bail out when init_clock_gating-pointer is not set Wolfram Sang
2011-06-20 16:43 ` Chris Wilson
2011-06-20 17:36 ` [PATCH V2] " Wolfram Sang
2011-06-20 17:38 ` Jesse Barnes
2011-07-02 15:55 ` Wolfram Sang
2011-07-02 18:00 ` Jesse Barnes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110616081557.5f64f603@jbarnes-desktop \
--to=jbarnes@virtuousgeek.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=w.sang@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox