From: Jesse Barnes <jbarnes@virtuousgeek.org>
To: Wolfram Sang <w.sang@pengutronix.de>
Cc: dri-devel@lists.freedesktop.org
Subject: Re: [PATCH V2] drm/i915: gracefully bail out when init_clock_gating-pointer is not set
Date: Sat, 2 Jul 2011 11:00:07 -0700 [thread overview]
Message-ID: <20110702110007.4393473e@jbarnes-desktop> (raw)
In-Reply-To: <20110702155553.GA18188@pengutronix.de>
On Sat, 2 Jul 2011 17:55:53 +0200
Wolfram Sang <w.sang@pengutronix.de> wrote:
> On Mon, Jun 20, 2011 at 10:38:54AM -0700, Jesse Barnes wrote:
> > On Mon, 20 Jun 2011 19:36:11 +0200
> > Wolfram Sang <w.sang@pengutronix.de> wrote:
> >
> > > Commit 6067aa (drm/i915: split clock gating init into per-chipset
> > > functions) introduces an init_clock_gating-pointer. There is one case,
> > > however, where it does not get set, so that caused an OOPS. Change the
> > > code to return -ENODEV in this case and propagate it to the upper
> > > layers.
> > >
> > > Signed-off-by: Wolfram Sang <w.sang@pengutronix.de>
> > > Cc: Jesse Barnes <jbarnes@virtuousgeek.org>
> > > Cc: Chris Wilson <chris@chris-wilson.co.uk>
> > > ---
> >
> > Looks good, thanks Wolfram.
> >
> > Reviewed-by: Jesse Barnes <jbarnes@virtuousgeek.org>
>
> Just wondering: I don't see it in linux-next or the i915-branches I am aware
> of. Forgotten or intentional?
Bounce it over to Keith with the reviewed-by and he'll pick it up.
--
Jesse Barnes, Intel Open Source Technology Center
prev parent reply other threads:[~2011-07-02 18:00 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-15 22:24 [PATCH] drm/i915: add check for valid init_clock_gating-pointer Wolfram Sang
2011-06-15 22:30 ` Jesse Barnes
2011-06-16 13:28 ` Wolfram Sang
2011-06-16 15:15 ` Jesse Barnes
2011-06-16 15:47 ` Chris Wilson
2011-06-19 19:22 ` Wolfram Sang
2011-06-19 20:04 ` Chris Wilson
2011-06-20 16:10 ` [PATCH] drm/i915: gracefully bail out when init_clock_gating-pointer is not set Wolfram Sang
2011-06-20 16:43 ` Chris Wilson
2011-06-20 17:36 ` [PATCH V2] " Wolfram Sang
2011-06-20 17:38 ` Jesse Barnes
2011-07-02 15:55 ` Wolfram Sang
2011-07-02 18:00 ` Jesse Barnes [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110702110007.4393473e@jbarnes-desktop \
--to=jbarnes@virtuousgeek.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=w.sang@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox