From: Jesse Barnes <jbarnes@virtuousgeek.org>
To: Thomas Jarosch <thomas.jarosch@intra2net.com>
Cc: dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] Fix wrong initializer for "locked" variable
Date: Thu, 25 Aug 2011 09:22:30 -0700 [thread overview]
Message-ID: <20110825092230.57354893@jbarnes-desktop> (raw)
In-Reply-To: <201108251537.45999.thomas.jarosch@intra2net.com>
On Thu, 25 Aug 2011 15:37:45 +0200
Thomas Jarosch <thomas.jarosch@intra2net.com> wrote:
> Otherwise it just contains random memory.
>
> Issue detected by cppcheck.
>
> Signed-off-by: Thomas Jarosch <thomas.jarosch@intra2net.com>
> ---
> drivers/gpu/drm/i915/intel_display.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
> index ee1d701..f6da4e4 100644
> --- a/drivers/gpu/drm/i915/intel_display.c
> +++ b/drivers/gpu/drm/i915/intel_display.c
> @@ -878,7 +878,7 @@ static void assert_panel_unlocked(struct drm_i915_private *dev_priv,
> int pp_reg, lvds_reg;
> u32 val;
> enum pipe panel_pipe = PIPE_A;
> - bool locked = locked;
> + bool locked = true;
>
> if (HAS_PCH_SPLIT(dev_priv->dev)) {
> pp_reg = PCH_PP_CONTROL;
Hah yeah that's a good one, thanks for the fix.
Reviewed-by: Jesse Barnes <jbarnes@virtuousgeek.org>
--
Jesse Barnes, Intel Open Source Technology Center
prev parent reply other threads:[~2011-08-25 16:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-25 13:37 [PATCH] Fix wrong initializer for "locked" variable Thomas Jarosch
2011-08-25 16:22 ` Jesse Barnes [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110825092230.57354893@jbarnes-desktop \
--to=jbarnes@virtuousgeek.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=thomas.jarosch@intra2net.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).