dri-devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: j.glisse@gmail.com
Cc: thellstrom@vmware.com, Jerome Glisse <jglisse@redhat.com>,
	dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 4/8] drm/ttm: use ttm put pages function to properly restore cache attribute
Date: Thu, 3 Nov 2011 14:35:01 -0400	[thread overview]
Message-ID: <20111103183501.GA521@phenom.dumpdata.com> (raw)
In-Reply-To: <1320277075-19980-5-git-send-email-j.glisse@gmail.com>

On Wed, Nov 02, 2011 at 07:37:51PM -0400, j.glisse@gmail.com wrote:
> From: Jerome Glisse <jglisse@redhat.com>
> 
> On failure we need to make sure the page we free has wb cache
> attribute. Do this pas call the proper ttm page helper function.
> 
> Signed-off-by: Jerome Glisse <jglisse@redhat.com>

Reviewed-by...
> ---
>  drivers/gpu/drm/ttm/ttm_tt.c |    5 ++++-
>  1 files changed, 4 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/gpu/drm/ttm/ttm_tt.c b/drivers/gpu/drm/ttm/ttm_tt.c
> index 8b7a6d0..3fb4c6d 100644
> --- a/drivers/gpu/drm/ttm/ttm_tt.c
> +++ b/drivers/gpu/drm/ttm/ttm_tt.c
> @@ -89,7 +89,10 @@ static struct page *__ttm_tt_get_page(struct ttm_tt *ttm, int index)
>  	}
>  	return p;
>  out_err:
> -	put_page(p);
> +	INIT_LIST_HEAD(&h);
> +	list_add(&p->lru, &h);
> +	ttm_put_pages(&h, 1, ttm->page_flags,
> +		      ttm->caching_state, &ttm->dma_address[index]);
>  	return NULL;
>  }
>  
> -- 
> 1.7.1

  reply	other threads:[~2011-11-03 18:35 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-02 23:37 [RFC] ttm merge ttm_backend & ttm_t V2 j.glisse
2011-11-02 23:37 ` [PATCH 1/8] drm/ttm: remove userspace backed ttm object support j.glisse
2011-11-02 23:37 ` [PATCH 2/8] drm/ttm: remove split btw highmen and lowmem page j.glisse
2011-11-02 23:37 ` [PATCH 3/8] drm/ttm: remove unused backend flags field j.glisse
2011-11-02 23:37 ` [PATCH 4/8] drm/ttm: use ttm put pages function to properly restore cache attribute j.glisse
2011-11-03 18:35   ` Konrad Rzeszutek Wilk [this message]
2011-11-02 23:37 ` [PATCH 5/8] drm/ttm: convert page allocation to use page ptr array instead of list V2 j.glisse
2011-11-03 18:45   ` Konrad Rzeszutek Wilk
2011-11-02 23:37 ` [PATCH 6/8] drm/ttm: test for dma_address array allocation failure j.glisse
2011-11-03 18:45   ` Konrad Rzeszutek Wilk
2011-11-02 23:37 ` [PATCH 7/8] drm/ttm: merge ttm_backend and ttm_tt j.glisse
2011-11-02 23:37 ` [PATCH 8/8] drm/ttm: introduce callback for ttm_tt populate & unpopulate j.glisse

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111103183501.GA521@phenom.dumpdata.com \
    --to=konrad.wilk@oracle.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=j.glisse@gmail.com \
    --cc=jglisse@redhat.com \
    --cc=thellstrom@vmware.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox