dri-devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Simon Farnsworth <simon.farnsworth@onelan.co.uk>
To: dri-devel@lists.freedesktop.org
Cc: Alex Deucher <alexander.deucher@amd.com>,
	stable@kernel.org, Mario Kleiner <mario.kleiner@tuebingen.mpg.de>
Subject: Re: [PATCH 1/3] drm/radeon/kms: add some loop timeouts in pageflip code
Date: Tue, 29 Nov 2011 11:10:13 +0000	[thread overview]
Message-ID: <201111291110.13775.simon.farnsworth@onelan.co.uk> (raw)
In-Reply-To: <1322509768-20612-1-git-send-email-alexdeucher@gmail.com>

I've tested all three patches in this series, on an AMD E-350 platform.

1/3 is essential to prevent a complete system hang if the GPU needs
resetting during a page flip; the disaster case is this endless loop running
on core 0, and RCU on core 1 waiting for core 0 to idle.

The remaining two need matching patches to the DDX to be useful, and expose
bugs in Mesa as well.

Tested-by: Simon Farnsworth <simon.farnsworth@onelan.co.uk>

On Monday 28 November 2011, alexdeucher@gmail.com wrote:
> From: Alex Deucher <alexander.deucher@amd.com>
> 
> Avoid infinite loops waiting for surface updates if a GPU
> reset happens while waiting for a page flip.
> 
> See:
> https://bugs.freedesktop.org/show_bug.cgi?id=43191
> 
> Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
> Cc: stable@kernel.org
> Cc: Mario Kleiner <mario.kleiner@tuebingen.mpg.de>
> ---
>  drivers/gpu/drm/radeon/evergreen.c |    7 ++++++-
>  drivers/gpu/drm/radeon/r100.c      |    7 ++++++-
>  drivers/gpu/drm/radeon/rs600.c     |    7 ++++++-
>  drivers/gpu/drm/radeon/rv770.c     |    7 ++++++-
>  4 files changed, 24 insertions(+), 4 deletions(-)
> 

-- 
Simon Farnsworth
Software Engineer
ONELAN Limited
http://www.onelan.com/

      parent reply	other threads:[~2011-11-29 12:10 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-28 19:49 [PATCH 1/3] drm/radeon/kms: add some loop timeouts in pageflip code alexdeucher
2011-11-28 19:49 ` [PATCH 2/3] drm/radeon/kms: fix scanout of 2D tiled buffers on EG/CM alexdeucher
2011-11-28 19:49 ` [PATCH 3/3] drm/radeon/kms: fix 2D tiling CS support " alexdeucher
2011-11-28 21:12 ` [PATCH 1/3] drm/radeon/kms: add some loop timeouts in pageflip code Mario Kleiner
2011-11-29 11:10 ` Simon Farnsworth [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201111291110.13775.simon.farnsworth@onelan.co.uk \
    --to=simon.farnsworth@onelan.co.uk \
    --cc=alexander.deucher@amd.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=mario.kleiner@tuebingen.mpg.de \
    --cc=stable@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox