From: Dan Carpenter <dan.carpenter@oracle.com>
To: daniel.vetter@ffwll.ch
Cc: dri-devel@lists.freedesktop.org
Subject: re: drm/i915: switch ring->id to be a real id
Date: Thu, 16 Feb 2012 09:40:04 +0300 [thread overview]
Message-ID: <20120216064004.GA23794@elgon.mountain> (raw)
Hello Daniel Vetter,
The patch 96154f2faba5: "drm/i915: switch ring->id to be a real id"
from Dec 14, 2011, leads to the following warning:
drivers/gpu/drm/i915/i915_debugfs.c:688 print_error_buffers()
error: err->ring is never equal to -1 (wrong type 0 - 15).
@@ -724,6 +724,7 @@ static void print_error_buffers(struct seq_file *m,
tiling_flag(err->tiling),
dirty_flag(err->dirty),
purgeable_flag(err->purgeable),
+ err->ring != -1 ? " " : "",
^^^^^^^^^^^^^^^
->ring is an unsigned bitfield so it's never equal to -1.
ring_str(err->ring),
cache_level_str(err->cache_level));
regards,
dan carpenter
next reply other threads:[~2012-02-16 6:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-16 6:40 Dan Carpenter [this message]
2012-02-16 10:03 ` [PATCH] drm/i915: error_buffer->ring should be signed Daniel Vetter
2012-02-16 10:18 ` Paul Menzel
2012-02-16 11:16 ` Dan Carpenter
2012-02-27 17:15 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120216064004.GA23794@elgon.mountain \
--to=dan.carpenter@oracle.com \
--cc=daniel.vetter@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox