dri-devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Kristian Hoegsberg <hoegsberg@gmail.com>
To: David Herrmann <dh.herrmann@googlemail.com>
Cc: Dave Airlie <airlied@redhat.com>, Chia-I Wu <olv@lunarg.com>,
	dri-devel@lists.freedesktop.org, mesa-dev@lists.freedesktop.org
Subject: Re: [PATCH RESEND] egl-fbdev: Fix compile-error by including errno.h
Date: Mon, 30 Apr 2012 13:27:26 -0400	[thread overview]
Message-ID: <20120430172726.GC8167@minato.local> (raw)
In-Reply-To: <1335693196-10788-1-git-send-email-dh.herrmann@googlemail.com>

On Sun, Apr 29, 2012 at 11:53:16AM +0200, David Herrmann wrote:
> We use errno and EINVAL so include errno.h.
> 
> This patch introduced this bug:
> http://cgit.freedesktop.org/mesa/mesa/commit/src/gallium/state_trackers/egl/fbdev/native_fbdev.c?id=b60120608f6ddf4098bc324363197c979ee04cb7
> 
> Signed-off-by: David Herrmann <dh.herrmann@googlemail.com>
> Cc: Chia-I Wu <olv@lunarg.com>
> Cc: Dave Airlie <airlied@redhat.com>
> Cc: Adam Jackson <ajax@redhat.com>
> Cc: Jesse Barnes <jbarnes@virtuousgeek.org>
> ---
> I've CC'ed everyone who reviewed/applied the patch that broke fbdev. Hopefully,
> someone can apply it this time.

Thanks, applied.
Kristian

>  src/gallium/state_trackers/egl/fbdev/native_fbdev.c |    1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/src/gallium/state_trackers/egl/fbdev/native_fbdev.c b/src/gallium/state_trackers/egl/fbdev/native_fbdev.c
> index b45ab5c..b17a8ce 100644
> --- a/src/gallium/state_trackers/egl/fbdev/native_fbdev.c
> +++ b/src/gallium/state_trackers/egl/fbdev/native_fbdev.c
> @@ -41,6 +41,7 @@
>   *  - no pixmap support
>   */
>  
> +#include <errno.h>
>  #include <sys/ioctl.h>
>  #include <sys/types.h>
>  #include <sys/stat.h>
> -- 
> 1.7.10
> 
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel

  reply	other threads:[~2012-04-30 17:27 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-29  9:53 [PATCH RESEND] egl-fbdev: Fix compile-error by including errno.h David Herrmann
2012-04-30 17:27 ` Kristian Hoegsberg [this message]
  -- strict thread matches above, loose matches on Subject: below --
2012-04-14 15:02 [PATCH] " David Herrmann
2012-04-22 20:05 ` [PATCH RESEND] " David Herrmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120430172726.GC8167@minato.local \
    --to=hoegsberg@gmail.com \
    --cc=airlied@redhat.com \
    --cc=dh.herrmann@googlemail.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=mesa-dev@lists.freedesktop.org \
    --cc=olv@lunarg.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox