* [PATCH RESEND] egl-fbdev: Fix compile-error by including errno.h
@ 2012-04-29 9:53 David Herrmann
2012-04-30 17:27 ` Kristian Hoegsberg
0 siblings, 1 reply; 3+ messages in thread
From: David Herrmann @ 2012-04-29 9:53 UTC (permalink / raw)
To: dri-devel; +Cc: Dave Airlie, mesa-dev, Chia-I Wu
We use errno and EINVAL so include errno.h.
This patch introduced this bug:
http://cgit.freedesktop.org/mesa/mesa/commit/src/gallium/state_trackers/egl/fbdev/native_fbdev.c?id=b60120608f6ddf4098bc324363197c979ee04cb7
Signed-off-by: David Herrmann <dh.herrmann@googlemail.com>
Cc: Chia-I Wu <olv@lunarg.com>
Cc: Dave Airlie <airlied@redhat.com>
Cc: Adam Jackson <ajax@redhat.com>
Cc: Jesse Barnes <jbarnes@virtuousgeek.org>
---
I've CC'ed everyone who reviewed/applied the patch that broke fbdev. Hopefully,
someone can apply it this time.
src/gallium/state_trackers/egl/fbdev/native_fbdev.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/gallium/state_trackers/egl/fbdev/native_fbdev.c b/src/gallium/state_trackers/egl/fbdev/native_fbdev.c
index b45ab5c..b17a8ce 100644
--- a/src/gallium/state_trackers/egl/fbdev/native_fbdev.c
+++ b/src/gallium/state_trackers/egl/fbdev/native_fbdev.c
@@ -41,6 +41,7 @@
* - no pixmap support
*/
+#include <errno.h>
#include <sys/ioctl.h>
#include <sys/types.h>
#include <sys/stat.h>
--
1.7.10
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH RESEND] egl-fbdev: Fix compile-error by including errno.h
2012-04-29 9:53 [PATCH RESEND] egl-fbdev: Fix compile-error by including errno.h David Herrmann
@ 2012-04-30 17:27 ` Kristian Hoegsberg
0 siblings, 0 replies; 3+ messages in thread
From: Kristian Hoegsberg @ 2012-04-30 17:27 UTC (permalink / raw)
To: David Herrmann; +Cc: Dave Airlie, Chia-I Wu, dri-devel, mesa-dev
On Sun, Apr 29, 2012 at 11:53:16AM +0200, David Herrmann wrote:
> We use errno and EINVAL so include errno.h.
>
> This patch introduced this bug:
> http://cgit.freedesktop.org/mesa/mesa/commit/src/gallium/state_trackers/egl/fbdev/native_fbdev.c?id=b60120608f6ddf4098bc324363197c979ee04cb7
>
> Signed-off-by: David Herrmann <dh.herrmann@googlemail.com>
> Cc: Chia-I Wu <olv@lunarg.com>
> Cc: Dave Airlie <airlied@redhat.com>
> Cc: Adam Jackson <ajax@redhat.com>
> Cc: Jesse Barnes <jbarnes@virtuousgeek.org>
> ---
> I've CC'ed everyone who reviewed/applied the patch that broke fbdev. Hopefully,
> someone can apply it this time.
Thanks, applied.
Kristian
> src/gallium/state_trackers/egl/fbdev/native_fbdev.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/src/gallium/state_trackers/egl/fbdev/native_fbdev.c b/src/gallium/state_trackers/egl/fbdev/native_fbdev.c
> index b45ab5c..b17a8ce 100644
> --- a/src/gallium/state_trackers/egl/fbdev/native_fbdev.c
> +++ b/src/gallium/state_trackers/egl/fbdev/native_fbdev.c
> @@ -41,6 +41,7 @@
> * - no pixmap support
> */
>
> +#include <errno.h>
> #include <sys/ioctl.h>
> #include <sys/types.h>
> #include <sys/stat.h>
> --
> 1.7.10
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] egl-fbdev: Fix compile-error by including errno.h
@ 2012-04-14 15:02 David Herrmann
2012-04-22 20:05 ` [PATCH RESEND] " David Herrmann
0 siblings, 1 reply; 3+ messages in thread
From: David Herrmann @ 2012-04-14 15:02 UTC (permalink / raw)
To: dri-devel; +Cc: Chia-I Wu
We use errno and EINVAL so include errno.h.
Signed-off-by: David Herrmann <dh.herrmann@googlemail.com>
---
src/gallium/state_trackers/egl/fbdev/native_fbdev.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/gallium/state_trackers/egl/fbdev/native_fbdev.c b/src/gallium/state_trackers/egl/fbdev/native_fbdev.c
index b45ab5c..b17a8ce 100644
--- a/src/gallium/state_trackers/egl/fbdev/native_fbdev.c
+++ b/src/gallium/state_trackers/egl/fbdev/native_fbdev.c
@@ -41,6 +41,7 @@
* - no pixmap support
*/
+#include <errno.h>
#include <sys/ioctl.h>
#include <sys/types.h>
#include <sys/stat.h>
--
1.7.10
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH RESEND] egl-fbdev: Fix compile-error by including errno.h
2012-04-14 15:02 [PATCH] " David Herrmann
@ 2012-04-22 20:05 ` David Herrmann
0 siblings, 0 replies; 3+ messages in thread
From: David Herrmann @ 2012-04-22 20:05 UTC (permalink / raw)
To: mesa-dev; +Cc: David Fries, dri-devel, Dave Airlie, Chia-I Wu
Hi Dave
You applied the following patch which breaks fbdev-egl backend:
http://cgit.freedesktop.org/mesa/mesa/commit/src/gallium/state_trackers/egl/fbdev/native_fbdev.c?id=b60120608f6ddf4098bc324363197c979ee04cb7
It doesn't compile anymore. I appended the correct fix below. I also
CC'ed mesa-dev and the people who reviewed the original patch this
time as I have no idea who I need to send this to.
Thanks
David
**********************************************
egl-fbdev: Fix compile-error by including errno.h
We use errno and EINVAL so include errno.h.
Signed-off-by: David Herrmann <dh.herrmann@googlemail.com>
---
src/gallium/state_trackers/egl/fbdev/native_fbdev.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/gallium/state_trackers/egl/fbdev/native_fbdev.c
b/src/gallium/state_trackers/egl/fbdev/native_fbdev.c
index b45ab5c..b17a8ce 100644
--- a/src/gallium/state_trackers/egl/fbdev/native_fbdev.c
+++ b/src/gallium/state_trackers/egl/fbdev/native_fbdev.c
@@ -41,6 +41,7 @@
* - no pixmap support
*/
+#include <errno.h>
#include <sys/ioctl.h>
#include <sys/types.h>
#include <sys/stat.h>
--
1.7.10
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-04-30 17:27 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-04-29 9:53 [PATCH RESEND] egl-fbdev: Fix compile-error by including errno.h David Herrmann
2012-04-30 17:27 ` Kristian Hoegsberg
-- strict thread matches above, loose matches on Subject: below --
2012-04-14 15:02 [PATCH] " David Herrmann
2012-04-22 20:05 ` [PATCH RESEND] " David Herrmann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox