Re: [PATCH] drm/kms: driver for virtual cirrus under qemu

[Jonathan Nieder <jrnieder@gmail.com>]

Hi Dave,

Dave Airlie wrote:

> --- /dev/null
> +++ b/drivers/gpu/drm/cirrus/Kconfig
> @@ -0,0 +1,7 @@
> +config DRM_CIRRUS
> +	tristate "Cirrus driver"
> +	depends on DRM && PCI
> +	select FB_CFB_FILLRECT
> +	select FB_CFB_COPYAREA
> +	select FB_CFB_IMAGEBLIT
> +	select DRM_KMS_HELPER

	  MODPOST 139 modules
	ERROR: "sys_copyarea" [drivers/gpu/drm/cirrus/cirrus.ko] undefined!
	ERROR: "sys_fillrect" [drivers/gpu/drm/cirrus/cirrus.ko] undefined!
	ERROR: "sys_imageblit" [drivers/gpu/drm/cirrus/cirrus.ko] undefined!
	make[1]: *** [__modpost] Error 1

Would it be too late to squash the following in?

Thanks,
Jonathan

diff --git i/drivers/gpu/drm/cirrus/Kconfig w/drivers/gpu/drm/cirrus/Kconfig
index 0303257ca136..ed6aa703a6d4 100644
--- i/drivers/gpu/drm/cirrus/Kconfig
+++ w/drivers/gpu/drm/cirrus/Kconfig
@@ -1,9 +1,9 @@
 config DRM_CIRRUS_QEMU
 	tristate "Cirrus driver for QEMU emulated device"
 	depends on DRM && PCI && EXPERIMENTAL
-	select FB_CFB_FILLRECT
-	select FB_CFB_COPYAREA
-	select FB_CFB_IMAGEBLIT
+	select FB_SYS_FILLRECT
+	select FB_SYS_COPYAREA
+	select FB_SYS_IMAGEBLIT
 	select DRM_KMS_HELPER
 	help
 	 This is a KMS driver for emulated cirrus device in qemu.