* [PATCH -next] drm: tegra: fix missing unlock on error
@ 2012-12-02 10:25 Wei Yongjun
[not found] ` <CAPgLHd-UekVrvc8gwNUFaoNtcFcZCNC559GW1wfrmUVHidsiOQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
0 siblings, 1 reply; 2+ messages in thread
From: Wei Yongjun @ 2012-12-02 10:25 UTC (permalink / raw)
To: airlied-cv59FeDIM0c, grant.likely-s3s/WqlpOiPyB63q8FvJNQ,
rob.herring-bsGFqQB8/DxBDgjK7y7TUQ,
thierry.reding-RM9K5IK7kjKj5M59NBduVrNAH6kLmebB
Cc: linux-tegra-u79uwXL29TY76Z2rM5mHXA,
yongjun_wei-zrsr2BFq86L20UzCJQGyNP8+0UxHXcjY,
devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ,
dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
linux-kernel-u79uwXL29TY76Z2rM5mHXA
From: Wei Yongjun <yongjun_wei-zrsr2BFq86L20UzCJQGyNP8+0UxHXcjY@public.gmane.org>
Add the missing unlock before return from function host1x_drm_init()
and host1x_drm_exit() in the error handling case.
Signed-off-by: Wei Yongjun <yongjun_wei-zrsr2BFq86L20UzCJQGyNP8+0UxHXcjY@public.gmane.org>
---
drivers/gpu/drm/tegra/host1x.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/gpu/drm/tegra/host1x.c b/drivers/gpu/drm/tegra/host1x.c
index bdb97a5..39629e6 100644
--- a/drivers/gpu/drm/tegra/host1x.c
+++ b/drivers/gpu/drm/tegra/host1x.c
@@ -176,6 +176,7 @@ int host1x_drm_init(struct host1x *host1x, struct drm_device *drm)
dev_err(host1x->dev,
"DRM setup failed for %s: %d\n",
dev_name(client->dev), err);
+ mutex_unlock(&host1x->clients_lock);
return err;
}
}
@@ -203,6 +204,7 @@ int host1x_drm_exit(struct host1x *host1x)
dev_err(host1x->dev,
"DRM cleanup failed for %s: %d\n",
dev_name(client->dev), err);
+ mutex_unlock(&host1x->clients_lock);
return err;
}
}
^ permalink raw reply related [flat|nested] 2+ messages in thread[parent not found: <CAPgLHd-UekVrvc8gwNUFaoNtcFcZCNC559GW1wfrmUVHidsiOQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>]
* Re: [PATCH -next] drm: tegra: fix missing unlock on error [not found] ` <CAPgLHd-UekVrvc8gwNUFaoNtcFcZCNC559GW1wfrmUVHidsiOQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> @ 2012-12-02 21:12 ` Thierry Reding 0 siblings, 0 replies; 2+ messages in thread From: Thierry Reding @ 2012-12-02 21:12 UTC (permalink / raw) To: Wei Yongjun Cc: airlied-cv59FeDIM0c, grant.likely-s3s/WqlpOiPyB63q8FvJNQ, rob.herring-bsGFqQB8/DxBDgjK7y7TUQ, yongjun_wei-zrsr2BFq86L20UzCJQGyNP8+0UxHXcjY, dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW, devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ, linux-tegra-u79uwXL29TY76Z2rM5mHXA, linux-kernel-u79uwXL29TY76Z2rM5mHXA [-- Attachment #1: Type: text/plain, Size: 1291 bytes --] On Sun, Dec 02, 2012 at 05:25:05AM -0500, Wei Yongjun wrote: > From: Wei Yongjun <yongjun_wei-zrsr2BFq86L20UzCJQGyNP8+0UxHXcjY@public.gmane.org> > > Add the missing unlock before return from function host1x_drm_init() > and host1x_drm_exit() in the error handling case. > > Signed-off-by: Wei Yongjun <yongjun_wei-zrsr2BFq86L20UzCJQGyNP8+0UxHXcjY@public.gmane.org> > --- > drivers/gpu/drm/tegra/host1x.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/gpu/drm/tegra/host1x.c b/drivers/gpu/drm/tegra/host1x.c > index bdb97a5..39629e6 100644 > --- a/drivers/gpu/drm/tegra/host1x.c > +++ b/drivers/gpu/drm/tegra/host1x.c > @@ -176,6 +176,7 @@ int host1x_drm_init(struct host1x *host1x, struct drm_device *drm) > dev_err(host1x->dev, > "DRM setup failed for %s: %d\n", > dev_name(client->dev), err); > + mutex_unlock(&host1x->clients_lock); > return err; > } > } > @@ -203,6 +204,7 @@ int host1x_drm_exit(struct host1x *host1x) > dev_err(host1x->dev, > "DRM cleanup failed for %s: %d\n", > dev_name(client->dev), err); > + mutex_unlock(&host1x->clients_lock); > return err; > } > } Acked-by: Thierry Reding <thierry.reding-RM9K5IK7kjKj5M59NBduVrNAH6kLmebB@public.gmane.org> [-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --] ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-12-02 21:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-12-02 10:25 [PATCH -next] drm: tegra: fix missing unlock on error Wei Yongjun
[not found] ` <CAPgLHd-UekVrvc8gwNUFaoNtcFcZCNC559GW1wfrmUVHidsiOQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-12-02 21:12 ` Thierry Reding
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox