* Re: [PATCH] drivers: nouveau: Bool tests don't need comparison
[not found] ` <20121213081657.GV6568@mwanda>
@ 2012-12-13 20:45 ` Laurent Navet
0 siblings, 0 replies; only message in thread
From: Laurent Navet @ 2012-12-13 20:45 UTC (permalink / raw)
To: Dan Carpenter; +Cc: bskeggs, linux-kernel, dri-devel, airlied, kernel-janitors
Bool initializations should use true and false. Bool tests don't need
comparisons. Based on contributions from Joe Perches, Rusty Russell
and Bruce W Allan.
The semantic patch that makes this output is available
in scripts/coccinelle/misc/boolinit.cocci.
More information about semantic patching is available at
http://coccinelle.lip6.fr/
Signed-off-by: Laurent Navet <laurent.navet@gmail.com>
---
drivers/gpu/drm/nouveau/core/subdev/timer/base.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/nouveau/core/subdev/timer/base.c
b/drivers/gpu/drm/nouveau/core/subdev/timer/base.c
index 5d417cc..de6d6b7 100644
--- a/drivers/gpu/drm/nouveau/core/subdev/timer/base.c
+++ b/drivers/gpu/drm/nouveau/core/subdev/timer/base.c
@@ -72,7 +72,7 @@ nouveau_timer_wait_cb(void *obj, u64 nsec, bool
(*func)(void *), void *data)
time0 = ptimer->read(ptimer);
do {
- if (func(data) == true)
+ if (func(data))
return true;
} while (ptimer->read(ptimer) - time0 < nsec);
--
1.7.10.4
^ permalink raw reply related [flat|nested] only message in thread