stable backport request

stable backport request

[Daniel Vetter]

Dear stable team

Please backport the following patch to all stable kernels:

4283908ef7f11a72c3b80dd4cf026f1a86429f82 drm/i915: Implement
WaDisableHiZPlanesWhenMSAAEnabled
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=50545
Tested-by: Wen-chien Jesse Sung <jesse@cola.voip.idv.tw>

Thanks, Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch

Re: stable backport request

[Greg KH]

On Thu, Jan 24, 2013 at 10:58:25AM +0100, Daniel Vetter wrote:
> Dear stable team
> 
> Please backport the following patch to all stable kernels:
> 
> 4283908ef7f11a72c3b80dd4cf026f1a86429f82 drm/i915: Implement
> WaDisableHiZPlanesWhenMSAAEnabled
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=50545
> Tested-by: Wen-chien Jesse Sung <jesse@cola.voip.idv.tw>

This only applies to 3.7-stable, it fails to apply to 3.4-stable and
3.0-stable, sorry.  If you want it there, can someone please provide a
backported versioN?

thanks,

greg k-h

Re: stable backport request

[Abdallah Chatila]

On Thu, Jan 24, 2013 at 10:16:35AM -0800, Greg KH wrote:
> On Thu, Jan 24, 2013 at 10:58:25AM +0100, Daniel Vetter wrote:
> > Dear stable team
> > 
> > Please backport the following patch to all stable kernels:
> > 
> > 4283908ef7f11a72c3b80dd4cf026f1a86429f82 drm/i915: Implement
> > WaDisableHiZPlanesWhenMSAAEnabled
> > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=50545
> > Tested-by: Wen-chien Jesse Sung <jesse@cola.voip.idv.tw>
> 
> This only applies to 3.7-stable, it fails to apply to 3.4-stable and
> 3.0-stable, sorry.  If you want it there, can someone please provide a
> backported versioN?

This is a backport to 3.4-stable, please review

drm/i915: Implement WaDisableHiZPlanesWhenMSAAEnabled

commit 4283908ef7f11a72c3b80dd4cf026f1a86429f82 upstream.

Quoting from Bspec, 3D_CHICKEN1, bit 10

This bit needs to be set always to "1", Project: DevSNB

Reviewed-by: Rodrigo Vivi <rodrigo.vivi@gmail.com>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Signed-off-by: Abdallah Chatila <abdallah.chatila@ericsson.com>
---
 drivers/gpu/drm/i915/i915_reg.h      |    3 +++
 drivers/gpu/drm/i915/intel_display.c |    4 ++++
 2 files changed, 7 insertions(+)

diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h
index 27a296a..dde62bf 100644
--- a/drivers/gpu/drm/i915/i915_reg.h
+++ b/drivers/gpu/drm/i915/i915_reg.h
@@ -27,6 +27,8 @@
 
 #define _PIPE(pipe, a, b) ((a) + (pipe)*((b)-(a)))
 
+#define _MASKED_BIT_ENABLE(a) (((a) << 16) | (a))
+
 /*
  * The Bridge device's PCI config space has information about the
  * fb aperture size and the amount of pre-reserved memory.
@@ -433,6 +435,7 @@
  * the enables for writing to the corresponding low bit.
  */
 #define _3D_CHICKEN	0x02084
+#define _3D_CHICKEN_HIZ_PLANE_DISABLE_MSAA_4X_SNB	(1 << 10)
 #define _3D_CHICKEN2	0x0208c
 /* Disables pipelining of read flushes past the SF-WIZ interface.
  * Required on all Ironlake steppings according to the B-Spec, but the
diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
index 8e95c94..3c9b9c5 100644
--- a/drivers/gpu/drm/i915/intel_display.c
+++ b/drivers/gpu/drm/i915/intel_display.c
@@ -8592,6 +8592,10 @@ static void gen6_init_clock_gating(struct drm_device *dev)
 		   I915_READ(ILK_DISPLAY_CHICKEN2) |
 		   ILK_ELPIN_409_SELECT);
 
+	/* WaDisableHiZPlanesWhenMSAAEnabled */
+	I915_WRITE(_3D_CHICKEN,
+		   _MASKED_BIT_ENABLE(_3D_CHICKEN_HIZ_PLANE_DISABLE_MSAA_4X_SNB));
+
 	I915_WRITE(WM3_LP_ILK, 0);
 	I915_WRITE(WM2_LP_ILK, 0);
 	I915_WRITE(WM1_LP_ILK, 0);
-- 
1.7.10.4

Re: stable backport request

[Greg KH]

On Thu, Jan 24, 2013 at 01:59:58PM -0500, Abdallah Chatila wrote:
> On Thu, Jan 24, 2013 at 10:16:35AM -0800, Greg KH wrote:
> > On Thu, Jan 24, 2013 at 10:58:25AM +0100, Daniel Vetter wrote:
> > > Dear stable team
> > > 
> > > Please backport the following patch to all stable kernels:
> > > 
> > > 4283908ef7f11a72c3b80dd4cf026f1a86429f82 drm/i915: Implement
> > > WaDisableHiZPlanesWhenMSAAEnabled
> > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=50545
> > > Tested-by: Wen-chien Jesse Sung <jesse@cola.voip.idv.tw>
> > 
> > This only applies to 3.7-stable, it fails to apply to 3.4-stable and
> > 3.0-stable, sorry.  If you want it there, can someone please provide a
> > backported versioN?
> 
> This is a backport to 3.4-stable, please review

Applied, thanks.

greg k-h