From: Daniel Vetter <daniel@ffwll.ch>
To: Dylan Semler <dylan.semler@gmail.com>
Cc: dri-devel@lists.freedesktop.org
Subject: Re: [PATCH v3 0/2] Enhance EDID quirks to allow forcing a mode
Date: Sat, 23 Mar 2013 13:56:31 +0100 [thread overview]
Message-ID: <20130323125631.GG9021@phenom.ffwll.local> (raw)
In-Reply-To: <1363993687-6935-1-git-send-email-dylan.semler@gmail.com>
On Fri, Mar 22, 2013 at 07:08:05PM -0400, Dylan Semler wrote:
> Changes in this version
> * Uses drm_cvt_mode() instead of drm_gtf_mode() to build modeline
> * Adds bool to specify reduced blanking to edid_quirk_force_mode
> * Removes preferred bit from all other modes
>
> There is at least one monitor that doesn't report its native resolution
> in its EDID block. This enhancement extends the EDID quirk logic to
> make monitors like this "just work".
>
> The first patch in this series sets up a new quirk list where monitors'
> correct width, height, refresh rate, and reduced blanking parameters are
> specified. When a matching monitor is attached the full mode is
> calculated with drm_cvt_mode() and added to the connector. The
> DRM_MODE_TYPE_PREFERRED bit is set on the new mode and unset from all
> other modes.
>
> The first patch also defines a new quirk bit: EDID_QUIRK_FORCE_MODE.
> This bit needs to be set for the new quirk list discribed above to be
> checked.
>
> The second patch adds the offending monitor to the quirk lists.
>
> Dylan Semler (2):
> drm: Enhance EDID quirks to explicitly set a mode
> drm: Add EDID force quirk for MMT Monitor2Go HD+
Ah, missed this resend of your patches. Looks good to me, but I guess Dave
want's to have Ajax's ack, too. Anyway for the series:
Acked-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Cheers, Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
prev parent reply other threads:[~2013-03-23 12:53 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-22 23:08 [PATCH v3 0/2] Enhance EDID quirks to allow forcing a mode Dylan Semler
2013-03-22 23:08 ` [PATCH v3 1/2] drm: Enhance EDID quirks to explicitly set " Dylan Semler
2013-03-25 13:41 ` Jani Nikula
2013-03-25 17:01 ` Dylan Semler
2013-03-25 17:29 ` Jani Nikula
2013-03-22 23:08 ` [PATCH v3 2/2] drm: Add EDID force quirk for MMT Monitor2Go HD+ Dylan Semler
2013-03-23 12:56 ` Daniel Vetter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130323125631.GG9021@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=dylan.semler@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox