From: Daniel Vetter <daniel@ffwll.ch>
To: "Ville Syrjälä" <ville.syrjala@linux.intel.com>,
"Dave Airlie" <airlied@gmail.com>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>,
Ray Strode <rstrode@redhat.com>,
DRI Development <dri-devel@lists.freedesktop.org>
Subject: Re: [PATCH] drm: don't unlock in the addfb error paths
Date: Thu, 11 Apr 2013 16:09:06 +0200 [thread overview]
Message-ID: <20130411140906.GM27612@phenom.ffwll.local> (raw)
In-Reply-To: <20130328102255.GG4469@intel.com>
On Thu, Mar 28, 2013 at 12:22:55PM +0200, Ville Syrjälä wrote:
> On Wed, Mar 27, 2013 at 09:45:35PM +0100, Daniel Vetter wrote:
> > We don't grab the modeset locks any more since
> >
> > commit 468174f748603497e73dba9b5c6d1d9f71121486
> > Author: Daniel Vetter <daniel.vetter@ffwll.ch>
> > Date: Tue Dec 11 00:09:12 2012 +0100
> >
> > drm: push modeset_lock_all into ->fb_create driver callbacks
> >
> > Reported-by: Ray Strode <rstrode@redhat.com>
> > Cc: Ray Strode <rstrode@redhat.com>
> > Cc: Dave Airlie <airlied@gmail.com>
> > Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
>
> Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Dave?
>
> > ---
> > drivers/gpu/drm/drm_crtc.c | 2 --
> > 1 file changed, 2 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/drm_crtc.c b/drivers/gpu/drm/drm_crtc.c
> > index 792c3e3..dd64a06 100644
> > --- a/drivers/gpu/drm/drm_crtc.c
> > +++ b/drivers/gpu/drm/drm_crtc.c
> > @@ -2326,7 +2326,6 @@ int drm_mode_addfb(struct drm_device *dev,
> > fb = dev->mode_config.funcs->fb_create(dev, file_priv, &r);
> > if (IS_ERR(fb)) {
> > DRM_DEBUG_KMS("could not create framebuffer\n");
> > - drm_modeset_unlock_all(dev);
> > return PTR_ERR(fb);
> > }
> >
> > @@ -2506,7 +2505,6 @@ int drm_mode_addfb2(struct drm_device *dev,
> > fb = dev->mode_config.funcs->fb_create(dev, file_priv, r);
> > if (IS_ERR(fb)) {
> > DRM_DEBUG_KMS("could not create framebuffer\n");
> > - drm_modeset_unlock_all(dev);
> > return PTR_ERR(fb);
> > }
> >
> > --
> > 1.7.10.4
> >
> > _______________________________________________
> > dri-devel mailing list
> > dri-devel@lists.freedesktop.org
> > http://lists.freedesktop.org/mailman/listinfo/dri-devel
>
> --
> Ville Syrjälä
> Intel OTC
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
prev parent reply other threads:[~2013-04-11 14:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-27 20:45 [PATCH] drm: don't unlock in the addfb error paths Daniel Vetter
2013-03-28 10:22 ` Ville Syrjälä
2013-04-11 14:09 ` Daniel Vetter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130411140906.GM27612@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=airlied@gmail.com \
--cc=daniel.vetter@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=rstrode@redhat.com \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox