From: Daniel Vetter <daniel@ffwll.ch>
To: Imre Deak <imre.deak@intel.com>, Dave Airlie <airlied@gmail.com>
Cc: dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm/prime: warn for non-empty handle lookup list during drm file release
Date: Wed, 24 Apr 2013 19:07:14 +0200 [thread overview]
Message-ID: <20130424170714.GY6169@phenom.ffwll.local> (raw)
In-Reply-To: <1366819497-8358-1-git-send-email-imre.deak@intel.com>
On Wed, Apr 24, 2013 at 07:04:57PM +0300, Imre Deak wrote:
> drm_gem_release should release all handles connected to the drm file and
> so should also release the prime lookup entries of these handles. So
> just WARN if this isn't the case.
>
> Signed-off-by: Imre Deak <imre.deak@intel.com>
Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> ---
>
> drivers/gpu/drm/drm_prime.c | 7 ++-----
> 1 file changed, 2 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/drm_prime.c b/drivers/gpu/drm/drm_prime.c
> index 71c7315..dcde352 100644
> --- a/drivers/gpu/drm/drm_prime.c
> +++ b/drivers/gpu/drm/drm_prime.c
> @@ -488,11 +488,8 @@ EXPORT_SYMBOL(drm_prime_init_file_private);
>
> void drm_prime_destroy_file_private(struct drm_prime_file_private *prime_fpriv)
> {
> - struct drm_prime_member *member, *safe;
> - list_for_each_entry_safe(member, safe, &prime_fpriv->head, entry) {
> - list_del(&member->entry);
> - kfree(member);
> - }
> + /* by now drm_gem_release should've made sure the list is empty */
> + WARN_ON(!list_empty(&prime_fpriv->head));
> }
> EXPORT_SYMBOL(drm_prime_destroy_file_private);
>
> --
> 1.7.10.4
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
prev parent reply other threads:[~2013-04-24 17:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-24 16:04 [PATCH] drm/prime: warn for non-empty handle lookup list during drm file release Imre Deak
2013-04-24 17:07 ` Daniel Vetter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130424170714.GY6169@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=airlied@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=imre.deak@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox