* [PATCH] radeon: si_dpm.c: avoid a signed 64-bit divide
@ 2013-08-02 17:12 Kyle McMartin
2013-08-02 17:14 ` Deucher, Alexander
0 siblings, 1 reply; 3+ messages in thread
From: Kyle McMartin @ 2013-08-02 17:12 UTC (permalink / raw)
To: jglisse; +Cc: alexander.deucher, airlied, dri-devel, jwboyer
Hit a compile failure here referencing divdi3 on i686.
Signed-off-by: Kyle McMartin <kyle@redhat.com>
--- a/drivers/gpu/drm/radeon/si_dpm.c
+++ b/drivers/gpu/drm/radeon/si_dpm.c
@@ -1767,7 +1767,7 @@ static void si_calculate_leakage_for_v_and_t_formula(const struct ni_leakage_coe
s64 temperature, t_slope, t_intercept, av, bv, t_ref;
s64 tmp;
- i_leakage = drm_int2fixp(ileakage) / 100;
+ i_leakage = div64_s64(drm_int2fixp(ileakage), 100);
vddc = div64_s64(drm_int2fixp(v), 1000);
temperature = div64_s64(drm_int2fixp(t), 1000);
^ permalink raw reply [flat|nested] 3+ messages in thread
* RE: [PATCH] radeon: si_dpm.c: avoid a signed 64-bit divide
2013-08-02 17:12 [PATCH] radeon: si_dpm.c: avoid a signed 64-bit divide Kyle McMartin
@ 2013-08-02 17:14 ` Deucher, Alexander
2013-08-02 17:16 ` Kyle McMartin
0 siblings, 1 reply; 3+ messages in thread
From: Deucher, Alexander @ 2013-08-02 17:14 UTC (permalink / raw)
To: Kyle McMartin, jglisse@redhat.com
Cc: airlied@redhat.com, dri-devel@lists.freedesktop.org,
jwboyer@redhat.com
The fix is already queued in my tree:
http://lists.freedesktop.org/archives/dri-devel/2013-August/042668.html
> -----Original Message-----
> From: Kyle McMartin [mailto:kmcmarti@redhat.com]
> Sent: Friday, August 02, 2013 1:13 PM
> To: jglisse@redhat.com
> Cc: Deucher, Alexander; airlied@redhat.com; dri-
> devel@lists.freedesktop.org; jwboyer@redhat.com
> Subject: [PATCH] radeon: si_dpm.c: avoid a signed 64-bit divide
>
> Hit a compile failure here referencing divdi3 on i686.
>
> Signed-off-by: Kyle McMartin <kyle@redhat.com>
>
> --- a/drivers/gpu/drm/radeon/si_dpm.c
> +++ b/drivers/gpu/drm/radeon/si_dpm.c
> @@ -1767,7 +1767,7 @@ static void
> si_calculate_leakage_for_v_and_t_formula(const struct ni_leakage_coe
> s64 temperature, t_slope, t_intercept, av, bv, t_ref;
> s64 tmp;
>
> - i_leakage = drm_int2fixp(ileakage) / 100;
> + i_leakage = div64_s64(drm_int2fixp(ileakage), 100);
> vddc = div64_s64(drm_int2fixp(v), 1000);
> temperature = div64_s64(drm_int2fixp(t), 1000);
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] radeon: si_dpm.c: avoid a signed 64-bit divide
2013-08-02 17:14 ` Deucher, Alexander
@ 2013-08-02 17:16 ` Kyle McMartin
0 siblings, 0 replies; 3+ messages in thread
From: Kyle McMartin @ 2013-08-02 17:16 UTC (permalink / raw)
To: Deucher, Alexander
Cc: airlied@redhat.com, jglisse@redhat.com,
dri-devel@lists.freedesktop.org, jwboyer@redhat.com
On Fri, Aug 02, 2013 at 05:14:52PM +0000, Deucher, Alexander wrote:
> The fix is already queued in my tree:
> http://lists.freedesktop.org/archives/dri-devel/2013-August/042668.html
>
thanks. ;-)
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-08-02 17:16 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-08-02 17:12 [PATCH] radeon: si_dpm.c: avoid a signed 64-bit divide Kyle McMartin
2013-08-02 17:14 ` Deucher, Alexander
2013-08-02 17:16 ` Kyle McMartin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox