dri-devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: alexander.deucher@amd.com
Cc: dri-devel@lists.freedesktop.org
Subject: re: drm/radeon: add audio support for DCE6/8 GPUs (v12)
Date: Tue, 3 Sep 2013 12:24:00 +0300	[thread overview]
Message-ID: <20130903092400.GA4758@elgon.mountain> (raw)

Hello Alex Deucher,

This is a semi-automatic email about new static checker warnings.

The patch b530602fd462: "drm/radeon: add audio support for DCE6/8 
GPUs (v12)" from Jul 31, 2013, leads to the following Smatch 
complaint:

drivers/gpu/drm/radeon/dce6_afmt.c:91 dce6_afmt_select_pin()
	 warn: variable dereferenced before check 'dig->afmt->pin' (see line 89)

drivers/gpu/drm/radeon/dce6_afmt.c
    88		u32 offset = dig->afmt->offset;
    89		u32 id = dig->afmt->pin->id;
                         ^^^^^^^^^^^^^^^^^^
Patch adds dereference.

    90	
    91		if (!dig->afmt->pin)
                    ^^^^^^^^^^^^^^^
Patch adds check.

    92			return;
    93	

regards,
dan carpenter

                 reply	other threads:[~2013-09-03  9:24 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130903092400.GA4758@elgon.mountain \
    --to=dan.carpenter@oracle.com \
    --cc=alexander.deucher@amd.com \
    --cc=dri-devel@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox