From: David Miller <davem@davemloft.net>
To: mroos@linux.ee
Cc: alexdeucher@gmail.com, airlied@gmail.com,
sparclinux@vger.kernel.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] only try to find radeon IGP ROM on X86
Date: Thu, 10 Oct 2013 13:02:01 -0400 (EDT) [thread overview]
Message-ID: <20131010.130201.87409851759938579.davem@davemloft.net> (raw)
In-Reply-To: <alpine.SOC.1.00.1310101824001.25198@math.ut.ee>
From: Meelis Roos <mroos@linux.ee>
Date: Thu, 10 Oct 2013 18:26:39 +0300 (EEST)
>> On Thu, Oct 10, 2013 at 7:51 AM, Meelis Roos <mroos@linux.ee> wrote:
>> > To prevent hangs on non-PC machines (e.g. sparc64), probe Radeon ROM
>> > from ATI IGP only on X86. Fixes hang in this place and allows PCI radeon
>> > detection to move on to next problem.
>>
>> NACK. All this function does it attempt to read the rom from the
>> framebuffer PCI BAR. If you get hangs reading the BAR, then you have
>> larger problems on your platform. Also, there are non-x86 platforms
>> that IGP chips which this may break.
>
> OK. But the code seems to just dereference addresses returned from
> ioremap, but to the best of my knowledge, these are not universally
> (like on each arch) safe to read without readb/readw/readl. Should I
> convert these to readb for test?
That's correct, ioremap() returned pointers must not be directly
dereferenced, and must be accessed through the appropriate accessors.
next prev parent reply other threads:[~2013-10-10 17:02 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-06 14:41 PCI Radeon RV100 detection hang on sparc64 Meelis Roos
2012-09-06 16:51 ` Adam Jackson
2012-09-06 18:15 ` David Miller
2012-09-06 16:55 ` Michel Dänzer
2012-09-06 18:18 ` David Miller
2012-09-07 7:18 ` Dave Airlie
2012-09-19 7:51 ` mroos
2013-09-23 13:48 ` mroos
2013-09-23 19:06 ` Kjetil Oftedal
2013-09-23 20:36 ` David Miller
2013-09-23 21:14 ` mroos
2013-09-23 21:33 ` David Miller
2013-09-24 11:06 ` Meelis Roos
2013-09-25 23:26 ` Meelis Roos
2013-10-01 8:43 ` Meelis Roos
2014-04-04 20:52 ` David Miller
2014-08-13 6:30 ` David Miller
2014-08-19 11:17 ` Meelis Roos
2014-08-25 14:48 ` Meelis Roos
2014-08-26 2:46 ` Michel Dänzer
2014-08-26 7:07 ` Meelis Roos
2014-08-27 2:24 ` Michel Dänzer
2014-08-30 19:20 ` Kjetil Oftedal
2014-08-31 5:59 ` Meelis Roos
2013-09-23 21:18 ` Meelis Roos
2013-10-10 11:51 ` [PATCH] only try to find radeon IGP ROM on X86 Meelis Roos
2013-10-10 14:38 ` Alex Deucher
2013-10-10 15:26 ` Meelis Roos
2013-10-10 17:02 ` David Miller [this message]
2013-10-10 17:10 ` Alex Deucher
2012-09-06 18:08 ` PCI Radeon RV100 detection hang on sparc64 David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131010.130201.87409851759938579.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=airlied@gmail.com \
--cc=alexdeucher@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=mroos@linux.ee \
--cc=sparclinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox