dri-devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Meelis Roos <mroos@linux.ee>
To: David Miller <davem@davemloft.net>
Cc: oftedal@gmail.com, airlied@gmail.com, michel@daenzer.net,
	sparclinux@vger.kernel.org, dri-devel@lists.freedesktop.org
Subject: Re: PCI Radeon RV100 detection hang on sparc64
Date: Thu, 26 Sep 2013 02:26:09 +0300 (EEST)	[thread overview]
Message-ID: <alpine.SOC.1.00.1309251604070.17530@math.ut.ee> (raw)
In-Reply-To: <alpine.SOC.1.00.1309241404290.29702@math.ut.ee>


> > >> The pci_assign_resource() path must have some bug that causes the
> > >> resource values to be set incorrectly or similar.
> > >> 
> > >> Meelis, what is the value of pci_resource_start(pdev, PCI_ROM_RESOURCE)
> > >> before the pci_map_rom() call?
> > > 
> > > [drm] radeon_read_bios: pci_resource_start(ROM)=000001FF10020000
> > > 
> > > I am a little confused here. ROM addressis OK but after pci_map_rom it 
> > > results in address that corresponds to another device?
> > 
> > That's certainly a bug.
> > 
> > So after pci_map_rom() pci_resource_start(ROM)=000001FF00000000, right?
> 
> I double checked it - yes:
> 
> before pci_map_rom:
> [drm] radeon_read_bios: pci_resource_start(ROM)=000001FF10020000                                                                          
> 
> radeon 0000:02:02.0: BAR 6: assigned [mem 0x1ff00000000-0x1ff0001ffff]
> 
> after pci_map_rom:
> 
> [drm] radeon_read_bios, bios=000001ff00000000, pci_resource_start(ROM)=000001FF00000000, size=46592

This is first range in pci bus 0000:02 that is tried, and it matches:
pci_bus 0000:02: pci_bus_alloc_resource trying [mem 0x1ff00000000-0x1ff00bfffff]

I instrumented bootup with pci_bus_add_resource_offset and 
pci_bus_add_resource logs if this of any help:

/pci@1f,0: PCI IO[1fe02000000] MEM[1ff00000000]
/pci@1f,0: SABRE PCI Bus Module ver[0:0]
PCI: Scanning PBM /pci@1f,0
pci_bus_add_resource_offset adding [io  0x1fe02000000-0x1fe02ffffff]
pci_bus_add_resource_offset adding [mem 0x1ff00000000-0x1ffffffffff]
pci_bus_add_resource_offset adding [bus 00-02]
sabre f005f9c0: PCI host bridge to bus 0000:00
pci_bus 0000:00: pci_bus_add_resource adding [io  0x1fe02000000-0x1fe02ffffff] with flags 0
pci_bus 0000:00: root bus resource [io  0x1fe02000000-0x1fe02ffffff] (bus address [0x0000-0xffffff])
pci_bus 0000:00: pci_bus_add_resource adding [mem 0x1ff00000000-0x1ffffffffff] with flags 0
pci_bus 0000:00: root bus resource [mem 0x1ff00000000-0x1ffffffffff] (bus address [0x00000000-0xffffffff])
pci_bus 0000:00: root bus resource [bus 00-02]

To me it looks like we get the PCI bus ranges and store them and nobody 
uses them until now, and then we insert PCI devices with allocations 
from OF and do not update PCI bus available windows?

-- 
Meelis Roos (mroos@linux.ee)

  reply	other threads:[~2013-09-25 23:26 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-06 14:41 PCI Radeon RV100 detection hang on sparc64 Meelis Roos
2012-09-06 16:51 ` Adam Jackson
2012-09-06 18:15   ` David Miller
2012-09-06 16:55 ` Michel Dänzer
2012-09-06 18:18   ` David Miller
2012-09-07  7:18     ` Dave Airlie
2012-09-19  7:51       ` mroos
2013-09-23 13:48       ` mroos
2013-09-23 19:06         ` Kjetil Oftedal
2013-09-23 20:36           ` David Miller
2013-09-23 21:14             ` mroos
2013-09-23 21:33               ` David Miller
2013-09-24 11:06                 ` Meelis Roos
2013-09-25 23:26                   ` Meelis Roos [this message]
2013-10-01  8:43               ` Meelis Roos
2014-04-04 20:52                 ` David Miller
2014-08-13  6:30                   ` David Miller
2014-08-19 11:17                     ` Meelis Roos
2014-08-25 14:48                       ` Meelis Roos
2014-08-26  2:46                         ` Michel Dänzer
2014-08-26  7:07                           ` Meelis Roos
2014-08-27  2:24                             ` Michel Dänzer
2014-08-30 19:20                               ` Kjetil Oftedal
2014-08-31  5:59                                 ` Meelis Roos
2013-09-23 21:18           ` Meelis Roos
2013-10-10 11:51           ` [PATCH] only try to find radeon IGP ROM on X86 Meelis Roos
2013-10-10 14:38             ` Alex Deucher
2013-10-10 15:26               ` Meelis Roos
2013-10-10 17:02                 ` David Miller
2013-10-10 17:10                 ` Alex Deucher
2012-09-06 18:08 ` PCI Radeon RV100 detection hang on sparc64 David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.SOC.1.00.1309251604070.17530@math.ut.ee \
    --to=mroos@linux.ee \
    --cc=airlied@gmail.com \
    --cc=davem@davemloft.net \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=michel@daenzer.net \
    --cc=oftedal@gmail.com \
    --cc=sparclinux@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox