Re: [PATCH 1/3] drm: add register and unregister functions for connectors

[Daniel Vetter <daniel@ffwll.ch>]

On Tue, Jun 10, 2014 at 06:21:35PM +0200, David Herrmann wrote:
> Hi
> 
> On Thu, May 29, 2014 at 5:57 PM, Thomas Wood <thomas.wood@intel.com> wrote:
> > Introduce generic functions to register and unregister connectors. This
> > provides a common place to add and remove associated user space
> > interfaces.
> >
> > Signed-off-by: Thomas Wood <thomas.wood@intel.com>
> > ---
> >  Documentation/DocBook/drm.tmpl                |  6 +++---
> >  drivers/gpu/drm/armada/armada_output.c        |  4 ++--
> >  drivers/gpu/drm/ast/ast_mode.c                |  4 ++--
> >  drivers/gpu/drm/bridge/ptn3460.c              |  2 +-
> >  drivers/gpu/drm/drm_crtc.c                    | 30 ++++++++++++++++++++++++++-
> >  drivers/gpu/drm/drm_sysfs.c                   |  2 --
> >  drivers/gpu/drm/exynos/exynos_dp_core.c       |  2 +-
> >  drivers/gpu/drm/exynos/exynos_drm_connector.c |  6 +++---
> >  drivers/gpu/drm/exynos/exynos_drm_dpi.c       |  4 ++--
> >  drivers/gpu/drm/exynos/exynos_drm_dsi.c       |  2 +-
> >  drivers/gpu/drm/exynos/exynos_drm_vidi.c      |  2 +-
> >  drivers/gpu/drm/exynos/exynos_hdmi.c          |  2 +-
> >  drivers/gpu/drm/gma500/cdv_intel_crt.c        |  4 ++--
> >  drivers/gpu/drm/gma500/cdv_intel_dp.c         |  4 ++--
> >  drivers/gpu/drm/gma500/cdv_intel_hdmi.c       |  4 ++--
> >  drivers/gpu/drm/gma500/cdv_intel_lvds.c       |  4 ++--
> >  drivers/gpu/drm/gma500/mdfld_dsi_output.c     |  4 ++--
> >  drivers/gpu/drm/gma500/oaktrail_hdmi.c        |  2 +-
> >  drivers/gpu/drm/gma500/oaktrail_lvds.c        |  2 +-
> >  drivers/gpu/drm/gma500/psb_intel_lvds.c       |  4 ++--
> >  drivers/gpu/drm/gma500/psb_intel_sdvo.c       |  4 ++--
> >  drivers/gpu/drm/i915/intel_crt.c              |  2 +-
> >  drivers/gpu/drm/i915/intel_display.c          |  2 +-
> >  drivers/gpu/drm/i915/intel_dp.c               |  4 ++--
> >  drivers/gpu/drm/i915/intel_dsi.c              |  2 +-
> >  drivers/gpu/drm/i915/intel_dvo.c              |  2 +-
> >  drivers/gpu/drm/i915/intel_hdmi.c             |  2 +-
> >  drivers/gpu/drm/i915/intel_lvds.c             |  2 +-
> >  drivers/gpu/drm/i915/intel_sdvo.c             | 10 ++++-----
> >  drivers/gpu/drm/i915/intel_tv.c               |  2 +-
> >  drivers/gpu/drm/mgag200/mgag200_mode.c        |  2 +-
> >  drivers/gpu/drm/msm/hdmi/hdmi_connector.c     |  4 ++--
> >  drivers/gpu/drm/nouveau/nouveau_connector.c   |  4 ++--
> >  drivers/gpu/drm/omapdrm/omap_connector.c      |  4 ++--
> >  drivers/gpu/drm/qxl/qxl_display.c             |  4 ++--
> >  drivers/gpu/drm/radeon/radeon_connectors.c    |  6 +++---
> >  drivers/gpu/drm/rcar-du/rcar_du_lvdscon.c     |  4 ++--
> >  drivers/gpu/drm/rcar-du/rcar_du_vgacon.c      |  4 ++--
> >  drivers/gpu/drm/shmobile/shmob_drm_crtc.c     |  6 +++---
> >  drivers/gpu/drm/tegra/output.c                |  4 ++--
> >  drivers/gpu/drm/tilcdc/tilcdc_panel.c         |  2 +-
> >  drivers/gpu/drm/tilcdc/tilcdc_slave.c         |  2 +-
> >  drivers/gpu/drm/tilcdc/tilcdc_tfp410.c        |  2 +-
> >  drivers/gpu/drm/udl/udl_connector.c           |  4 ++--
> >  drivers/gpu/drm/vmwgfx/vmwgfx_kms.c           |  2 +-
> >  drivers/gpu/drm/vmwgfx/vmwgfx_ldu.c           |  2 +-
> >  drivers/gpu/drm/vmwgfx/vmwgfx_scrn.c          |  2 +-
> >  drivers/staging/imx-drm/imx-drm-core.c        |  6 +++---
> 
> You even caught imx.. and you removed the EXPORT_SYMBOL. So looks all
> good to me.
> I like that refactoring and I don't think we need an ACK from all
> driver authors. This is:
> 
> Reviewed-by: David Herrmann <dh.herrmann@gmail.com>
> 
> Maybe Daniel or Dave can pick this up?

I've pulled in all three patches into my topic/core-stuff branch and will
send a pull request to Dave once drm-next is open.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch