From: Daniel Vetter <daniel@ffwll.ch>
To: Liu Ying <Ying.Liu@freescale.com>
Cc: dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm/fb-helper: Redundant info->fix.type_aux setting in drm_fb_helper_fill_fix()
Date: Thu, 19 Jun 2014 09:16:46 +0200 [thread overview]
Message-ID: <20140619071646.GP5821@phenom.ffwll.local> (raw)
In-Reply-To: <1403162077-3065-1-git-send-email-Ying.Liu@freescale.com>
On Thu, Jun 19, 2014 at 03:14:37PM +0800, Liu Ying wrote:
> The variable info->fix.type_aux is set to zero twice in the function
> drm_fb_helper_fill_fix(). This patch removes one redundant.
>
> Signed-off-by: Liu Ying <Ying.Liu@freescale.com>
Merged into my topic/core-stuff branch, will show up in 3.17.
-Daniel
> ---
> drivers/gpu/drm/drm_fb_helper.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/drm_fb_helper.c b/drivers/gpu/drm/drm_fb_helper.c
> index 8daa4ad..142c39c 100644
> --- a/drivers/gpu/drm/drm_fb_helper.c
> +++ b/drivers/gpu/drm/drm_fb_helper.c
> @@ -1056,7 +1056,6 @@ void drm_fb_helper_fill_fix(struct fb_info *info, uint32_t pitch,
> info->fix.ypanstep = 1; /* doing it in hw */
> info->fix.ywrapstep = 0;
> info->fix.accel = FB_ACCEL_NONE;
> - info->fix.type_aux = 0;
>
> info->fix.line_length = pitch;
> return;
> --
> 1.7.9.5
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
prev parent reply other threads:[~2014-06-19 7:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-19 7:14 [PATCH] drm/fb-helper: Redundant info->fix.type_aux setting in drm_fb_helper_fill_fix() Liu Ying
2014-06-19 7:16 ` Daniel Vetter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140619071646.GP5821@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=Ying.Liu@freescale.com \
--cc=dri-devel@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox