From: Matt Roper <matthew.d.roper@intel.com>
To: Rob Clark <robdclark@gmail.com>
Cc: dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 4/7] drm: convert plane to properties/state
Date: Wed, 23 Jul 2014 17:42:38 -0700 [thread overview]
Message-ID: <20140724004238.GH22304@intel.com> (raw)
In-Reply-To: <1406144300-4995-5-git-send-email-robdclark@gmail.com>
On Wed, Jul 23, 2014 at 03:38:17PM -0400, Rob Clark wrote:
...
> @@ -2702,10 +2895,11 @@ static int drm_mode_cursor_universal(struct drm_crtc *crtc,
> * setplane_internal will take care of deref'ing either the old or new
> * framebuffer depending on success.
> */
> - ret = setplane_internal(crtc->cursor, crtc, fb,
> + ret = setplane_internal(crtc->cursor,
> + crtc->base.id, fb ? fb->base.id : 0,
> crtc_x, crtc_y, crtc_w, crtc_h,
> 0, 0, src_w, src_h);
> -
> + drm_framebuffer_unreference(fb);
I haven't had time to look through this in depth yet, but can't we wind
up unreferencing NULL here?
Also, the comment above this call should probably be updated/removed
since the locking works a bit differently now?
Matt
--
Matt Roper
Graphics Software Engineer
IoTG Platform Enabling & Development
Intel Corporation
(916) 356-2795
next prev parent reply other threads:[~2014-07-24 0:40 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-23 19:38 [PATCH 0/7] prepare for atomic.. the great propertyification Rob Clark
2014-07-23 19:38 ` [PATCH 1/7] drm: add atomic fxns Rob Clark
2014-07-23 21:34 ` Daniel Vetter
2014-07-23 21:38 ` Daniel Vetter
2014-07-24 10:02 ` Thierry Reding
2014-07-24 18:31 ` "Stéphane Viau"
2014-07-23 19:38 ` [PATCH 2/7] drm: split propvals out and blob property support Rob Clark
2014-07-23 19:38 ` [PATCH 3/7] drm: Refactor object property check code Rob Clark
2014-07-23 19:38 ` [PATCH 4/7] drm: convert plane to properties/state Rob Clark
2014-07-24 0:42 ` Matt Roper [this message]
2014-07-23 19:38 ` [PATCH 5/7] drm: convert crtc " Rob Clark
2014-07-23 19:38 ` [PATCH 6/7] drm/msm: add atomic support Rob Clark
2014-07-23 19:38 ` [PATCH 7/7] drm: Fix up the atomic legacy paths so they work Rob Clark
2014-07-24 12:25 ` [PATCH 0/7] prepare for atomic.. the great propertyification Daniel Vetter
2014-07-24 13:36 ` Rob Clark
2014-07-24 14:00 ` Daniel Vetter
2014-07-24 14:56 ` Rob Clark
2014-07-25 8:15 ` Daniel Vetter
2014-07-25 12:13 ` Rob Clark
-- strict thread matches above, loose matches on Subject: below --
2014-05-30 17:23 [PATCH 0/7] prepare for atomic/nuclear modeset/pageflip (vN+1) Rob Clark
2014-05-30 17:23 ` [PATCH 4/7] drm: convert plane to properties/state Rob Clark
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140724004238.GH22304@intel.com \
--to=matthew.d.roper@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=robdclark@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox