Re: [PATCH 1/7] drm: add atomic fxns

["\"Stéphane Viau\"" <sviau@codeaurora.org>]

Hi,

>>  {
>>  	int ret = -EINVAL;
>> -	struct drm_connector *connector = obj_to_connector(obj);
>>
>>  	/* Do DPMS ourselves */
>>  	if (property == connector->dev->mode_config.dpms_property) {
>>  		if (connector->funcs->dpms)
>>  			(*connector->funcs->dpms)(connector, (int)value);
>>  		ret = 0;
>> -	} else if (connector->funcs->set_property)
>> -		ret = connector->funcs->set_property(connector, property,
> value);
>> +	} else if (connector->funcs->set_property) {
>> +		ret = connector->funcs->set_property(connector, state,
>> +				property, value, blob_data);
>> +	}
>
> Why the extra braces here? There's still only one statement in the
> block.
>

According to Documentation/kernel-doc-nano-HOWTO.txt, these extra braces are
supposed to be present:

"
		Chapter 3: Placing Braces and Spaces
[...]
Do not unnecessarily use braces where a single statement will do.
[...]
This does not apply if only one branch of a conditional statement is a single
statement; in the latter case use braces in both branches:

if (condition) {
	do_this();
	do_that();
} else {
	otherwise();
}
"

Stéphane.

>>  /**
>> - * drm_mode_getproperty_ioctl - get the current value of a object's
> property
>> + * drm_mode_obj_get_properties_ioctl - get the current value of a
> object's property
>>   * @dev: DRM device
>>   * @data: ioctl data
>>   * @file_priv: DRM file info
>
> This isn't really introduced by this patch, but isn't this kerneldoc
> comment wrong? drm_mode_obj_get_properties_ioctl() seems to return the
> values of all properties of an object rather than just one.
>
> Thierry
>


-- 
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
hosted by The Linux Foundation