From: Daniel Vetter <daniel@ffwll.ch>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: dri-devel <dri-devel@lists.freedesktop.org>
Subject: Re: [PATCH] drm: fix drm_modeset_lock.h kernel-doc notation
Date: Mon, 25 Aug 2014 14:57:52 +0200 [thread overview]
Message-ID: <20140825125752.GE15520@phenom.ffwll.local> (raw)
In-Reply-To: <53EFC9F6.7060300@infradead.org>
On Sat, Aug 16, 2014 at 02:15:34PM -0700, Randy Dunlap wrote:
> From: Randy Dunlap <rdunlap@infradead.org>
>
> Fix drm kernel-doc notation to squelch these warnings:
>
> Warning(..//include/drm/drm_modeset_lock.h:41): cannot understand function prototype: 'struct drm_modeset_acquire_ctx '
> Warning(..//include/drm/drm_modeset_lock.h:66): cannot understand function prototype: 'struct drm_modeset_lock '
>
> Need to include the keyword 'struct' for structure descriptions.
>
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
And pulled into my drm core stuff topic branch for 3.18 so it won't get
lost.
-Daniel
> ---
> include/drm/drm_modeset_lock.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> Index: lnx-317-rc1/include/drm/drm_modeset_lock.h
> ===================================================================
> --- lnx-317-rc1.orig/include/drm/drm_modeset_lock.h
> +++ lnx-317-rc1/include/drm/drm_modeset_lock.h
> @@ -29,7 +29,7 @@
> struct drm_modeset_lock;
>
> /**
> - * drm_modeset_acquire_ctx - locking context (see ww_acquire_ctx)
> + * struct drm_modeset_acquire_ctx - locking context (see ww_acquire_ctx)
> * @ww_ctx: base acquire ctx
> * @contended: used internally for -EDEADLK handling
> * @locked: list of held locks
> @@ -56,7 +56,7 @@ struct drm_modeset_acquire_ctx {
> };
>
> /**
> - * drm_modeset_lock - used for locking modeset resources.
> + * struct drm_modeset_lock - used for locking modeset resources.
> * @mutex: resource locking
> * @head: used to hold it's place on state->locked list when
> * part of an atomic update
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
prev parent reply other threads:[~2014-08-25 12:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-16 21:15 [PATCH] drm: fix drm_modeset_lock.h kernel-doc notation Randy Dunlap
2014-08-25 12:57 ` Daniel Vetter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140825125752.GE15520@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=rdunlap@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox