From: Daniel Vetter <daniel@ffwll.ch>
To: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
Cc: Chuck Ebbert <cebbert.lkml@gmail.com>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>
Subject: Re: [PATCH v2] drm/crtc: Remove duplicated ioctl code
Date: Wed, 22 Oct 2014 10:39:29 +0200 [thread overview]
Message-ID: <20141022083929.GM26941@phenom.ffwll.local> (raw)
In-Reply-To: <20141021140810.GL4284@intel.com>
On Tue, Oct 21, 2014 at 05:08:10PM +0300, Ville Syrjälä wrote:
> On Wed, Oct 08, 2014 at 11:40:34AM -0500, Chuck Ebbert wrote:
> > Make drm_mode_add_fb() call drm_mode_add_fb2() after converting its
> > args to the new internal format, instead of duplicating code.
> >
> > Also picks up a lot more error checking, which the legacy modes
> > should pass after being converted to the new format.
> >
> > Signed-off-by: Chuck Ebbert <cebbert.lkml@gmail.com>
>
> Looks good to me.
>
> Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Picked up into my drm core stuff queue.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
prev parent reply other threads:[~2014-10-22 8:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-08 16:40 [PATCH v2] drm/crtc: Remove duplicated ioctl code Chuck Ebbert
2014-10-21 14:08 ` Ville Syrjälä
2014-10-22 8:39 ` Daniel Vetter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141022083929.GM26941@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=cebbert.lkml@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox