From: Thierry Reding <thierry.reding@gmail.com>
To: Sean Paul <seanpaul@chromium.org>
Cc: dri-devel <dri-devel@lists.freedesktop.org>
Subject: Re: [PATCH 02/17] drm/tegra: Do not enable output on .mode_set()
Date: Tue, 4 Nov 2014 15:50:13 +0100 [thread overview]
Message-ID: <20141104145012.GE31200@ulmo> (raw)
In-Reply-To: <CAOw6vbLnK=Dv4Ep=CvK2U0PRxAwccA0MBcaTwkq8M=wkHC5zKQ@mail.gmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 695 bytes --]
On Mon, Nov 03, 2014 at 12:18:30PM -0500, Sean Paul wrote:
> On Mon, Nov 3, 2014 at 4:27 AM, Thierry Reding <thierry.reding@gmail.com> wrote:
> > From: Thierry Reding <treding@nvidia.com>
> >
> > The output is already enabled in .dpms(), doing it in .mode_set() too
> > can cause noticeable flicker.
> >
>
> I think this should be coupled with "drm/tegra: DPMS off/on in encoder
> prepare/commit" that I sent earlier this week. Without it, the driver
> can get into a state where connector status is on, but the output is
> disabled.
I'm not sure I exactly understand which problem that patch fixes, but
I'll give it some testing to see if it doesn't break anything.
Thierry
[-- Attachment #1.2: Type: application/pgp-signature, Size: 819 bytes --]
[-- Attachment #2: Type: text/plain, Size: 159 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2014-11-04 14:50 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-03 9:27 [PATCH 01/17] drm/tegra: dc: Add powergate support Thierry Reding
2014-11-03 9:27 ` [PATCH 02/17] drm/tegra: Do not enable output on .mode_set() Thierry Reding
2014-11-03 17:18 ` Sean Paul
2014-11-04 14:50 ` Thierry Reding [this message]
2014-11-04 15:11 ` Sean Paul
2014-11-04 15:26 ` Thierry Reding
2014-11-04 16:38 ` Daniel Vetter
2014-11-03 9:27 ` [PATCH 03/17] drm/tegra: dsi: Make FIFO depths host parameters Thierry Reding
2014-11-03 17:20 ` Sean Paul
2014-11-04 15:45 ` Thierry Reding
2014-11-03 9:27 ` [PATCH v2 04/17] drm/tegra: dsi: Add ganged mode support Thierry Reding
2014-11-03 18:30 ` Sean Paul
2014-11-04 15:49 ` Thierry Reding
2014-11-03 9:27 ` [PATCH 05/17] drm/tegra: dsi: Set up PHY_TIMING & BTA_TIMING registers earlier Thierry Reding
2014-11-03 9:27 ` [PATCH 06/17] drm/tegra: dc: Add missing call to drm_vblank_on() Thierry Reding
2014-11-03 18:45 ` Sean Paul
2014-11-03 18:50 ` Daniel Vetter
2014-11-04 14:08 ` Thierry Reding
2014-11-04 4:21 ` Alexandre Courbot
2014-11-03 9:27 ` [PATCH 07/17] drm/tegra: gem: Extract tegra_bo_alloc_object() Thierry Reding
2014-11-03 9:27 ` [PATCH 08/17] drm/tegra: gem: Cleanup tegra_bo_create_with_handle() Thierry Reding
2014-11-03 9:27 ` [PATCH 09/17] drm/tegra: gem: Remove redundant drm_gem_free_mmap_offset() Thierry Reding
2014-11-03 9:27 ` [PATCH 10/17] drm/tegra: gem: Use dma_mmap_writecombine() Thierry Reding
2014-11-03 9:27 ` [PATCH v5 11/17] drm/tegra: Add IOMMU support Thierry Reding
2014-11-03 9:27 ` [PATCH 12/17] drm/tegra: dc: Factor out DC, window and cursor commit Thierry Reding
2014-11-03 9:27 ` [PATCH 13/17] drm/tegra: dc: Registers are 32 bits wide Thierry Reding
2014-11-03 9:27 ` [PATCH 14/17] drm/tegra: dc: Universal plane support Thierry Reding
2014-11-03 9:27 ` [PATCH 15/17] drm/tegra: Fix potential bug on driver unload Thierry Reding
2014-11-04 10:59 ` Andrzej Hajda
2014-11-04 12:30 ` Thierry Reding
2014-11-03 9:27 ` [PATCH 16/17] drm/tegra: gem: dumb: pitch and size are outputs Thierry Reding
2014-11-03 9:51 ` Daniel Vetter
2014-11-03 10:12 ` Thierry Reding
2014-11-03 9:27 ` [PATCH 17/17] drm/tegra: fb: Do not destroy framebuffer Thierry Reding
2014-11-03 9:53 ` Daniel Vetter
2014-11-04 16:08 ` Thierry Reding
2014-11-03 17:15 ` [PATCH 01/17] drm/tegra: dc: Add powergate support Sean Paul
2014-11-04 12:34 ` Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141104145012.GE31200@ulmo \
--to=thierry.reding@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=seanpaul@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox