From: Thierry Reding <thierry.reding@gmail.com>
To: Philipp Zabel <p.zabel@pengutronix.de>,
Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Russell King <rmk+kernel@arm.linux.org.uk>,
Thierry Reding <treding@nvidia.com>,
dri-devel@lists.freedesktop.org, kernel@pengutronix.de
Subject: Re: [PATCH 3/4] drm: bridge/dw-hdmi: detect initial connector state
Date: Wed, 2 Mar 2016 17:35:54 +0100 [thread overview]
Message-ID: <20160302163554.GB31136@ulmo.nvidia.com> (raw)
In-Reply-To: <1452243727-7242-3-git-send-email-p.zabel@pengutronix.de>
[-- Attachment #1.1: Type: text/plain, Size: 1391 bytes --]
On Fri, Jan 08, 2016 at 10:02:06AM +0100, Philipp Zabel wrote:
> Allow userspace to read the initial connector state via sysfs without
> having to issue a detect manually. There is no reason to keep the state
> unknown during initialization.
>
> Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
> ---
> drivers/gpu/drm/bridge/dw-hdmi.c | 2 ++
> 1 file changed, 2 insertions(+)
It would seem to me that this should be the default, rather than having
to duplicate this into every driver.
Daniel, can you think of a reason why we wouldn't want to do handle this
in the core so that all drivers can benefit?
Thierry
>
> diff --git a/drivers/gpu/drm/bridge/dw-hdmi.c b/drivers/gpu/drm/bridge/dw-hdmi.c
> index e41ff4b..2388a55 100644
> --- a/drivers/gpu/drm/bridge/dw-hdmi.c
> +++ b/drivers/gpu/drm/bridge/dw-hdmi.c
> @@ -1660,6 +1660,8 @@ static int dw_hdmi_register(struct drm_device *drm, struct dw_hdmi *hdmi)
> DRM_MODE_CONNECTOR_HDMIA);
>
> hdmi->connector.encoder = encoder;
> + hdmi->connector.status = dw_hdmi_connector_detect(&hdmi->connector,
> + false);
>
> drm_mode_connector_attach_encoder(&hdmi->connector, encoder);
>
> --
> 2.6.4
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2016-03-02 16:35 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-08 9:02 [PATCH 1/4] drm: bridge/dw-hdmi: cache edid data Philipp Zabel
2016-01-08 9:02 ` [PATCH 2/4] drm: bridge/dw-hdmi: remove unused code Philipp Zabel
2016-01-08 9:02 ` [PATCH 3/4] drm: bridge/dw-hdmi: detect initial connector state Philipp Zabel
2016-01-08 11:24 ` Russell King - ARM Linux
2016-01-08 11:40 ` Philipp Zabel
2016-03-02 16:35 ` Thierry Reding [this message]
2016-01-08 9:02 ` [PATCH 4/4] drm: bridge/dw-hdmi: use rx sense for plug detection if hpd is unreliable Philipp Zabel
2016-01-08 11:34 ` Russell King - ARM Linux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160302163554.GB31136@ulmo.nvidia.com \
--to=thierry.reding@gmail.com \
--cc=daniel.vetter@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=kernel@pengutronix.de \
--cc=p.zabel@pengutronix.de \
--cc=rmk+kernel@arm.linux.org.uk \
--cc=treding@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox