From: Daniel Vetter <daniel@ffwll.ch>
To: Alexey Brodkin <Alexey.Brodkin@synopsys.com>
Cc: "daniel.vetter@intel.com" <daniel.vetter@intel.com>,
"daniel.vetter@ffwll.ch" <daniel.vetter@ffwll.ch>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>
Subject: Re: [PATCH] drm/atmel: Fixup drm_connector_/unplug/unregister/_all
Date: Tue, 29 Mar 2016 14:55:16 +0200 [thread overview]
Message-ID: <20160329125516.GY2510@phenom.ffwll.local> (raw)
In-Reply-To: <1459254355.3021.34.camel@synopsys.com>
On Tue, Mar 29, 2016 at 12:25:55PM +0000, Alexey Brodkin wrote:
> Hi Daniel,
>
> On Tue, 2016-03-29 at 14:21 +0200, Daniel Vetter wrote:
> > Accidentally fell through the cracks in
> >
> > commit 6c87e5c3ec6db052f3744804a517b6fb003906e1
> > Author: Alexey Brodkin <Alexey.Brodkin@synopsys.com>
> > Date: Wed Mar 23 11:42:54 2016 +0300
> >
> > drm: Rename drm_connector_unplug_all() to drm_connector_unregister_all()
> >
> > despite that Boris acked that patch.
> >
> > Cc: Boris Brezillon <boris.brezillon@free-electrons.com>
> > Cc: Alexey Brodkin <abrodkin@synopsys.com>
> > Acked-by: Boris Brezillon <boris.brezillon@free-electrons.com>
> > Reported-by: kbuild test robot <fengguang.wu@intel.com>
> > Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
> > ---
> > drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c
> > index 3d8d16402d07..8ab4318e57a1 100644
> > --- a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c
> > +++ b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c
> > @@ -615,7 +615,7 @@ err:
> > static void atmel_hlcdc_dc_connector_unplug_all(struct drm_device *dev)
> > {
> > mutex_lock(&dev->mode_config.mutex);
> > - drm_connector_unplug_all(dev);
> > + drm_connector_unregister_all(dev);
> > mutex_unlock(&dev->mode_config.mutex);
> > }
>
> Isn't done in my "[PATCH 2/3 v5] drm: atmel_hldc: Use generic drm_connector_register_all() helper"?
Yes, but splitting it like that breaks bisectability, which isn't good.
Also your atmel change drops the mode_config.mutex. We might want to have
that part in a separate patch, so that the atmel patch only switches over
to the register_all helper.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2016-03-29 12:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-29 12:21 [PATCH] drm/atmel: Fixup drm_connector_/unplug/unregister/_all Daniel Vetter
2016-03-29 12:25 ` Alexey Brodkin
2016-03-29 12:47 ` Boris Brezillon
2016-03-29 12:55 ` Daniel Vetter [this message]
2016-03-30 12:34 ` Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160329125516.GY2510@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=Alexey.Brodkin@synopsys.com \
--cc=daniel.vetter@ffwll.ch \
--cc=daniel.vetter@intel.com \
--cc=dri-devel@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox