From: Thierry Reding <thierry.reding@gmail.com>
To: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Daniel Vetter <daniel.vetter@intel.com>,
Alexey Brodkin <abrodkin@synopsys.com>,
DRI Development <dri-devel@lists.freedesktop.org>
Subject: Re: [PATCH] drm/atmel: Fixup drm_connector_/unplug/unregister/_all
Date: Wed, 30 Mar 2016 14:34:40 +0200 [thread overview]
Message-ID: <20160330123440.GB2329@ulmo> (raw)
In-Reply-To: <1459254098-1278-1-git-send-email-daniel.vetter@ffwll.ch>
[-- Attachment #1.1: Type: text/plain, Size: 1718 bytes --]
On Tue, Mar 29, 2016 at 02:21:38PM +0200, Daniel Vetter wrote:
> Accidentally fell through the cracks in
>
> commit 6c87e5c3ec6db052f3744804a517b6fb003906e1
> Author: Alexey Brodkin <Alexey.Brodkin@synopsys.com>
> Date: Wed Mar 23 11:42:54 2016 +0300
>
> drm: Rename drm_connector_unplug_all() to drm_connector_unregister_all()
>
> despite that Boris acked that patch.
>
> Cc: Boris Brezillon <boris.brezillon@free-electrons.com>
> Cc: Alexey Brodkin <abrodkin@synopsys.com>
> Acked-by: Boris Brezillon <boris.brezillon@free-electrons.com>
> Reported-by: kbuild test robot <fengguang.wu@intel.com>
> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
> ---
> drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c
> index 3d8d16402d07..8ab4318e57a1 100644
> --- a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c
> +++ b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c
> @@ -615,7 +615,7 @@ err:
> static void atmel_hlcdc_dc_connector_unplug_all(struct drm_device *dev)
> {
> mutex_lock(&dev->mode_config.mutex);
> - drm_connector_unplug_all(dev);
> + drm_connector_unregister_all(dev);
> mutex_unlock(&dev->mode_config.mutex);
> }
>
I think the locking here is completely unnecessary, since
drm_connector_unregister_all() doesn't actually do anything with the
connector object as far as DRM device is concerned, it merely removes it
from sysfs and debugfs.
But given that I sent out almost the same patch earlier, and this does
fix a build failure:
Reviewed-by: Thierry Reding <treding@nvidia.com>
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
prev parent reply other threads:[~2016-03-30 12:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-29 12:21 [PATCH] drm/atmel: Fixup drm_connector_/unplug/unregister/_all Daniel Vetter
2016-03-29 12:25 ` Alexey Brodkin
2016-03-29 12:47 ` Boris Brezillon
2016-03-29 12:55 ` Daniel Vetter
2016-03-30 12:34 ` Thierry Reding [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160330123440.GB2329@ulmo \
--to=thierry.reding@gmail.com \
--cc=abrodkin@synopsys.com \
--cc=daniel.vetter@ffwll.ch \
--cc=daniel.vetter@intel.com \
--cc=dri-devel@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox