From: Daniel Vetter <daniel@ffwll.ch>
To: Tomi Valkeinen <tomi.valkeinen@ti.com>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
DRI Development <dri-devel@lists.freedesktop.org>,
Daniel Vetter <daniel.vetter@intel.com>
Subject: Re: [PATCH 02/13] drm/omapdrm: Use unlocked gem unreferencing
Date: Wed, 20 Apr 2016 12:55:01 +0200 [thread overview]
Message-ID: <20160420105501.GI2510@phenom.ffwll.local> (raw)
In-Reply-To: <57150808.5080508@ti.com>
On Mon, Apr 18, 2016 at 07:15:04PM +0300, Tomi Valkeinen wrote:
> On 30/03/16 12:40, Daniel Vetter wrote:
> > For drm_gem_object_unreference callers are required to hold
> > dev->struct_mutex, which these paths don't. Enforcing this requirement
> > has become a bit more strict with
> >
> > commit ef4c6270bf2867e2f8032e9614d1a8cfc6c71663
> > Author: Daniel Vetter <daniel.vetter@ffwll.ch>
> > Date: Thu Oct 15 09:36:25 2015 +0200
> >
> > drm/gem: Check locking in drm_gem_object_unreference
> >
> > Cc: Tomi Valkeinen <tomi.valkeinen@ti.com>
> > Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> > Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
> > ---
> > drivers/gpu/drm/omapdrm/omap_fbdev.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/omapdrm/omap_fbdev.c b/drivers/gpu/drm/omapdrm/omap_fbdev.c
> > index 3cb16f0cf381..89da41ac64d2 100644
> > --- a/drivers/gpu/drm/omapdrm/omap_fbdev.c
> > +++ b/drivers/gpu/drm/omapdrm/omap_fbdev.c
> > @@ -153,7 +153,7 @@ static int omap_fbdev_create(struct drm_fb_helper *helper,
> > /* note: if fb creation failed, we can't rely on fb destroy
> > * to unref the bo:
> > */
> > - drm_gem_object_unreference(fbdev->bo);
> > + drm_gem_object_unreference_unlocked(fbdev->bo);
> > ret = PTR_ERR(fb);
> > goto fail;
> > }
> >
>
> If this is already queued somewhere:
>
> Acked-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
>
> If not, I can pick this up.
I've piled all the remaining ones into a branch and will send a pull
request to Dave later this week, with this one included.
Thanks, Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2016-04-20 10:55 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-30 9:40 [PATCH 00/13] Gem cleanup&fixes resend, once more Daniel Vetter
2016-03-30 9:40 ` [PATCH 01/13] drm/nouveau: Use unlocked gem unreferencing Daniel Vetter
2016-03-30 9:40 ` [PATCH 02/13] drm/omapdrm: " Daniel Vetter
2016-04-18 16:15 ` Tomi Valkeinen
2016-04-20 10:55 ` Daniel Vetter [this message]
2016-04-20 13:52 ` Laurent Pinchart
2016-03-30 9:40 ` [PATCH 03/13] drm/qxl: " Daniel Vetter
2016-03-30 9:40 ` [PATCH 04/13] drm/udl: " Daniel Vetter
2016-03-30 10:55 ` poma
2016-03-30 9:40 ` [PATCH 05/13] drm/nouveau: Drop dev->struct_mutex from fbdev init Daniel Vetter
2016-03-30 9:40 ` [PATCH 06/13] drm/exynos: Drop dev->struct_mutex from mmap offset function Daniel Vetter
2016-03-30 9:40 ` [PATCH 07/13] drm/exynos: drop struct_mutex from exynos_gem_map_sgt_with_dma Daniel Vetter
2016-03-30 10:23 ` Emil Velikov
2016-03-30 9:40 ` [PATCH 08/13] drm/exynos: drop struct_mutex from exynos_drm_gem_get_ioctl Daniel Vetter
2016-03-30 9:40 ` [PATCH 09/13] drm/exynos: drop struct_mutex from fbdev setup Daniel Vetter
2016-03-30 9:40 ` [PATCH 10/13] drm/vgem: Simplify dum_map Daniel Vetter
2016-03-30 10:29 ` Emil Velikov
2016-03-30 10:31 ` Daniel Stone
2016-03-30 9:40 ` [PATCH 11/13] drm/vgem: Move get_pages to gem_create Daniel Vetter
2016-03-30 9:40 ` [PATCH 12/13] drm/vgem: Drop dev->struct_mutex Daniel Vetter
2016-03-30 9:40 ` [PATCH 13/13] drm/vma_manage: Drop has_offset Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160420105501.GI2510@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=daniel.vetter@ffwll.ch \
--cc=daniel.vetter@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=tomi.valkeinen@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox