From: poma <pomidorabelisima@gmail.com>
To: Daniel Vetter <daniel.vetter@ffwll.ch>,
DRI Development <dri-devel@lists.freedesktop.org>
Cc: Daniel Vetter <daniel.vetter@intel.com>,
Dave Airlie <airlied@redhat.com>
Subject: Re: [PATCH 04/13] drm/udl: Use unlocked gem unreferencing
Date: Wed, 30 Mar 2016 12:55:06 +0200 [thread overview]
Message-ID: <56FBB08A.2000202@gmail.com> (raw)
In-Reply-To: <1459330852-27668-5-git-send-email-daniel.vetter@ffwll.ch>
On 30.03.2016 11:40, Daniel Vetter wrote:
> For drm_gem_object_unreference callers are required to hold
> dev->struct_mutex, which these paths don't. Enforcing this requirement
> has become a bit more strict with
>
> commit ef4c6270bf2867e2f8032e9614d1a8cfc6c71663
> Author: Daniel Vetter <daniel.vetter@ffwll.ch>
> Date: Thu Oct 15 09:36:25 2015 +0200
>
> drm/gem: Check locking in drm_gem_object_unreference
>
> Cc: Dave Airlie <airlied@redhat.com>
> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
> ---
> drivers/gpu/drm/udl/udl_fb.c | 2 +-
> drivers/gpu/drm/udl/udl_gem.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/udl/udl_fb.c b/drivers/gpu/drm/udl/udl_fb.c
> index 33239a2b264a..fd1eb9d03f0b 100644
> --- a/drivers/gpu/drm/udl/udl_fb.c
> +++ b/drivers/gpu/drm/udl/udl_fb.c
> @@ -536,7 +536,7 @@ static int udlfb_create(struct drm_fb_helper *helper,
> out_destroy_fbi:
> drm_fb_helper_release_fbi(helper);
> out_gfree:
> - drm_gem_object_unreference(&ufbdev->ufb.obj->base);
> + drm_gem_object_unreference_unlocked(&ufbdev->ufb.obj->base);
> out:
> return ret;
> }
> diff --git a/drivers/gpu/drm/udl/udl_gem.c b/drivers/gpu/drm/udl/udl_gem.c
> index 2a0a784ab6ee..d7528e0d8442 100644
> --- a/drivers/gpu/drm/udl/udl_gem.c
> +++ b/drivers/gpu/drm/udl/udl_gem.c
> @@ -52,7 +52,7 @@ udl_gem_create(struct drm_file *file,
> return ret;
> }
>
> - drm_gem_object_unreference(&obj->base);
> + drm_gem_object_unreference_unlocked(&obj->base);
> *handle_p = handle;
> return 0;
> }
>
Reviewed-by: poma <pomidorabelisima@gmail.com>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2016-03-30 10:55 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-30 9:40 [PATCH 00/13] Gem cleanup&fixes resend, once more Daniel Vetter
2016-03-30 9:40 ` [PATCH 01/13] drm/nouveau: Use unlocked gem unreferencing Daniel Vetter
2016-03-30 9:40 ` [PATCH 02/13] drm/omapdrm: " Daniel Vetter
2016-04-18 16:15 ` Tomi Valkeinen
2016-04-20 10:55 ` Daniel Vetter
2016-04-20 13:52 ` Laurent Pinchart
2016-03-30 9:40 ` [PATCH 03/13] drm/qxl: " Daniel Vetter
2016-03-30 9:40 ` [PATCH 04/13] drm/udl: " Daniel Vetter
2016-03-30 10:55 ` poma [this message]
2016-03-30 9:40 ` [PATCH 05/13] drm/nouveau: Drop dev->struct_mutex from fbdev init Daniel Vetter
2016-03-30 9:40 ` [PATCH 06/13] drm/exynos: Drop dev->struct_mutex from mmap offset function Daniel Vetter
2016-03-30 9:40 ` [PATCH 07/13] drm/exynos: drop struct_mutex from exynos_gem_map_sgt_with_dma Daniel Vetter
2016-03-30 10:23 ` Emil Velikov
2016-03-30 9:40 ` [PATCH 08/13] drm/exynos: drop struct_mutex from exynos_drm_gem_get_ioctl Daniel Vetter
2016-03-30 9:40 ` [PATCH 09/13] drm/exynos: drop struct_mutex from fbdev setup Daniel Vetter
2016-03-30 9:40 ` [PATCH 10/13] drm/vgem: Simplify dum_map Daniel Vetter
2016-03-30 10:29 ` Emil Velikov
2016-03-30 10:31 ` Daniel Stone
2016-03-30 9:40 ` [PATCH 11/13] drm/vgem: Move get_pages to gem_create Daniel Vetter
2016-03-30 9:40 ` [PATCH 12/13] drm/vgem: Drop dev->struct_mutex Daniel Vetter
2016-03-30 9:40 ` [PATCH 13/13] drm/vma_manage: Drop has_offset Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56FBB08A.2000202@gmail.com \
--to=pomidorabelisima@gmail.com \
--cc=airlied@redhat.com \
--cc=daniel.vetter@ffwll.ch \
--cc=daniel.vetter@intel.com \
--cc=dri-devel@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox