* [PATCH 01/27] drm/armada: Use lockless gem BO free callback
2016-05-30 17:52 [PATCH 00/27] locklesss gem BO free driver patches Daniel Vetter
@ 2016-05-30 17:52 ` Daniel Vetter
2016-06-01 16:26 ` Russell King - ARM Linux
2016-05-30 17:52 ` [PATCH 02/27] drm/ast: " Daniel Vetter
` (26 subsequent siblings)
27 siblings, 1 reply; 44+ messages in thread
From: Daniel Vetter @ 2016-05-30 17:52 UTC (permalink / raw)
To: DRI Development; +Cc: Daniel Vetter, Daniel Vetter, Russell King
No dev->struct_mutex anywhere to be seen.
Cc: Russell King <rmk+kernel@arm.linux.org.uk>
Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
---
drivers/gpu/drm/armada/armada_drv.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/armada/armada_drv.c b/drivers/gpu/drm/armada/armada_drv.c
index 439824a61aa5..cb21c0b6374a 100644
--- a/drivers/gpu/drm/armada/armada_drv.c
+++ b/drivers/gpu/drm/armada/armada_drv.c
@@ -197,7 +197,7 @@ static struct drm_driver armada_drm_driver = {
.debugfs_init = armada_drm_debugfs_init,
.debugfs_cleanup = armada_drm_debugfs_cleanup,
#endif
- .gem_free_object = armada_gem_free_object,
+ .gem_free_object_unlocked = armada_gem_free_object,
.prime_handle_to_fd = drm_gem_prime_handle_to_fd,
.prime_fd_to_handle = drm_gem_prime_fd_to_handle,
.gem_prime_export = armada_gem_prime_export,
--
2.8.1
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 44+ messages in thread* [PATCH 02/27] drm/ast: Use lockless gem BO free callback
2016-05-30 17:52 [PATCH 00/27] locklesss gem BO free driver patches Daniel Vetter
2016-05-30 17:52 ` [PATCH 01/27] drm/armada: Use lockless gem BO free callback Daniel Vetter
@ 2016-05-30 17:52 ` Daniel Vetter
2016-05-30 17:52 ` [PATCH 03/27] drm/atmel: " Daniel Vetter
` (25 subsequent siblings)
27 siblings, 0 replies; 44+ messages in thread
From: Daniel Vetter @ 2016-05-30 17:52 UTC (permalink / raw)
To: DRI Development; +Cc: Daniel Vetter, Daniel Vetter, Dave Airlie
No dev->struct_mutex anywhere to be seen.
Cc: Dave Airlie <airlied@redhat.com>
Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
---
drivers/gpu/drm/ast/ast_drv.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/ast/ast_drv.c b/drivers/gpu/drm/ast/ast_drv.c
index fcd9c0714836..f54afd2113a9 100644
--- a/drivers/gpu/drm/ast/ast_drv.c
+++ b/drivers/gpu/drm/ast/ast_drv.c
@@ -209,7 +209,7 @@ static struct drm_driver driver = {
.minor = DRIVER_MINOR,
.patchlevel = DRIVER_PATCHLEVEL,
- .gem_free_object = ast_gem_free_object,
+ .gem_free_object_unlocked = ast_gem_free_object,
.dumb_create = ast_dumb_create,
.dumb_map_offset = ast_dumb_mmap_offset,
.dumb_destroy = drm_gem_dumb_destroy,
--
2.8.1
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 44+ messages in thread* [PATCH 03/27] drm/atmel: Use lockless gem BO free callback
2016-05-30 17:52 [PATCH 00/27] locklesss gem BO free driver patches Daniel Vetter
2016-05-30 17:52 ` [PATCH 01/27] drm/armada: Use lockless gem BO free callback Daniel Vetter
2016-05-30 17:52 ` [PATCH 02/27] drm/ast: " Daniel Vetter
@ 2016-05-30 17:52 ` Daniel Vetter
2016-06-07 11:22 ` Boris Brezillon
2016-05-30 17:52 ` [PATCH 04/27] drm/bochs: " Daniel Vetter
` (24 subsequent siblings)
27 siblings, 1 reply; 44+ messages in thread
From: Daniel Vetter @ 2016-05-30 17:52 UTC (permalink / raw)
To: DRI Development; +Cc: Daniel Vetter, Daniel Vetter
No dev->struct_mutex anywhere to be seen.
Cc: Boris Brezillon <boris.brezillon@free-electrons.com>
Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
---
drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c
index 8ded7645747e..6485fa5bee8b 100644
--- a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c
+++ b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c
@@ -776,7 +776,7 @@ static struct drm_driver atmel_hlcdc_dc_driver = {
.get_vblank_counter = drm_vblank_no_hw_counter,
.enable_vblank = atmel_hlcdc_dc_enable_vblank,
.disable_vblank = atmel_hlcdc_dc_disable_vblank,
- .gem_free_object = drm_gem_cma_free_object,
+ .gem_free_object_unlocked = drm_gem_cma_free_object,
.gem_vm_ops = &drm_gem_cma_vm_ops,
.prime_handle_to_fd = drm_gem_prime_handle_to_fd,
.prime_fd_to_handle = drm_gem_prime_fd_to_handle,
--
2.8.1
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 44+ messages in thread* Re: [PATCH 03/27] drm/atmel: Use lockless gem BO free callback
2016-05-30 17:52 ` [PATCH 03/27] drm/atmel: " Daniel Vetter
@ 2016-06-07 11:22 ` Boris Brezillon
0 siblings, 0 replies; 44+ messages in thread
From: Boris Brezillon @ 2016-06-07 11:22 UTC (permalink / raw)
To: Daniel Vetter; +Cc: Daniel Vetter, DRI Development
On Mon, 30 May 2016 19:52:55 +0200
Daniel Vetter <daniel.vetter@ffwll.ch> wrote:
> No dev->struct_mutex anywhere to be seen.
>
> Cc: Boris Brezillon <boris.brezillon@free-electrons.com>
> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
Acked-by: Boris Brezillon <boris.brezillon@free-electrons.com>
> ---
> drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c
> index 8ded7645747e..6485fa5bee8b 100644
> --- a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c
> +++ b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c
> @@ -776,7 +776,7 @@ static struct drm_driver atmel_hlcdc_dc_driver = {
> .get_vblank_counter = drm_vblank_no_hw_counter,
> .enable_vblank = atmel_hlcdc_dc_enable_vblank,
> .disable_vblank = atmel_hlcdc_dc_disable_vblank,
> - .gem_free_object = drm_gem_cma_free_object,
> + .gem_free_object_unlocked = drm_gem_cma_free_object,
> .gem_vm_ops = &drm_gem_cma_vm_ops,
> .prime_handle_to_fd = drm_gem_prime_handle_to_fd,
> .prime_fd_to_handle = drm_gem_prime_fd_to_handle,
--
Boris Brezillon, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 44+ messages in thread
* [PATCH 04/27] drm/bochs: Use lockless gem BO free callback
2016-05-30 17:52 [PATCH 00/27] locklesss gem BO free driver patches Daniel Vetter
` (2 preceding siblings ...)
2016-05-30 17:52 ` [PATCH 03/27] drm/atmel: " Daniel Vetter
@ 2016-05-30 17:52 ` Daniel Vetter
2016-05-30 17:52 ` [PATCH 05/27] drm/cirrus: " Daniel Vetter
` (23 subsequent siblings)
27 siblings, 0 replies; 44+ messages in thread
From: Daniel Vetter @ 2016-05-30 17:52 UTC (permalink / raw)
To: DRI Development; +Cc: Daniel Vetter, Daniel Vetter, Dave Airlie
No dev->struct_mutex anywhere to be seen.
Cc: Gerd Hoffmann <kraxel@redhat.com>
Cc: Dave Airlie <airlied@redhat.com>
Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
---
drivers/gpu/drm/bochs/bochs_drv.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/bochs/bochs_drv.c b/drivers/gpu/drm/bochs/bochs_drv.c
index b332b4d3b0e2..abace82de6ea 100644
--- a/drivers/gpu/drm/bochs/bochs_drv.c
+++ b/drivers/gpu/drm/bochs/bochs_drv.c
@@ -89,7 +89,7 @@ static struct drm_driver bochs_driver = {
.date = "20130925",
.major = 1,
.minor = 0,
- .gem_free_object = bochs_gem_free_object,
+ .gem_free_object_unlocked = bochs_gem_free_object,
.dumb_create = bochs_dumb_create,
.dumb_map_offset = bochs_dumb_mmap_offset,
.dumb_destroy = drm_gem_dumb_destroy,
--
2.8.1
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 44+ messages in thread* [PATCH 05/27] drm/cirrus: Use lockless gem BO free callback
2016-05-30 17:52 [PATCH 00/27] locklesss gem BO free driver patches Daniel Vetter
` (3 preceding siblings ...)
2016-05-30 17:52 ` [PATCH 04/27] drm/bochs: " Daniel Vetter
@ 2016-05-30 17:52 ` Daniel Vetter
2016-05-30 17:52 ` [PATCH 06/27] drm/fls-dcu: " Daniel Vetter
` (22 subsequent siblings)
27 siblings, 0 replies; 44+ messages in thread
From: Daniel Vetter @ 2016-05-30 17:52 UTC (permalink / raw)
To: DRI Development; +Cc: Daniel Vetter, Daniel Vetter, Dave Airlie
No dev->struct_mutex anywhere to be seen.
Cc: Dave Airlie <airlied@redhat.com>
Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
---
drivers/gpu/drm/cirrus/cirrus_drv.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/cirrus/cirrus_drv.c b/drivers/gpu/drm/cirrus/cirrus_drv.c
index dc83f69da6f1..b05f7eae32ce 100644
--- a/drivers/gpu/drm/cirrus/cirrus_drv.c
+++ b/drivers/gpu/drm/cirrus/cirrus_drv.c
@@ -142,7 +142,7 @@ static struct drm_driver driver = {
.major = DRIVER_MAJOR,
.minor = DRIVER_MINOR,
.patchlevel = DRIVER_PATCHLEVEL,
- .gem_free_object = cirrus_gem_free_object,
+ .gem_free_object_unlocked = cirrus_gem_free_object,
.dumb_create = cirrus_dumb_create,
.dumb_map_offset = cirrus_dumb_mmap_offset,
.dumb_destroy = drm_gem_dumb_destroy,
--
2.8.1
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 44+ messages in thread* [PATCH 06/27] drm/fls-dcu: Use lockless gem BO free callback
2016-05-30 17:52 [PATCH 00/27] locklesss gem BO free driver patches Daniel Vetter
` (4 preceding siblings ...)
2016-05-30 17:52 ` [PATCH 05/27] drm/cirrus: " Daniel Vetter
@ 2016-05-30 17:52 ` Daniel Vetter
2016-05-30 17:52 ` [PATCH 07/27] drm/mga200g: " Daniel Vetter
` (21 subsequent siblings)
27 siblings, 0 replies; 44+ messages in thread
From: Daniel Vetter @ 2016-05-30 17:52 UTC (permalink / raw)
To: DRI Development; +Cc: Jianwei Wang, Daniel Vetter, Daniel Vetter
No dev->struct_mutex anywhere to be seen.
Cc: Jianwei Wang <jianwei.wang.chn@gmail.com>
Cc: Stefan Agner <stefan@agner.ch>
Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
---
drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c b/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c
index 0ec1ad961e0d..33727d5d826a 100644
--- a/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c
+++ b/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c
@@ -198,7 +198,7 @@ static struct drm_driver fsl_dcu_drm_driver = {
.get_vblank_counter = drm_vblank_no_hw_counter,
.enable_vblank = fsl_dcu_drm_enable_vblank,
.disable_vblank = fsl_dcu_drm_disable_vblank,
- .gem_free_object = drm_gem_cma_free_object,
+ .gem_free_object_unlocked = drm_gem_cma_free_object,
.gem_vm_ops = &drm_gem_cma_vm_ops,
.prime_handle_to_fd = drm_gem_prime_handle_to_fd,
.prime_fd_to_handle = drm_gem_prime_fd_to_handle,
--
2.8.1
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 44+ messages in thread* [PATCH 07/27] drm/mga200g: Use lockless gem BO free callback
2016-05-30 17:52 [PATCH 00/27] locklesss gem BO free driver patches Daniel Vetter
` (5 preceding siblings ...)
2016-05-30 17:52 ` [PATCH 06/27] drm/fls-dcu: " Daniel Vetter
@ 2016-05-30 17:52 ` Daniel Vetter
2016-05-30 17:53 ` [PATCH 08/27] drm/nouveau: " Daniel Vetter
` (20 subsequent siblings)
27 siblings, 0 replies; 44+ messages in thread
From: Daniel Vetter @ 2016-05-30 17:52 UTC (permalink / raw)
To: DRI Development; +Cc: Daniel Vetter, Daniel Vetter, Dave Airlie
No dev->struct_mutex anywhere to be seen.
Cc: Dave Airlie <airlied@redhat.com>
Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
---
drivers/gpu/drm/mgag200/mgag200_drv.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/mgag200/mgag200_drv.c b/drivers/gpu/drm/mgag200/mgag200_drv.c
index ebb470ff7200..2b4b125eebc3 100644
--- a/drivers/gpu/drm/mgag200/mgag200_drv.c
+++ b/drivers/gpu/drm/mgag200/mgag200_drv.c
@@ -101,7 +101,7 @@ static struct drm_driver driver = {
.minor = DRIVER_MINOR,
.patchlevel = DRIVER_PATCHLEVEL,
- .gem_free_object = mgag200_gem_free_object,
+ .gem_free_object_unlocked = mgag200_gem_free_object,
.dumb_create = mgag200_dumb_create,
.dumb_map_offset = mgag200_dumb_mmap_offset,
.dumb_destroy = drm_gem_dumb_destroy,
--
2.8.1
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 44+ messages in thread* [PATCH 08/27] drm/nouveau: Use lockless gem BO free callback
2016-05-30 17:52 [PATCH 00/27] locklesss gem BO free driver patches Daniel Vetter
` (6 preceding siblings ...)
2016-05-30 17:52 ` [PATCH 07/27] drm/mga200g: " Daniel Vetter
@ 2016-05-30 17:53 ` Daniel Vetter
2016-05-30 17:53 ` [PATCH 09/27] drm/qxl: " Daniel Vetter
` (19 subsequent siblings)
27 siblings, 0 replies; 44+ messages in thread
From: Daniel Vetter @ 2016-05-30 17:53 UTC (permalink / raw)
To: DRI Development; +Cc: Daniel Vetter, Ben Skeggs, Daniel Vetter
No dev->struct_mutex anywhere to be seen.
Cc: Ben Skeggs <bskeggs@redhat.com>
Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
---
drivers/gpu/drm/nouveau/nouveau_drm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/nouveau/nouveau_drm.c b/drivers/gpu/drm/nouveau/nouveau_drm.c
index 11f8dd9c0edb..d17a969fbd51 100644
--- a/drivers/gpu/drm/nouveau/nouveau_drm.c
+++ b/drivers/gpu/drm/nouveau/nouveau_drm.c
@@ -970,7 +970,7 @@ driver_stub = {
.gem_prime_vmap = nouveau_gem_prime_vmap,
.gem_prime_vunmap = nouveau_gem_prime_vunmap,
- .gem_free_object = nouveau_gem_object_del,
+ .gem_free_object_unlocked = nouveau_gem_object_del,
.gem_open_object = nouveau_gem_object_open,
.gem_close_object = nouveau_gem_object_close,
--
2.8.1
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 44+ messages in thread* [PATCH 09/27] drm/qxl: Use lockless gem BO free callback
2016-05-30 17:52 [PATCH 00/27] locklesss gem BO free driver patches Daniel Vetter
` (7 preceding siblings ...)
2016-05-30 17:53 ` [PATCH 08/27] drm/nouveau: " Daniel Vetter
@ 2016-05-30 17:53 ` Daniel Vetter
2016-05-30 17:53 ` [PATCH 10/27] drm/rcar-du: " Daniel Vetter
` (18 subsequent siblings)
27 siblings, 0 replies; 44+ messages in thread
From: Daniel Vetter @ 2016-05-30 17:53 UTC (permalink / raw)
To: DRI Development; +Cc: Daniel Vetter, Daniel Vetter, Dave Airlie
No dev->struct_mutex anywhere to be seen.
Cc: Dave Airlie <airlied@redhat.com>
Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
---
drivers/gpu/drm/qxl/qxl_drv.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/qxl/qxl_drv.c b/drivers/gpu/drm/qxl/qxl_drv.c
index dc9df5fe50ba..460bbceae297 100644
--- a/drivers/gpu/drm/qxl/qxl_drv.c
+++ b/drivers/gpu/drm/qxl/qxl_drv.c
@@ -256,7 +256,7 @@ static struct drm_driver qxl_driver = {
.gem_prime_vmap = qxl_gem_prime_vmap,
.gem_prime_vunmap = qxl_gem_prime_vunmap,
.gem_prime_mmap = qxl_gem_prime_mmap,
- .gem_free_object = qxl_gem_object_free,
+ .gem_free_object_unlocked = qxl_gem_object_free,
.gem_open_object = qxl_gem_object_open,
.gem_close_object = qxl_gem_object_close,
.fops = &qxl_fops,
--
2.8.1
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 44+ messages in thread* [PATCH 10/27] drm/rcar-du: Use lockless gem BO free callback
2016-05-30 17:52 [PATCH 00/27] locklesss gem BO free driver patches Daniel Vetter
` (8 preceding siblings ...)
2016-05-30 17:53 ` [PATCH 09/27] drm/qxl: " Daniel Vetter
@ 2016-05-30 17:53 ` Daniel Vetter
2016-06-02 22:49 ` Laurent Pinchart
2016-05-30 17:53 ` [PATCH 11/27] drm/rockchip: " Daniel Vetter
` (17 subsequent siblings)
27 siblings, 1 reply; 44+ messages in thread
From: Daniel Vetter @ 2016-05-30 17:53 UTC (permalink / raw)
To: DRI Development; +Cc: Daniel Vetter, Laurent Pinchart, Daniel Vetter
No dev->struct_mutex anywhere to be seen.
Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
---
drivers/gpu/drm/rcar-du/rcar_du_drv.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/rcar-du/rcar_du_drv.c b/drivers/gpu/drm/rcar-du/rcar_du_drv.c
index fb9242d27883..48ec4b6e8b26 100644
--- a/drivers/gpu/drm/rcar-du/rcar_du_drv.c
+++ b/drivers/gpu/drm/rcar-du/rcar_du_drv.c
@@ -217,7 +217,7 @@ static struct drm_driver rcar_du_driver = {
.get_vblank_counter = drm_vblank_no_hw_counter,
.enable_vblank = rcar_du_enable_vblank,
.disable_vblank = rcar_du_disable_vblank,
- .gem_free_object = drm_gem_cma_free_object,
+ .gem_free_object_unlocked = drm_gem_cma_free_object,
.gem_vm_ops = &drm_gem_cma_vm_ops,
.prime_handle_to_fd = drm_gem_prime_handle_to_fd,
.prime_fd_to_handle = drm_gem_prime_fd_to_handle,
--
2.8.1
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 44+ messages in thread* Re: [PATCH 10/27] drm/rcar-du: Use lockless gem BO free callback
2016-05-30 17:53 ` [PATCH 10/27] drm/rcar-du: " Daniel Vetter
@ 2016-06-02 22:49 ` Laurent Pinchart
0 siblings, 0 replies; 44+ messages in thread
From: Laurent Pinchart @ 2016-06-02 22:49 UTC (permalink / raw)
To: Daniel Vetter; +Cc: Daniel Vetter, DRI Development
Hi Daniel,
Thank you for the patch.
On Monday 30 May 2016 19:53:02 Daniel Vetter wrote:
> No dev->struct_mutex anywhere to be seen.
>
> Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> drivers/gpu/drm/rcar-du/rcar_du_drv.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/rcar-du/rcar_du_drv.c
> b/drivers/gpu/drm/rcar-du/rcar_du_drv.c index fb9242d27883..48ec4b6e8b26
> 100644
> --- a/drivers/gpu/drm/rcar-du/rcar_du_drv.c
> +++ b/drivers/gpu/drm/rcar-du/rcar_du_drv.c
> @@ -217,7 +217,7 @@ static struct drm_driver rcar_du_driver = {
> .get_vblank_counter = drm_vblank_no_hw_counter,
> .enable_vblank = rcar_du_enable_vblank,
> .disable_vblank = rcar_du_disable_vblank,
> - .gem_free_object = drm_gem_cma_free_object,
> + .gem_free_object_unlocked = drm_gem_cma_free_object,
> .gem_vm_ops = &drm_gem_cma_vm_ops,
> .prime_handle_to_fd = drm_gem_prime_handle_to_fd,
> .prime_fd_to_handle = drm_gem_prime_fd_to_handle,
--
Regards,
Laurent Pinchart
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 44+ messages in thread
* [PATCH 11/27] drm/rockchip: Use lockless gem BO free callback
2016-05-30 17:52 [PATCH 00/27] locklesss gem BO free driver patches Daniel Vetter
` (9 preceding siblings ...)
2016-05-30 17:53 ` [PATCH 10/27] drm/rcar-du: " Daniel Vetter
@ 2016-05-30 17:53 ` Daniel Vetter
2016-05-30 17:53 ` [PATCH 12/27] drm/shmob: " Daniel Vetter
` (16 subsequent siblings)
27 siblings, 0 replies; 44+ messages in thread
From: Daniel Vetter @ 2016-05-30 17:53 UTC (permalink / raw)
To: DRI Development; +Cc: Daniel Vetter, Daniel Vetter
No dev->struct_mutex anywhere to be seen.
Cc: Mark Yao <mark.yao@rock-chips.com>
Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
---
drivers/gpu/drm/rockchip/rockchip_drm_drv.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_drv.c b/drivers/gpu/drm/rockchip/rockchip_drm_drv.c
index a409d1f703cb..b0779261721f 100644
--- a/drivers/gpu/drm/rockchip/rockchip_drm_drv.c
+++ b/drivers/gpu/drm/rockchip/rockchip_drm_drv.c
@@ -316,7 +316,7 @@ static struct drm_driver rockchip_drm_driver = {
.enable_vblank = rockchip_drm_crtc_enable_vblank,
.disable_vblank = rockchip_drm_crtc_disable_vblank,
.gem_vm_ops = &rockchip_drm_vm_ops,
- .gem_free_object = rockchip_gem_free_object,
+ .gem_free_object_unlocked = rockchip_gem_free_object,
.dumb_create = rockchip_gem_dumb_create,
.dumb_map_offset = rockchip_gem_dumb_map_offset,
.dumb_destroy = drm_gem_dumb_destroy,
--
2.8.1
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 44+ messages in thread* [PATCH 12/27] drm/shmob: Use lockless gem BO free callback
2016-05-30 17:52 [PATCH 00/27] locklesss gem BO free driver patches Daniel Vetter
` (10 preceding siblings ...)
2016-05-30 17:53 ` [PATCH 11/27] drm/rockchip: " Daniel Vetter
@ 2016-05-30 17:53 ` Daniel Vetter
2016-06-02 22:50 ` Laurent Pinchart
2016-05-30 17:53 ` [PATCH 13/27] drm/tilcdc: " Daniel Vetter
` (15 subsequent siblings)
27 siblings, 1 reply; 44+ messages in thread
From: Daniel Vetter @ 2016-05-30 17:53 UTC (permalink / raw)
To: DRI Development; +Cc: Daniel Vetter, Laurent Pinchart, Daniel Vetter
No dev->struct_mutex anywhere to be seen.
Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
---
drivers/gpu/drm/shmobile/shmob_drm_drv.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/shmobile/shmob_drm_drv.c b/drivers/gpu/drm/shmobile/shmob_drm_drv.c
index 7700ff172079..ee79264b5b6a 100644
--- a/drivers/gpu/drm/shmobile/shmob_drm_drv.c
+++ b/drivers/gpu/drm/shmobile/shmob_drm_drv.c
@@ -264,7 +264,7 @@ static struct drm_driver shmob_drm_driver = {
.get_vblank_counter = drm_vblank_no_hw_counter,
.enable_vblank = shmob_drm_enable_vblank,
.disable_vblank = shmob_drm_disable_vblank,
- .gem_free_object = drm_gem_cma_free_object,
+ .gem_free_object_unlocked = drm_gem_cma_free_object,
.gem_vm_ops = &drm_gem_cma_vm_ops,
.prime_handle_to_fd = drm_gem_prime_handle_to_fd,
.prime_fd_to_handle = drm_gem_prime_fd_to_handle,
--
2.8.1
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 44+ messages in thread* Re: [PATCH 12/27] drm/shmob: Use lockless gem BO free callback
2016-05-30 17:53 ` [PATCH 12/27] drm/shmob: " Daniel Vetter
@ 2016-06-02 22:50 ` Laurent Pinchart
0 siblings, 0 replies; 44+ messages in thread
From: Laurent Pinchart @ 2016-06-02 22:50 UTC (permalink / raw)
To: Daniel Vetter; +Cc: Daniel Vetter, DRI Development
Hi Daniel,
Thank you for the patch.
On Monday 30 May 2016 19:53:04 Daniel Vetter wrote:
> No dev->struct_mutex anywhere to be seen.
>
> Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> drivers/gpu/drm/shmobile/shmob_drm_drv.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/shmobile/shmob_drm_drv.c
> b/drivers/gpu/drm/shmobile/shmob_drm_drv.c index 7700ff172079..ee79264b5b6a
> 100644
> --- a/drivers/gpu/drm/shmobile/shmob_drm_drv.c
> +++ b/drivers/gpu/drm/shmobile/shmob_drm_drv.c
> @@ -264,7 +264,7 @@ static struct drm_driver shmob_drm_driver = {
> .get_vblank_counter = drm_vblank_no_hw_counter,
> .enable_vblank = shmob_drm_enable_vblank,
> .disable_vblank = shmob_drm_disable_vblank,
> - .gem_free_object = drm_gem_cma_free_object,
> + .gem_free_object_unlocked = drm_gem_cma_free_object,
> .gem_vm_ops = &drm_gem_cma_vm_ops,
> .prime_handle_to_fd = drm_gem_prime_handle_to_fd,
> .prime_fd_to_handle = drm_gem_prime_fd_to_handle,
--
Regards,
Laurent Pinchart
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 44+ messages in thread
* [PATCH 13/27] drm/tilcdc: Use lockless gem BO free callback
2016-05-30 17:52 [PATCH 00/27] locklesss gem BO free driver patches Daniel Vetter
` (11 preceding siblings ...)
2016-05-30 17:53 ` [PATCH 12/27] drm/shmob: " Daniel Vetter
@ 2016-05-30 17:53 ` Daniel Vetter
2016-05-30 17:53 ` [PATCH 14/27] drm/vc4: Use drm_gem_object_unreference_unlocked Daniel Vetter
` (14 subsequent siblings)
27 siblings, 0 replies; 44+ messages in thread
From: Daniel Vetter @ 2016-05-30 17:53 UTC (permalink / raw)
To: DRI Development; +Cc: Daniel Vetter, Tomi Valkeinen, Daniel Vetter
No dev->struct_mutex anywhere to be seen.
Cc: Tomi Valkeinen <tomi.valkeinen@ti.com>
Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
---
drivers/gpu/drm/tilcdc/tilcdc_drv.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/tilcdc/tilcdc_drv.c b/drivers/gpu/drm/tilcdc/tilcdc_drv.c
index 709bc903524d..308e197908fc 100644
--- a/drivers/gpu/drm/tilcdc/tilcdc_drv.c
+++ b/drivers/gpu/drm/tilcdc/tilcdc_drv.c
@@ -549,7 +549,7 @@ static struct drm_driver tilcdc_driver = {
.get_vblank_counter = drm_vblank_no_hw_counter,
.enable_vblank = tilcdc_enable_vblank,
.disable_vblank = tilcdc_disable_vblank,
- .gem_free_object = drm_gem_cma_free_object,
+ .gem_free_object_unlocked = drm_gem_cma_free_object,
.gem_vm_ops = &drm_gem_cma_vm_ops,
.dumb_create = drm_gem_cma_dumb_create,
.dumb_map_offset = drm_gem_cma_dumb_map_offset,
--
2.8.1
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 44+ messages in thread* [PATCH 14/27] drm/vc4: Use drm_gem_object_unreference_unlocked
2016-05-30 17:52 [PATCH 00/27] locklesss gem BO free driver patches Daniel Vetter
` (12 preceding siblings ...)
2016-05-30 17:53 ` [PATCH 13/27] drm/tilcdc: " Daniel Vetter
@ 2016-05-30 17:53 ` Daniel Vetter
2016-05-30 17:53 ` [PATCH 15/27] drm/vc4: Use lockless gem BO free callback Daniel Vetter
` (13 subsequent siblings)
27 siblings, 0 replies; 44+ messages in thread
From: Daniel Vetter @ 2016-05-30 17:53 UTC (permalink / raw)
To: DRI Development; +Cc: Daniel Vetter, Daniel Vetter
Since my last struct_mutex crusade someone escaped!
This already has the advantage that for the common case when someone
else holds a ref the unref won't even acquire dev->struct_mutex. And
I'm working on code to allow drivers to completely opt-out of any and
all dev->struct_mutex usage, but that only works if they use the
_unlocked variants everywhere.
v2: Drop comment too.
v3: Drop the other comment too.
Cc: Eric Anholt <eric@anholt.net>
Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
---
drivers/gpu/drm/vc4/vc4_bo.c | 2 --
drivers/gpu/drm/vc4/vc4_gem.c | 11 +++--------
2 files changed, 3 insertions(+), 10 deletions(-)
diff --git a/drivers/gpu/drm/vc4/vc4_bo.c b/drivers/gpu/drm/vc4/vc4_bo.c
index e5a9d3aaf45f..59adcf8532dd 100644
--- a/drivers/gpu/drm/vc4/vc4_bo.c
+++ b/drivers/gpu/drm/vc4/vc4_bo.c
@@ -291,8 +291,6 @@ static void vc4_bo_cache_free_old(struct drm_device *dev)
/* Called on the last userspace/kernel unreference of the BO. Returns
* it to the BO cache if possible, otherwise frees it.
- *
- * Note that this is called with the struct_mutex held.
*/
void vc4_free_object(struct drm_gem_object *gem_bo)
{
diff --git a/drivers/gpu/drm/vc4/vc4_gem.c b/drivers/gpu/drm/vc4/vc4_gem.c
index 46899d6de675..6155e8aca1c6 100644
--- a/drivers/gpu/drm/vc4/vc4_gem.c
+++ b/drivers/gpu/drm/vc4/vc4_gem.c
@@ -53,10 +53,8 @@ vc4_free_hang_state(struct drm_device *dev, struct vc4_hang_state *state)
{
unsigned int i;
- mutex_lock(&dev->struct_mutex);
for (i = 0; i < state->user_state.bo_count; i++)
- drm_gem_object_unreference(state->bo[i]);
- mutex_unlock(&dev->struct_mutex);
+ drm_gem_object_unreference_unlocked(state->bo[i]);
kfree(state);
}
@@ -687,11 +685,9 @@ vc4_complete_exec(struct drm_device *dev, struct vc4_exec_info *exec)
struct vc4_dev *vc4 = to_vc4_dev(dev);
unsigned i;
- /* Need the struct lock for drm_gem_object_unreference(). */
- mutex_lock(&dev->struct_mutex);
if (exec->bo) {
for (i = 0; i < exec->bo_count; i++)
- drm_gem_object_unreference(&exec->bo[i]->base);
+ drm_gem_object_unreference_unlocked(&exec->bo[i]->base);
kfree(exec->bo);
}
@@ -699,9 +695,8 @@ vc4_complete_exec(struct drm_device *dev, struct vc4_exec_info *exec)
struct vc4_bo *bo = list_first_entry(&exec->unref_list,
struct vc4_bo, unref_head);
list_del(&bo->unref_head);
- drm_gem_object_unreference(&bo->base.base);
+ drm_gem_object_unreference_unlocked(&bo->base.base);
}
- mutex_unlock(&dev->struct_mutex);
mutex_lock(&vc4->power_lock);
if (--vc4->power_refcount == 0)
--
2.8.1
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 44+ messages in thread* [PATCH 15/27] drm/vc4: Use lockless gem BO free callback
2016-05-30 17:52 [PATCH 00/27] locklesss gem BO free driver patches Daniel Vetter
` (13 preceding siblings ...)
2016-05-30 17:53 ` [PATCH 14/27] drm/vc4: Use drm_gem_object_unreference_unlocked Daniel Vetter
@ 2016-05-30 17:53 ` Daniel Vetter
2016-05-31 17:23 ` Eric Anholt
2016-05-30 17:53 ` [PATCH 16/27] drm/vgem: " Daniel Vetter
` (12 subsequent siblings)
27 siblings, 1 reply; 44+ messages in thread
From: Daniel Vetter @ 2016-05-30 17:53 UTC (permalink / raw)
To: DRI Development; +Cc: Daniel Vetter, Daniel Vetter
No dev->struct_mutex anywhere to be seen.
Cc: Eric Anholt <eric@anholt.net>
Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
---
drivers/gpu/drm/vc4/vc4_drv.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/vc4/vc4_drv.c b/drivers/gpu/drm/vc4/vc4_drv.c
index 143dd98aa079..b662d0492471 100644
--- a/drivers/gpu/drm/vc4/vc4_drv.c
+++ b/drivers/gpu/drm/vc4/vc4_drv.c
@@ -99,7 +99,7 @@ static struct drm_driver vc4_drm_driver = {
#endif
.gem_create_object = vc4_create_object,
- .gem_free_object = vc4_free_object,
+ .gem_free_object_unlocked = vc4_free_object,
.gem_vm_ops = &drm_gem_cma_vm_ops,
.prime_handle_to_fd = drm_gem_prime_handle_to_fd,
--
2.8.1
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 44+ messages in thread* [PATCH 16/27] drm/vgem: Use lockless gem BO free callback
2016-05-30 17:52 [PATCH 00/27] locklesss gem BO free driver patches Daniel Vetter
` (14 preceding siblings ...)
2016-05-30 17:53 ` [PATCH 15/27] drm/vc4: Use lockless gem BO free callback Daniel Vetter
@ 2016-05-30 17:53 ` Daniel Vetter
2016-05-31 13:20 ` Sean Paul
2016-05-30 17:53 ` [PATCH 17/27] drm/virtio: " Daniel Vetter
` (11 subsequent siblings)
27 siblings, 1 reply; 44+ messages in thread
From: Daniel Vetter @ 2016-05-30 17:53 UTC (permalink / raw)
To: DRI Development; +Cc: Daniel Vetter, Daniel Vetter
No dev->struct_mutex anywhere to be seen.
Cc: seanpaul@chromium.org
Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
---
drivers/gpu/drm/vgem/vgem_drv.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/vgem/vgem_drv.c b/drivers/gpu/drm/vgem/vgem_drv.c
index 341f9be3dde6..1b4cc8b27080 100644
--- a/drivers/gpu/drm/vgem/vgem_drv.c
+++ b/drivers/gpu/drm/vgem/vgem_drv.c
@@ -235,7 +235,7 @@ static const struct file_operations vgem_driver_fops = {
static struct drm_driver vgem_driver = {
.driver_features = DRIVER_GEM,
- .gem_free_object = vgem_gem_free_object,
+ .gem_free_object_unlocked = vgem_gem_free_object,
.gem_vm_ops = &vgem_gem_vm_ops,
.ioctls = vgem_ioctls,
.fops = &vgem_driver_fops,
--
2.8.1
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 44+ messages in thread* Re: [PATCH 16/27] drm/vgem: Use lockless gem BO free callback
2016-05-30 17:53 ` [PATCH 16/27] drm/vgem: " Daniel Vetter
@ 2016-05-31 13:20 ` Sean Paul
2016-05-31 13:29 ` Daniel Vetter
0 siblings, 1 reply; 44+ messages in thread
From: Sean Paul @ 2016-05-31 13:20 UTC (permalink / raw)
To: Daniel Vetter; +Cc: Daniel Vetter, Zach Reizner, DRI Development
On Mon, May 30, 2016 at 1:53 PM, Daniel Vetter <daniel.vetter@ffwll.ch> wrote:
> No dev->struct_mutex anywhere to be seen.
>
> Cc: seanpaul@chromium.org
> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
Reviewed-by: Sean Paul <seanpaul@chromium.org>
> ---
> drivers/gpu/drm/vgem/vgem_drv.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/vgem/vgem_drv.c b/drivers/gpu/drm/vgem/vgem_drv.c
> index 341f9be3dde6..1b4cc8b27080 100644
> --- a/drivers/gpu/drm/vgem/vgem_drv.c
> +++ b/drivers/gpu/drm/vgem/vgem_drv.c
> @@ -235,7 +235,7 @@ static const struct file_operations vgem_driver_fops = {
>
> static struct drm_driver vgem_driver = {
> .driver_features = DRIVER_GEM,
> - .gem_free_object = vgem_gem_free_object,
> + .gem_free_object_unlocked = vgem_gem_free_object,
> .gem_vm_ops = &vgem_gem_vm_ops,
> .ioctls = vgem_ioctls,
> .fops = &vgem_driver_fops,
> --
> 2.8.1
>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 44+ messages in thread* Re: [PATCH 16/27] drm/vgem: Use lockless gem BO free callback
2016-05-31 13:20 ` Sean Paul
@ 2016-05-31 13:29 ` Daniel Vetter
0 siblings, 0 replies; 44+ messages in thread
From: Daniel Vetter @ 2016-05-31 13:29 UTC (permalink / raw)
To: Sean Paul; +Cc: Daniel Vetter, Zach Reizner, DRI Development, Daniel Vetter
On Tue, May 31, 2016 at 09:20:07AM -0400, Sean Paul wrote:
> On Mon, May 30, 2016 at 1:53 PM, Daniel Vetter <daniel.vetter@ffwll.ch> wrote:
> > No dev->struct_mutex anywhere to be seen.
> >
> > Cc: seanpaul@chromium.org
> > Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
>
> Reviewed-by: Sean Paul <seanpaul@chromium.org>
Applied to drm-misc, thanks for the review.
-Daniel
>
> > ---
> > drivers/gpu/drm/vgem/vgem_drv.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/vgem/vgem_drv.c b/drivers/gpu/drm/vgem/vgem_drv.c
> > index 341f9be3dde6..1b4cc8b27080 100644
> > --- a/drivers/gpu/drm/vgem/vgem_drv.c
> > +++ b/drivers/gpu/drm/vgem/vgem_drv.c
> > @@ -235,7 +235,7 @@ static const struct file_operations vgem_driver_fops = {
> >
> > static struct drm_driver vgem_driver = {
> > .driver_features = DRIVER_GEM,
> > - .gem_free_object = vgem_gem_free_object,
> > + .gem_free_object_unlocked = vgem_gem_free_object,
> > .gem_vm_ops = &vgem_gem_vm_ops,
> > .ioctls = vgem_ioctls,
> > .fops = &vgem_driver_fops,
> > --
> > 2.8.1
> >
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 44+ messages in thread
* [PATCH 17/27] drm/virtio: Use lockless gem BO free callback
2016-05-30 17:52 [PATCH 00/27] locklesss gem BO free driver patches Daniel Vetter
` (15 preceding siblings ...)
2016-05-30 17:53 ` [PATCH 16/27] drm/vgem: " Daniel Vetter
@ 2016-05-30 17:53 ` Daniel Vetter
2016-05-30 17:53 ` [PATCH 18/27] drm: sti: remove useless call to dev->struct_mutex Daniel Vetter
` (10 subsequent siblings)
27 siblings, 0 replies; 44+ messages in thread
From: Daniel Vetter @ 2016-05-30 17:53 UTC (permalink / raw)
To: DRI Development; +Cc: Daniel Vetter, Daniel Vetter
No dev->struct_mutex anywhere to be seen.
Cc: Gerd Hoffmann <kraxel@redhat.com>
Cc: David Airlie <airlied@linux.ie>
Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
---
drivers/gpu/drm/virtio/virtgpu_drv.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/virtio/virtgpu_drv.c b/drivers/gpu/drm/virtio/virtgpu_drv.c
index 3cc7afa77a35..5820b7020ae5 100644
--- a/drivers/gpu/drm/virtio/virtgpu_drv.c
+++ b/drivers/gpu/drm/virtio/virtgpu_drv.c
@@ -143,7 +143,7 @@ static struct drm_driver driver = {
.gem_prime_vunmap = virtgpu_gem_prime_vunmap,
.gem_prime_mmap = virtgpu_gem_prime_mmap,
- .gem_free_object = virtio_gpu_gem_free_object,
+ .gem_free_object_unlocked = virtio_gpu_gem_free_object,
.gem_open_object = virtio_gpu_gem_object_open,
.gem_close_object = virtio_gpu_gem_object_close,
.fops = &virtio_gpu_driver_fops,
--
2.8.1
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 44+ messages in thread* [PATCH 18/27] drm: sti: remove useless call to dev->struct_mutex
2016-05-30 17:52 [PATCH 00/27] locklesss gem BO free driver patches Daniel Vetter
` (16 preceding siblings ...)
2016-05-30 17:53 ` [PATCH 17/27] drm/virtio: " Daniel Vetter
@ 2016-05-30 17:53 ` Daniel Vetter
2016-05-30 17:53 ` [PATCH 19/27] drm/virtio: Use lockless gem BO free callback Daniel Vetter
` (9 subsequent siblings)
27 siblings, 0 replies; 44+ messages in thread
From: Daniel Vetter @ 2016-05-30 17:53 UTC (permalink / raw)
To: DRI Development; +Cc: Daniel Vetter
From: Benjamin Gaignard <benjamin.gaignard@linaro.org>
No need to protect debugfs functions with dev->struct_mutex
Signed-off-by: Benjamin Gaignard <benjamin.gaignard@linaro.org>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
---
drivers/gpu/drm/sti/sti_cursor.c | 7 -------
drivers/gpu/drm/sti/sti_drv.c | 6 ------
drivers/gpu/drm/sti/sti_dvo.c | 7 -------
drivers/gpu/drm/sti/sti_gdp.c | 14 --------------
drivers/gpu/drm/sti/sti_hda.c | 7 -------
drivers/gpu/drm/sti/sti_hdmi.c | 7 -------
drivers/gpu/drm/sti/sti_hqvdp.c | 7 -------
drivers/gpu/drm/sti/sti_mixer.c | 7 -------
drivers/gpu/drm/sti/sti_tvout.c | 7 -------
drivers/gpu/drm/sti/sti_vid.c | 7 -------
10 files changed, 76 deletions(-)
diff --git a/drivers/gpu/drm/sti/sti_cursor.c b/drivers/gpu/drm/sti/sti_cursor.c
index 4e990299735c..53aa0029295b 100644
--- a/drivers/gpu/drm/sti/sti_cursor.c
+++ b/drivers/gpu/drm/sti/sti_cursor.c
@@ -105,12 +105,6 @@ static int cursor_dbg_show(struct seq_file *s, void *data)
{
struct drm_info_node *node = s->private;
struct sti_cursor *cursor = (struct sti_cursor *)node->info_ent->data;
- struct drm_device *dev = node->minor->dev;
- int ret;
-
- ret = mutex_lock_interruptible(&dev->struct_mutex);
- if (ret)
- return ret;
seq_printf(s, "%s: (vaddr = 0x%p)",
sti_plane_to_str(&cursor->plane), cursor->regs);
@@ -129,7 +123,6 @@ static int cursor_dbg_show(struct seq_file *s, void *data)
DBGFS_DUMP(CUR_AWE);
seq_puts(s, "\n");
- mutex_unlock(&dev->struct_mutex);
return 0;
}
diff --git a/drivers/gpu/drm/sti/sti_drv.c b/drivers/gpu/drm/sti/sti_drv.c
index 872495e72294..1b8dd9e7829d 100644
--- a/drivers/gpu/drm/sti/sti_drv.c
+++ b/drivers/gpu/drm/sti/sti_drv.c
@@ -72,11 +72,6 @@ static int sti_drm_fps_dbg_show(struct seq_file *s, void *data)
struct drm_info_node *node = s->private;
struct drm_device *dev = node->minor->dev;
struct drm_plane *p;
- int ret;
-
- ret = mutex_lock_interruptible(&dev->struct_mutex);
- if (ret)
- return ret;
list_for_each_entry(p, &dev->mode_config.plane_list, head) {
struct sti_plane *plane = to_sti_plane(p);
@@ -86,7 +81,6 @@ static int sti_drm_fps_dbg_show(struct seq_file *s, void *data)
plane->fps_info.fips_str);
}
- mutex_unlock(&dev->struct_mutex);
return 0;
}
diff --git a/drivers/gpu/drm/sti/sti_dvo.c b/drivers/gpu/drm/sti/sti_dvo.c
index 25f76632002c..d439128e6309 100644
--- a/drivers/gpu/drm/sti/sti_dvo.c
+++ b/drivers/gpu/drm/sti/sti_dvo.c
@@ -177,12 +177,6 @@ static int dvo_dbg_show(struct seq_file *s, void *data)
{
struct drm_info_node *node = s->private;
struct sti_dvo *dvo = (struct sti_dvo *)node->info_ent->data;
- struct drm_device *dev = node->minor->dev;
- int ret;
-
- ret = mutex_lock_interruptible(&dev->struct_mutex);
- if (ret)
- return ret;
seq_printf(s, "DVO: (vaddr = 0x%p)", dvo->regs);
DBGFS_DUMP(DVO_AWG_DIGSYNC_CTRL);
@@ -193,7 +187,6 @@ static int dvo_dbg_show(struct seq_file *s, void *data)
dvo_dbg_awg_microcode(s, dvo->regs + DVO_DIGSYNC_INSTR_I);
seq_puts(s, "\n");
- mutex_unlock(&dev->struct_mutex);
return 0;
}
diff --git a/drivers/gpu/drm/sti/sti_gdp.c b/drivers/gpu/drm/sti/sti_gdp.c
index ff33c38da197..fdf69b5a041b 100644
--- a/drivers/gpu/drm/sti/sti_gdp.c
+++ b/drivers/gpu/drm/sti/sti_gdp.c
@@ -208,14 +208,8 @@ static int gdp_dbg_show(struct seq_file *s, void *data)
{
struct drm_info_node *node = s->private;
struct sti_gdp *gdp = (struct sti_gdp *)node->info_ent->data;
- struct drm_device *dev = node->minor->dev;
struct drm_plane *drm_plane = &gdp->plane.drm_plane;
struct drm_crtc *crtc = drm_plane->crtc;
- int ret;
-
- ret = mutex_lock_interruptible(&dev->struct_mutex);
- if (ret)
- return ret;
seq_printf(s, "%s: (vaddr = 0x%p)",
sti_plane_to_str(&gdp->plane), gdp->regs);
@@ -248,7 +242,6 @@ static int gdp_dbg_show(struct seq_file *s, void *data)
seq_printf(s, " Connected to DRM CRTC #%d (%s)\n",
crtc->base.id, sti_mixer_to_str(to_sti_mixer(crtc)));
- mutex_unlock(&dev->struct_mutex);
return 0;
}
@@ -279,13 +272,7 @@ static int gdp_node_dbg_show(struct seq_file *s, void *arg)
{
struct drm_info_node *node = s->private;
struct sti_gdp *gdp = (struct sti_gdp *)node->info_ent->data;
- struct drm_device *dev = node->minor->dev;
unsigned int b;
- int ret;
-
- ret = mutex_lock_interruptible(&dev->struct_mutex);
- if (ret)
- return ret;
for (b = 0; b < GDP_NODE_NB_BANK; b++) {
seq_printf(s, "\n%s[%d].top", sti_plane_to_str(&gdp->plane), b);
@@ -294,7 +281,6 @@ static int gdp_node_dbg_show(struct seq_file *s, void *arg)
gdp_node_dump_node(s, gdp->node_list[b].btm_field);
}
- mutex_unlock(&dev->struct_mutex);
return 0;
}
diff --git a/drivers/gpu/drm/sti/sti_hda.c b/drivers/gpu/drm/sti/sti_hda.c
index f7d3464cdf09..9f49c00f1a02 100644
--- a/drivers/gpu/drm/sti/sti_hda.c
+++ b/drivers/gpu/drm/sti/sti_hda.c
@@ -376,12 +376,6 @@ static int hda_dbg_show(struct seq_file *s, void *data)
{
struct drm_info_node *node = s->private;
struct sti_hda *hda = (struct sti_hda *)node->info_ent->data;
- struct drm_device *dev = node->minor->dev;
- int ret;
-
- ret = mutex_lock_interruptible(&dev->struct_mutex);
- if (ret)
- return ret;
seq_printf(s, "HD Analog: (vaddr = 0x%p)", hda->regs);
DBGFS_DUMP(HDA_ANA_CFG);
@@ -397,7 +391,6 @@ static int hda_dbg_show(struct seq_file *s, void *data)
hda_dbg_video_dacs_ctrl(s, hda->video_dacs_ctrl);
seq_puts(s, "\n");
- mutex_unlock(&dev->struct_mutex);
return 0;
}
diff --git a/drivers/gpu/drm/sti/sti_hdmi.c b/drivers/gpu/drm/sti/sti_hdmi.c
index 6ef0715bd5b9..85545ebf88d3 100644
--- a/drivers/gpu/drm/sti/sti_hdmi.c
+++ b/drivers/gpu/drm/sti/sti_hdmi.c
@@ -628,12 +628,6 @@ static int hdmi_dbg_show(struct seq_file *s, void *data)
{
struct drm_info_node *node = s->private;
struct sti_hdmi *hdmi = (struct sti_hdmi *)node->info_ent->data;
- struct drm_device *dev = node->minor->dev;
- int ret;
-
- ret = mutex_lock_interruptible(&dev->struct_mutex);
- if (ret)
- return ret;
seq_printf(s, "HDMI: (vaddr = 0x%p)", hdmi->regs);
DBGFS_DUMP("\n", HDMI_CFG);
@@ -690,7 +684,6 @@ static int hdmi_dbg_show(struct seq_file *s, void *data)
DBGFS_DUMP_DI(HDMI_SW_DI_N_PKT_WORD6, HDMI_IFRAME_SLOT_VENDOR);
seq_puts(s, "\n");
- mutex_unlock(&dev->struct_mutex);
return 0;
}
diff --git a/drivers/gpu/drm/sti/sti_hqvdp.c b/drivers/gpu/drm/sti/sti_hqvdp.c
index 1edec29b9e45..1c06a50fddca 100644
--- a/drivers/gpu/drm/sti/sti_hqvdp.c
+++ b/drivers/gpu/drm/sti/sti_hqvdp.c
@@ -555,14 +555,8 @@ static int hqvdp_dbg_show(struct seq_file *s, void *data)
{
struct drm_info_node *node = s->private;
struct sti_hqvdp *hqvdp = (struct sti_hqvdp *)node->info_ent->data;
- struct drm_device *dev = node->minor->dev;
int cmd, cmd_offset, infoxp70;
void *virt;
- int ret;
-
- ret = mutex_lock_interruptible(&dev->struct_mutex);
- if (ret)
- return ret;
seq_printf(s, "%s: (vaddr = 0x%p)",
sti_plane_to_str(&hqvdp->plane), hqvdp->regs);
@@ -630,7 +624,6 @@ static int hqvdp_dbg_show(struct seq_file *s, void *data)
seq_puts(s, "\n");
- mutex_unlock(&dev->struct_mutex);
return 0;
}
diff --git a/drivers/gpu/drm/sti/sti_mixer.c b/drivers/gpu/drm/sti/sti_mixer.c
index aed7801b51f7..6f86f2b2b6a5 100644
--- a/drivers/gpu/drm/sti/sti_mixer.c
+++ b/drivers/gpu/drm/sti/sti_mixer.c
@@ -151,12 +151,6 @@ static int mixer_dbg_show(struct seq_file *s, void *arg)
{
struct drm_info_node *node = s->private;
struct sti_mixer *mixer = (struct sti_mixer *)node->info_ent->data;
- struct drm_device *dev = node->minor->dev;
- int ret;
-
- ret = mutex_lock_interruptible(&dev->struct_mutex);
- if (ret)
- return ret;
seq_printf(s, "%s: (vaddr = 0x%p)",
sti_mixer_to_str(mixer), mixer->regs);
@@ -176,7 +170,6 @@ static int mixer_dbg_show(struct seq_file *s, void *arg)
mixer_dbg_mxn(s, mixer->regs + GAM_MIXER_MX0);
seq_puts(s, "\n");
- mutex_unlock(&dev->struct_mutex);
return 0;
}
diff --git a/drivers/gpu/drm/sti/sti_tvout.c b/drivers/gpu/drm/sti/sti_tvout.c
index f983db5a59da..60fe0afa5644 100644
--- a/drivers/gpu/drm/sti/sti_tvout.c
+++ b/drivers/gpu/drm/sti/sti_tvout.c
@@ -515,13 +515,7 @@ static int tvout_dbg_show(struct seq_file *s, void *data)
{
struct drm_info_node *node = s->private;
struct sti_tvout *tvout = (struct sti_tvout *)node->info_ent->data;
- struct drm_device *dev = node->minor->dev;
struct drm_crtc *crtc;
- int ret;
-
- ret = mutex_lock_interruptible(&dev->struct_mutex);
- if (ret)
- return ret;
seq_printf(s, "TVOUT: (vaddr = 0x%p)", tvout->regs);
@@ -587,7 +581,6 @@ static int tvout_dbg_show(struct seq_file *s, void *data)
DBGFS_DUMP(TVO_AUX_IN_VID_FORMAT);
seq_puts(s, "\n");
- mutex_unlock(&dev->struct_mutex);
return 0;
}
diff --git a/drivers/gpu/drm/sti/sti_vid.c b/drivers/gpu/drm/sti/sti_vid.c
index 523ed19f5ac6..0132aaebe598 100644
--- a/drivers/gpu/drm/sti/sti_vid.c
+++ b/drivers/gpu/drm/sti/sti_vid.c
@@ -92,12 +92,6 @@ static int vid_dbg_show(struct seq_file *s, void *arg)
{
struct drm_info_node *node = s->private;
struct sti_vid *vid = (struct sti_vid *)node->info_ent->data;
- struct drm_device *dev = node->minor->dev;
- int ret;
-
- ret = mutex_lock_interruptible(&dev->struct_mutex);
- if (ret)
- return ret;
seq_printf(s, "VID: (vaddr= 0x%p)", vid->regs);
@@ -122,7 +116,6 @@ static int vid_dbg_show(struct seq_file *s, void *arg)
DBGFS_DUMP(VID_CSAT);
seq_puts(s, "\n");
- mutex_unlock(&dev->struct_mutex);
return 0;
}
--
2.8.1
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 44+ messages in thread* [PATCH 19/27] drm/virtio: Use lockless gem BO free callback
2016-05-30 17:52 [PATCH 00/27] locklesss gem BO free driver patches Daniel Vetter
` (17 preceding siblings ...)
2016-05-30 17:53 ` [PATCH 18/27] drm: sti: remove useless call to dev->struct_mutex Daniel Vetter
@ 2016-05-30 17:53 ` Daniel Vetter
2016-05-30 17:53 ` [PATCH 20/27] drm/rockchip: Use cma gem vm ops Daniel Vetter
` (8 subsequent siblings)
27 siblings, 0 replies; 44+ messages in thread
From: Daniel Vetter @ 2016-05-30 17:53 UTC (permalink / raw)
To: DRI Development; +Cc: Daniel Vetter, Daniel Vetter
With Benjanim's patch to remove the dev->struct_mutex cargo cult the
sti driver is now also entirely legacy locking free. Let's convert it
too.
Cc: Benjamin Gaignard <benjamin.gaignard@linaro.org>
Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
---
drivers/gpu/drm/sti/sti_drv.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/sti/sti_drv.c b/drivers/gpu/drm/sti/sti_drv.c
index 1b8dd9e7829d..b440617a7019 100644
--- a/drivers/gpu/drm/sti/sti_drv.c
+++ b/drivers/gpu/drm/sti/sti_drv.c
@@ -304,7 +304,7 @@ static struct drm_driver sti_driver = {
.driver_features = DRIVER_HAVE_IRQ | DRIVER_MODESET |
DRIVER_GEM | DRIVER_PRIME | DRIVER_ATOMIC,
.load = sti_load,
- .gem_free_object = drm_gem_cma_free_object,
+ .gem_free_object_unlocked = drm_gem_cma_free_object,
.gem_vm_ops = &drm_gem_cma_vm_ops,
.dumb_create = drm_gem_cma_dumb_create,
.dumb_map_offset = drm_gem_cma_dumb_map_offset,
--
2.8.1
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 44+ messages in thread* [PATCH 20/27] drm/rockchip: Use cma gem vm ops
2016-05-30 17:52 [PATCH 00/27] locklesss gem BO free driver patches Daniel Vetter
` (18 preceding siblings ...)
2016-05-30 17:53 ` [PATCH 19/27] drm/virtio: Use lockless gem BO free callback Daniel Vetter
@ 2016-05-30 17:53 ` Daniel Vetter
2016-05-30 17:53 ` [PATCH 21/27] drm/msm: Nuke dummy fb->dirty callback Daniel Vetter
` (7 subsequent siblings)
27 siblings, 0 replies; 44+ messages in thread
From: Daniel Vetter @ 2016-05-30 17:53 UTC (permalink / raw)
To: DRI Development; +Cc: Daniel Vetter, Daniel Vetter
No need to reinvent this little wheel.
v2: Like, try to make it compile even.
Cc: Mark Yao <mark.yao@rock-chips.com>
Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
---
drivers/gpu/drm/rockchip/rockchip_drm_drv.c | 8 ++------
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_drv.c b/drivers/gpu/drm/rockchip/rockchip_drm_drv.c
index b0779261721f..09a4d429c0f0 100644
--- a/drivers/gpu/drm/rockchip/rockchip_drm_drv.c
+++ b/drivers/gpu/drm/rockchip/rockchip_drm_drv.c
@@ -19,6 +19,7 @@
#include <drm/drmP.h>
#include <drm/drm_crtc_helper.h>
#include <drm/drm_fb_helper.h>
+#include <drm/drm_gem_cma_helper.h>
#include <linux/dma-mapping.h>
#include <linux/pm_runtime.h>
#include <linux/module.h>
@@ -300,11 +301,6 @@ static const struct file_operations rockchip_drm_driver_fops = {
.release = drm_release,
};
-const struct vm_operations_struct rockchip_drm_vm_ops = {
- .open = drm_gem_vm_open,
- .close = drm_gem_vm_close,
-};
-
static struct drm_driver rockchip_drm_driver = {
.driver_features = DRIVER_MODESET | DRIVER_GEM |
DRIVER_PRIME | DRIVER_ATOMIC,
@@ -315,7 +311,7 @@ static struct drm_driver rockchip_drm_driver = {
.get_vblank_counter = drm_vblank_no_hw_counter,
.enable_vblank = rockchip_drm_crtc_enable_vblank,
.disable_vblank = rockchip_drm_crtc_disable_vblank,
- .gem_vm_ops = &rockchip_drm_vm_ops,
+ .gem_vm_ops = &drm_gem_cma_vm_ops,
.gem_free_object_unlocked = rockchip_gem_free_object,
.dumb_create = rockchip_gem_dumb_create,
.dumb_map_offset = rockchip_gem_dumb_map_offset,
--
2.8.1
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 44+ messages in thread* [PATCH 21/27] drm/msm: Nuke dummy fb->dirty callback
2016-05-30 17:52 [PATCH 00/27] locklesss gem BO free driver patches Daniel Vetter
` (19 preceding siblings ...)
2016-05-30 17:53 ` [PATCH 20/27] drm/rockchip: Use cma gem vm ops Daniel Vetter
@ 2016-05-30 17:53 ` Daniel Vetter
2016-05-30 17:53 ` [PATCH 22/27] drm/omapdrm: " Daniel Vetter
` (6 subsequent siblings)
27 siblings, 0 replies; 44+ messages in thread
From: Daniel Vetter @ 2016-05-30 17:53 UTC (permalink / raw)
To: DRI Development; +Cc: Daniel Vetter, Daniel Vetter
It's an optional hook.
Cc: Rob Clark <robdclark@gmail.com>
Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
---
drivers/gpu/drm/msm/msm_fb.c | 8 --------
1 file changed, 8 deletions(-)
diff --git a/drivers/gpu/drm/msm/msm_fb.c b/drivers/gpu/drm/msm/msm_fb.c
index 461dc8b873f0..7919c24c6ddd 100644
--- a/drivers/gpu/drm/msm/msm_fb.c
+++ b/drivers/gpu/drm/msm/msm_fb.c
@@ -56,17 +56,9 @@ static void msm_framebuffer_destroy(struct drm_framebuffer *fb)
kfree(msm_fb);
}
-static int msm_framebuffer_dirty(struct drm_framebuffer *fb,
- struct drm_file *file_priv, unsigned flags, unsigned color,
- struct drm_clip_rect *clips, unsigned num_clips)
-{
- return 0;
-}
-
static const struct drm_framebuffer_funcs msm_framebuffer_funcs = {
.create_handle = msm_framebuffer_create_handle,
.destroy = msm_framebuffer_destroy,
- .dirty = msm_framebuffer_dirty,
};
#ifdef CONFIG_DEBUG_FS
--
2.8.1
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 44+ messages in thread* [PATCH 22/27] drm/omapdrm: Nuke dummy fb->dirty callback
2016-05-30 17:52 [PATCH 00/27] locklesss gem BO free driver patches Daniel Vetter
` (20 preceding siblings ...)
2016-05-30 17:53 ` [PATCH 21/27] drm/msm: Nuke dummy fb->dirty callback Daniel Vetter
@ 2016-05-30 17:53 ` Daniel Vetter
2016-06-02 22:52 ` Laurent Pinchart
2016-05-30 17:53 ` [PATCH 23/27] drm/sun4i: Use lockless gem BO free callback Daniel Vetter
` (5 subsequent siblings)
27 siblings, 1 reply; 44+ messages in thread
From: Daniel Vetter @ 2016-05-30 17:53 UTC (permalink / raw)
To: DRI Development
Cc: Daniel Vetter, Tomi Valkeinen, Laurent Pinchart, Daniel Vetter
It's an optional hook.
Cc: Tomi Valkeinen <tomi.valkeinen@ti.com>
Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
---
drivers/gpu/drm/omapdrm/omap_fb.c | 8 --------
1 file changed, 8 deletions(-)
diff --git a/drivers/gpu/drm/omapdrm/omap_fb.c b/drivers/gpu/drm/omapdrm/omap_fb.c
index 94ec06d3d737..d639707f67db 100644
--- a/drivers/gpu/drm/omapdrm/omap_fb.c
+++ b/drivers/gpu/drm/omapdrm/omap_fb.c
@@ -120,17 +120,9 @@ static void omap_framebuffer_destroy(struct drm_framebuffer *fb)
kfree(omap_fb);
}
-static int omap_framebuffer_dirty(struct drm_framebuffer *fb,
- struct drm_file *file_priv, unsigned flags, unsigned color,
- struct drm_clip_rect *clips, unsigned num_clips)
-{
- return 0;
-}
-
static const struct drm_framebuffer_funcs omap_framebuffer_funcs = {
.create_handle = omap_framebuffer_create_handle,
.destroy = omap_framebuffer_destroy,
- .dirty = omap_framebuffer_dirty,
};
static uint32_t get_linear_addr(struct plane *plane,
--
2.8.1
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 44+ messages in thread* Re: [PATCH 22/27] drm/omapdrm: Nuke dummy fb->dirty callback
2016-05-30 17:53 ` [PATCH 22/27] drm/omapdrm: " Daniel Vetter
@ 2016-06-02 22:52 ` Laurent Pinchart
0 siblings, 0 replies; 44+ messages in thread
From: Laurent Pinchart @ 2016-06-02 22:52 UTC (permalink / raw)
To: Daniel Vetter; +Cc: Daniel Vetter, Tomi Valkeinen, DRI Development
Hi Daniel,
Thank you for the patch.
On Monday 30 May 2016 19:53:14 Daniel Vetter wrote:
> It's an optional hook.
>
> Cc: Tomi Valkeinen <tomi.valkeinen@ti.com>
> Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> drivers/gpu/drm/omapdrm/omap_fb.c | 8 --------
> 1 file changed, 8 deletions(-)
>
> diff --git a/drivers/gpu/drm/omapdrm/omap_fb.c
> b/drivers/gpu/drm/omapdrm/omap_fb.c index 94ec06d3d737..d639707f67db 100644
> --- a/drivers/gpu/drm/omapdrm/omap_fb.c
> +++ b/drivers/gpu/drm/omapdrm/omap_fb.c
> @@ -120,17 +120,9 @@ static void omap_framebuffer_destroy(struct
> drm_framebuffer *fb) kfree(omap_fb);
> }
>
> -static int omap_framebuffer_dirty(struct drm_framebuffer *fb,
> - struct drm_file *file_priv, unsigned flags, unsigned color,
> - struct drm_clip_rect *clips, unsigned num_clips)
> -{
> - return 0;
> -}
> -
> static const struct drm_framebuffer_funcs omap_framebuffer_funcs = {
> .create_handle = omap_framebuffer_create_handle,
> .destroy = omap_framebuffer_destroy,
> - .dirty = omap_framebuffer_dirty,
> };
>
> static uint32_t get_linear_addr(struct plane *plane,
--
Regards,
Laurent Pinchart
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 44+ messages in thread
* [PATCH 23/27] drm/sun4i: Use lockless gem BO free callback
2016-05-30 17:52 [PATCH 00/27] locklesss gem BO free driver patches Daniel Vetter
` (21 preceding siblings ...)
2016-05-30 17:53 ` [PATCH 22/27] drm/omapdrm: " Daniel Vetter
@ 2016-05-30 17:53 ` Daniel Vetter
2016-06-01 16:19 ` Maxime Ripard
2016-05-30 17:53 ` [PATCH 24/27] drm/arcpgu: " Daniel Vetter
` (4 subsequent siblings)
27 siblings, 1 reply; 44+ messages in thread
From: Daniel Vetter @ 2016-05-30 17:53 UTC (permalink / raw)
To: DRI Development; +Cc: Daniel Vetter, Maxime Ripard, Daniel Vetter
No dev->struct_mutex anywhere to be seen.
Cc: Maxime Ripard <maxime.ripard@free-electrons.com>
Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
---
drivers/gpu/drm/sun4i/sun4i_drv.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/sun4i/sun4i_drv.c b/drivers/gpu/drm/sun4i/sun4i_drv.c
index 76e922bb60e5..68e9d85085fb 100644
--- a/drivers/gpu/drm/sun4i/sun4i_drv.c
+++ b/drivers/gpu/drm/sun4i/sun4i_drv.c
@@ -103,7 +103,7 @@ static struct drm_driver sun4i_drv_driver = {
.dumb_create = drm_gem_cma_dumb_create,
.dumb_destroy = drm_gem_dumb_destroy,
.dumb_map_offset = drm_gem_cma_dumb_map_offset,
- .gem_free_object = drm_gem_cma_free_object,
+ .gem_free_object_unlocked = drm_gem_cma_free_object,
.gem_vm_ops = &drm_gem_cma_vm_ops,
/* PRIME Operations */
--
2.8.1
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 44+ messages in thread* Re: [PATCH 23/27] drm/sun4i: Use lockless gem BO free callback
2016-05-30 17:53 ` [PATCH 23/27] drm/sun4i: Use lockless gem BO free callback Daniel Vetter
@ 2016-06-01 16:19 ` Maxime Ripard
0 siblings, 0 replies; 44+ messages in thread
From: Maxime Ripard @ 2016-06-01 16:19 UTC (permalink / raw)
To: Daniel Vetter; +Cc: Daniel Vetter, DRI Development
[-- Attachment #1.1: Type: text/plain, Size: 1107 bytes --]
On Mon, May 30, 2016 at 07:53:15PM +0200, Daniel Vetter wrote:
> No dev->struct_mutex anywhere to be seen.
>
> Cc: Maxime Ripard <maxime.ripard@free-electrons.com>
> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
> ---
> drivers/gpu/drm/sun4i/sun4i_drv.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/sun4i/sun4i_drv.c b/drivers/gpu/drm/sun4i/sun4i_drv.c
> index 76e922bb60e5..68e9d85085fb 100644
> --- a/drivers/gpu/drm/sun4i/sun4i_drv.c
> +++ b/drivers/gpu/drm/sun4i/sun4i_drv.c
> @@ -103,7 +103,7 @@ static struct drm_driver sun4i_drv_driver = {
> .dumb_create = drm_gem_cma_dumb_create,
> .dumb_destroy = drm_gem_dumb_destroy,
> .dumb_map_offset = drm_gem_cma_dumb_map_offset,
> - .gem_free_object = drm_gem_cma_free_object,
> + .gem_free_object_unlocked = drm_gem_cma_free_object,
> .gem_vm_ops = &drm_gem_cma_vm_ops,
It doesn't compile here, it seems I need some additional patch?
Thanks,
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 44+ messages in thread
* [PATCH 24/27] drm/arcpgu: Use lockless gem BO free callback
2016-05-30 17:52 [PATCH 00/27] locklesss gem BO free driver patches Daniel Vetter
` (22 preceding siblings ...)
2016-05-30 17:53 ` [PATCH 23/27] drm/sun4i: Use lockless gem BO free callback Daniel Vetter
@ 2016-05-30 17:53 ` Daniel Vetter
2016-05-30 17:53 ` [PATCH 25/27] drm/hlcd: " Daniel Vetter
` (3 subsequent siblings)
27 siblings, 0 replies; 44+ messages in thread
From: Daniel Vetter @ 2016-05-30 17:53 UTC (permalink / raw)
To: DRI Development; +Cc: Daniel Vetter, Alexey Brodkin, Daniel Vetter
No dev->struct_mutex anywhere to be seen.
Cc: Alexey Brodkin <abrodkin@synopsys.com>
Cc: Carlos Palminha <palminha@synopsys.com>
Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
---
drivers/gpu/drm/arc/arcpgu_drv.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/arc/arcpgu_drv.c b/drivers/gpu/drm/arc/arcpgu_drv.c
index 76e187a5bde0..bc53ebb83f75 100644
--- a/drivers/gpu/drm/arc/arcpgu_drv.c
+++ b/drivers/gpu/drm/arc/arcpgu_drv.c
@@ -207,7 +207,7 @@ static struct drm_driver arcpgu_drm_driver = {
.get_vblank_counter = drm_vblank_no_hw_counter,
.prime_handle_to_fd = drm_gem_prime_handle_to_fd,
.prime_fd_to_handle = drm_gem_prime_fd_to_handle,
- .gem_free_object = drm_gem_cma_free_object,
+ .gem_free_object_unlocked = drm_gem_cma_free_object,
.gem_vm_ops = &drm_gem_cma_vm_ops,
.gem_prime_export = drm_gem_prime_export,
.gem_prime_import = drm_gem_prime_import,
--
2.8.1
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 44+ messages in thread* [PATCH 25/27] drm/hlcd: Use lockless gem BO free callback
2016-05-30 17:52 [PATCH 00/27] locklesss gem BO free driver patches Daniel Vetter
` (23 preceding siblings ...)
2016-05-30 17:53 ` [PATCH 24/27] drm/arcpgu: " Daniel Vetter
@ 2016-05-30 17:53 ` Daniel Vetter
2016-05-31 9:08 ` Liviu Dudau
2016-05-30 17:53 ` [PATCH 26/27] drm/hisilicon: " Daniel Vetter
` (2 subsequent siblings)
27 siblings, 1 reply; 44+ messages in thread
From: Daniel Vetter @ 2016-05-30 17:53 UTC (permalink / raw)
To: DRI Development; +Cc: Daniel Vetter, Liviu Dudau, Daniel Vetter
No dev->struct_mutex anywhere to be seen.
Cc: Liviu Dudau <Liviu.Dudau@arm.com>
Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
---
drivers/gpu/drm/arm/hdlcd_drv.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/arm/hdlcd_drv.c b/drivers/gpu/drm/arm/hdlcd_drv.c
index b987c63ba8d6..4f909378d581 100644
--- a/drivers/gpu/drm/arm/hdlcd_drv.c
+++ b/drivers/gpu/drm/arm/hdlcd_drv.c
@@ -316,7 +316,7 @@ static struct drm_driver hdlcd_driver = {
.get_vblank_counter = drm_vblank_no_hw_counter,
.enable_vblank = hdlcd_enable_vblank,
.disable_vblank = hdlcd_disable_vblank,
- .gem_free_object = drm_gem_cma_free_object,
+ .gem_free_object_unlocked = drm_gem_cma_free_object,
.gem_vm_ops = &drm_gem_cma_vm_ops,
.dumb_create = drm_gem_cma_dumb_create,
.dumb_map_offset = drm_gem_cma_dumb_map_offset,
--
2.8.1
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 44+ messages in thread* Re: [PATCH 25/27] drm/hlcd: Use lockless gem BO free callback
2016-05-30 17:53 ` [PATCH 25/27] drm/hlcd: " Daniel Vetter
@ 2016-05-31 9:08 ` Liviu Dudau
0 siblings, 0 replies; 44+ messages in thread
From: Liviu Dudau @ 2016-05-31 9:08 UTC (permalink / raw)
To: Daniel Vetter; +Cc: Daniel Vetter, DRI Development
On Mon, May 30, 2016 at 07:53:17PM +0200, Daniel Vetter wrote:
> No dev->struct_mutex anywhere to be seen.
>
> Cc: Liviu Dudau <Liviu.Dudau@arm.com>
> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
> ---
> drivers/gpu/drm/arm/hdlcd_drv.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/arm/hdlcd_drv.c b/drivers/gpu/drm/arm/hdlcd_drv.c
> index b987c63ba8d6..4f909378d581 100644
> --- a/drivers/gpu/drm/arm/hdlcd_drv.c
> +++ b/drivers/gpu/drm/arm/hdlcd_drv.c
> @@ -316,7 +316,7 @@ static struct drm_driver hdlcd_driver = {
> .get_vblank_counter = drm_vblank_no_hw_counter,
> .enable_vblank = hdlcd_enable_vblank,
> .disable_vblank = hdlcd_disable_vblank,
> - .gem_free_object = drm_gem_cma_free_object,
> + .gem_free_object_unlocked = drm_gem_cma_free_object,
> .gem_vm_ops = &drm_gem_cma_vm_ops,
> .dumb_create = drm_gem_cma_dumb_create,
> .dumb_map_offset = drm_gem_cma_dumb_map_offset,
> --
> 2.8.1
>
Acked-by: Liviu Dudau <Liviu.Dudau@arm.com>
Thanks for cleaning this up!
Liviu
--
====================
| I would like to |
| fix the world, |
| but they're not |
| giving me the |
\ source code! /
---------------
¯\_(ツ)_/¯
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 44+ messages in thread
* [PATCH 26/27] drm/hisilicon: Use lockless gem BO free callback
2016-05-30 17:52 [PATCH 00/27] locklesss gem BO free driver patches Daniel Vetter
` (24 preceding siblings ...)
2016-05-30 17:53 ` [PATCH 25/27] drm/hlcd: " Daniel Vetter
@ 2016-05-30 17:53 ` Daniel Vetter
2016-05-31 1:14 ` Xinliang Liu
2016-06-12 9:48 ` Xinliang Liu
2016-05-30 17:53 ` [PATCH 27/27] drm/mediatek: " Daniel Vetter
2016-05-31 13:33 ` [PATCH 00/27] locklesss gem BO free driver patches Sumit Semwal
27 siblings, 2 replies; 44+ messages in thread
From: Daniel Vetter @ 2016-05-30 17:53 UTC (permalink / raw)
To: DRI Development; +Cc: Daniel Vetter, Daniel Vetter
No dev->struct_mutex anywhere to be seen.
Cc: Xinliang Liu <xinliang.liu@linaro.org>
Cc: Xinwei Kong <kong.kongxinwei@hisilicon.com>
Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
---
drivers/gpu/drm/hisilicon/kirin/kirin_drm_drv.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/hisilicon/kirin/kirin_drm_drv.c b/drivers/gpu/drm/hisilicon/kirin/kirin_drm_drv.c
index 3f94785fbcca..193657259ee9 100644
--- a/drivers/gpu/drm/hisilicon/kirin/kirin_drm_drv.c
+++ b/drivers/gpu/drm/hisilicon/kirin/kirin_drm_drv.c
@@ -173,7 +173,7 @@ static struct drm_driver kirin_drm_driver = {
.fops = &kirin_drm_fops,
.set_busid = drm_platform_set_busid,
- .gem_free_object = drm_gem_cma_free_object,
+ .gem_free_object_unlocked = drm_gem_cma_free_object,
.gem_vm_ops = &drm_gem_cma_vm_ops,
.dumb_create = kirin_gem_cma_dumb_create,
.dumb_map_offset = drm_gem_cma_dumb_map_offset,
--
2.8.1
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 44+ messages in thread* Re: [PATCH 26/27] drm/hisilicon: Use lockless gem BO free callback
2016-05-30 17:53 ` [PATCH 26/27] drm/hisilicon: " Daniel Vetter
@ 2016-05-31 1:14 ` Xinliang Liu
2016-06-12 9:48 ` Xinliang Liu
1 sibling, 0 replies; 44+ messages in thread
From: Xinliang Liu @ 2016-05-31 1:14 UTC (permalink / raw)
To: Daniel Vetter; +Cc: Daniel Vetter, DRI Development
Hi, thanks for your patch.
On 31 May 2016 at 01:53, Daniel Vetter <daniel.vetter@ffwll.ch> wrote:
> No dev->struct_mutex anywhere to be seen.
>
> Cc: Xinliang Liu <xinliang.liu@linaro.org>
> Cc: Xinwei Kong <kong.kongxinwei@hisilicon.com>
> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
> ---
> drivers/gpu/drm/hisilicon/kirin/kirin_drm_drv.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/hisilicon/kirin/kirin_drm_drv.c b/drivers/gpu/drm/hisilicon/kirin/kirin_drm_drv.c
> index 3f94785fbcca..193657259ee9 100644
> --- a/drivers/gpu/drm/hisilicon/kirin/kirin_drm_drv.c
> +++ b/drivers/gpu/drm/hisilicon/kirin/kirin_drm_drv.c
> @@ -173,7 +173,7 @@ static struct drm_driver kirin_drm_driver = {
> .fops = &kirin_drm_fops,
> .set_busid = drm_platform_set_busid,
>
> - .gem_free_object = drm_gem_cma_free_object,
> + .gem_free_object_unlocked = drm_gem_cma_free_object,
This patch looks good to me apply to drm-hisilicon-next.
Thanks,
-xinliang
> .gem_vm_ops = &drm_gem_cma_vm_ops,
> .dumb_create = kirin_gem_cma_dumb_create,
> .dumb_map_offset = drm_gem_cma_dumb_map_offset,
> --
> 2.8.1
>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 44+ messages in thread* Re: [PATCH 26/27] drm/hisilicon: Use lockless gem BO free callback
2016-05-30 17:53 ` [PATCH 26/27] drm/hisilicon: " Daniel Vetter
2016-05-31 1:14 ` Xinliang Liu
@ 2016-06-12 9:48 ` Xinliang Liu
1 sibling, 0 replies; 44+ messages in thread
From: Xinliang Liu @ 2016-06-12 9:48 UTC (permalink / raw)
To: Daniel Vetter; +Cc: Daniel Vetter, DRI Development
Hi,
On 31 May 2016 at 01:53, Daniel Vetter <daniel.vetter@ffwll.ch> wrote:
> No dev->struct_mutex anywhere to be seen.
>
> Cc: Xinliang Liu <xinliang.liu@linaro.org>
> Cc: Xinwei Kong <kong.kongxinwei@hisilicon.com>
> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
Reviewed-by: Xinliang Liu <xinliang.liu@linaro.org>
> ---
> drivers/gpu/drm/hisilicon/kirin/kirin_drm_drv.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/hisilicon/kirin/kirin_drm_drv.c b/drivers/gpu/drm/hisilicon/kirin/kirin_drm_drv.c
> index 3f94785fbcca..193657259ee9 100644
> --- a/drivers/gpu/drm/hisilicon/kirin/kirin_drm_drv.c
> +++ b/drivers/gpu/drm/hisilicon/kirin/kirin_drm_drv.c
> @@ -173,7 +173,7 @@ static struct drm_driver kirin_drm_driver = {
> .fops = &kirin_drm_fops,
> .set_busid = drm_platform_set_busid,
>
> - .gem_free_object = drm_gem_cma_free_object,
> + .gem_free_object_unlocked = drm_gem_cma_free_object,
> .gem_vm_ops = &drm_gem_cma_vm_ops,
> .dumb_create = kirin_gem_cma_dumb_create,
> .dumb_map_offset = drm_gem_cma_dumb_map_offset,
> --
> 2.8.1
>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 44+ messages in thread
* [PATCH 27/27] drm/mediatek: Use lockless gem BO free callback
2016-05-30 17:52 [PATCH 00/27] locklesss gem BO free driver patches Daniel Vetter
` (25 preceding siblings ...)
2016-05-30 17:53 ` [PATCH 26/27] drm/hisilicon: " Daniel Vetter
@ 2016-05-30 17:53 ` Daniel Vetter
2016-05-31 6:22 ` Philipp Zabel
2016-05-31 13:33 ` [PATCH 00/27] locklesss gem BO free driver patches Sumit Semwal
27 siblings, 1 reply; 44+ messages in thread
From: Daniel Vetter @ 2016-05-30 17:53 UTC (permalink / raw)
To: DRI Development; +Cc: Daniel Vetter, Daniel Vetter
No dev->struct_mutex anywhere to be seen.
Cc: Philipp Zabel <p.zabel@pengutronix.de>
Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
---
drivers/gpu/drm/mediatek/mtk_drm_drv.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/mediatek/mtk_drm_drv.c b/drivers/gpu/drm/mediatek/mtk_drm_drv.c
index b1223d54d0ab..06a417b2f91e 100644
--- a/drivers/gpu/drm/mediatek/mtk_drm_drv.c
+++ b/drivers/gpu/drm/mediatek/mtk_drm_drv.c
@@ -243,7 +243,7 @@ static struct drm_driver mtk_drm_driver = {
.enable_vblank = mtk_drm_crtc_enable_vblank,
.disable_vblank = mtk_drm_crtc_disable_vblank,
- .gem_free_object = mtk_drm_gem_free_object,
+ .gem_free_object_unlocked = mtk_drm_gem_free_object,
.gem_vm_ops = &drm_gem_cma_vm_ops,
.dumb_create = mtk_drm_gem_dumb_create,
.dumb_map_offset = mtk_drm_gem_dumb_map_offset,
--
2.8.1
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 44+ messages in thread* Re: [PATCH 27/27] drm/mediatek: Use lockless gem BO free callback
2016-05-30 17:53 ` [PATCH 27/27] drm/mediatek: " Daniel Vetter
@ 2016-05-31 6:22 ` Philipp Zabel
2016-05-31 6:58 ` Daniel Vetter
0 siblings, 1 reply; 44+ messages in thread
From: Philipp Zabel @ 2016-05-31 6:22 UTC (permalink / raw)
To: Daniel Vetter; +Cc: Daniel Vetter, DRI Development
Hi Daniel,
Am Montag, den 30.05.2016, 19:53 +0200 schrieb Daniel Vetter:
> No dev->struct_mutex anywhere to be seen.
>
> Cc: Philipp Zabel <p.zabel@pengutronix.de>
> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
> ---
> drivers/gpu/drm/mediatek/mtk_drm_drv.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/mediatek/mtk_drm_drv.c b/drivers/gpu/drm/mediatek/mtk_drm_drv.c
> index b1223d54d0ab..06a417b2f91e 100644
> --- a/drivers/gpu/drm/mediatek/mtk_drm_drv.c
> +++ b/drivers/gpu/drm/mediatek/mtk_drm_drv.c
> @@ -243,7 +243,7 @@ static struct drm_driver mtk_drm_driver = {
> .enable_vblank = mtk_drm_crtc_enable_vblank,
> .disable_vblank = mtk_drm_crtc_disable_vblank,
>
> - .gem_free_object = mtk_drm_gem_free_object,
> + .gem_free_object_unlocked = mtk_drm_gem_free_object,
> .gem_vm_ops = &drm_gem_cma_vm_ops,
> .dumb_create = mtk_drm_gem_dumb_create,
> .dumb_map_offset = mtk_drm_gem_dumb_map_offset,
Thanks, I've sent this already:
https://patchwork.kernel.org/patch/9058621/
If you'd like me to drop that from the next pull request, let me know
and have my
Acked-by: Philipp Zabel <p.zabel@pengutronix.de>
for this patch.
regards
Philipp
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 44+ messages in thread* Re: [PATCH 27/27] drm/mediatek: Use lockless gem BO free callback
2016-05-31 6:22 ` Philipp Zabel
@ 2016-05-31 6:58 ` Daniel Vetter
0 siblings, 0 replies; 44+ messages in thread
From: Daniel Vetter @ 2016-05-31 6:58 UTC (permalink / raw)
To: Philipp Zabel; +Cc: Daniel Vetter, DRI Development
On Tue, May 31, 2016 at 8:22 AM, Philipp Zabel <p.zabel@pengutronix.de> wrote:
> Am Montag, den 30.05.2016, 19:53 +0200 schrieb Daniel Vetter:
>> No dev->struct_mutex anywhere to be seen.
>>
>> Cc: Philipp Zabel <p.zabel@pengutronix.de>
>> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
>> ---
>> drivers/gpu/drm/mediatek/mtk_drm_drv.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/mediatek/mtk_drm_drv.c b/drivers/gpu/drm/mediatek/mtk_drm_drv.c
>> index b1223d54d0ab..06a417b2f91e 100644
>> --- a/drivers/gpu/drm/mediatek/mtk_drm_drv.c
>> +++ b/drivers/gpu/drm/mediatek/mtk_drm_drv.c
>> @@ -243,7 +243,7 @@ static struct drm_driver mtk_drm_driver = {
>> .enable_vblank = mtk_drm_crtc_enable_vblank,
>> .disable_vblank = mtk_drm_crtc_disable_vblank,
>>
>> - .gem_free_object = mtk_drm_gem_free_object,
>> + .gem_free_object_unlocked = mtk_drm_gem_free_object,
>> .gem_vm_ops = &drm_gem_cma_vm_ops,
>> .dumb_create = mtk_drm_gem_dumb_create,
>> .dumb_map_offset = mtk_drm_gem_dumb_map_offset,
>
> Thanks, I've sent this already:
> https://patchwork.kernel.org/patch/9058621/
> If you'd like me to drop that from the next pull request, let me know
> and have my
> Acked-by: Philipp Zabel <p.zabel@pengutronix.de>
> for this patch.
Like I said I want to send this out this week (early feature pulls are
good!) and I'm kinda too lazy to remember which drivers are fixed up
somewhere else - there's way too many different trees for my taste ;-)
I think I'll just keep this one here. For next time around just send
out your patch queue in a pull request (even if it's just 1 patch), or
ping me on irc to smash it into drm-misc instead. Waiting with pull
request because you don't have enough yet isn't a good approach and
leads to duplicated work like here.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 44+ messages in thread
* Re: [PATCH 00/27] locklesss gem BO free driver patches
2016-05-30 17:52 [PATCH 00/27] locklesss gem BO free driver patches Daniel Vetter
` (26 preceding siblings ...)
2016-05-30 17:53 ` [PATCH 27/27] drm/mediatek: " Daniel Vetter
@ 2016-05-31 13:33 ` Sumit Semwal
27 siblings, 0 replies; 44+ messages in thread
From: Sumit Semwal @ 2016-05-31 13:33 UTC (permalink / raw)
To: Daniel Vetter; +Cc: DRI Development
Hi Daniel!
On 30 May 2016 at 23:22, Daniel Vetter <daniel.vetter@ffwll.ch> wrote:
> HI all,
>
> Here's the pile of lockless gem BO free conversion patches. Assuming I didn't
> botch it these are all the ones that didn't yet get an ack. Since this is all
> pretty boring stuff I'll just send a pull request to Dave later this week if no
> one pipes.
>
For the series, please feel free to add my R-b, fwiw.
> Thanks, Daniel
>
Best,
Sumit.
> Benjamin Gaignard (1):
> drm: sti: remove useless call to dev->struct_mutex
>
> Daniel Vetter (26):
> drm/armada: Use lockless gem BO free callback
> drm/ast: Use lockless gem BO free callback
> drm/atmel: Use lockless gem BO free callback
> drm/bochs: Use lockless gem BO free callback
> drm/cirrus: Use lockless gem BO free callback
> drm/fls-dcu: Use lockless gem BO free callback
> drm/mga200g: Use lockless gem BO free callback
> drm/nouveau: Use lockless gem BO free callback
> drm/qxl: Use lockless gem BO free callback
> drm/rcar-du: Use lockless gem BO free callback
> drm/rockchip: Use lockless gem BO free callback
> drm/shmob: Use lockless gem BO free callback
> drm/tilcdc: Use lockless gem BO free callback
> drm/vc4: Use drm_gem_object_unreference_unlocked
> drm/vc4: Use lockless gem BO free callback
> drm/vgem: Use lockless gem BO free callback
> drm/virtio: Use lockless gem BO free callback
> drm/virtio: Use lockless gem BO free callback
> drm/rockchip: Use cma gem vm ops
> drm/msm: Nuke dummy fb->dirty callback
> drm/omapdrm: Nuke dummy fb->dirty callback
> drm/sun4i: Use lockless gem BO free callback
> drm/arcpgu: Use lockless gem BO free callback
> drm/hlcd: Use lockless gem BO free callback
> drm/hisilicon: Use lockless gem BO free callback
> drm/mediatek: Use lockless gem BO free callback
>
> drivers/gpu/drm/arc/arcpgu_drv.c | 2 +-
> drivers/gpu/drm/arm/hdlcd_drv.c | 2 +-
> drivers/gpu/drm/armada/armada_drv.c | 2 +-
> drivers/gpu/drm/ast/ast_drv.c | 2 +-
> drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c | 2 +-
> drivers/gpu/drm/bochs/bochs_drv.c | 2 +-
> drivers/gpu/drm/cirrus/cirrus_drv.c | 2 +-
> drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c | 2 +-
> drivers/gpu/drm/hisilicon/kirin/kirin_drm_drv.c | 2 +-
> drivers/gpu/drm/mediatek/mtk_drm_drv.c | 2 +-
> drivers/gpu/drm/mgag200/mgag200_drv.c | 2 +-
> drivers/gpu/drm/msm/msm_fb.c | 8 --------
> drivers/gpu/drm/nouveau/nouveau_drm.c | 2 +-
> drivers/gpu/drm/omapdrm/omap_fb.c | 8 --------
> drivers/gpu/drm/qxl/qxl_drv.c | 2 +-
> drivers/gpu/drm/rcar-du/rcar_du_drv.c | 2 +-
> drivers/gpu/drm/rockchip/rockchip_drm_drv.c | 10 +++-------
> drivers/gpu/drm/shmobile/shmob_drm_drv.c | 2 +-
> drivers/gpu/drm/sti/sti_cursor.c | 7 -------
> drivers/gpu/drm/sti/sti_drv.c | 8 +-------
> drivers/gpu/drm/sti/sti_dvo.c | 7 -------
> drivers/gpu/drm/sti/sti_gdp.c | 14 --------------
> drivers/gpu/drm/sti/sti_hda.c | 7 -------
> drivers/gpu/drm/sti/sti_hdmi.c | 7 -------
> drivers/gpu/drm/sti/sti_hqvdp.c | 7 -------
> drivers/gpu/drm/sti/sti_mixer.c | 7 -------
> drivers/gpu/drm/sti/sti_tvout.c | 7 -------
> drivers/gpu/drm/sti/sti_vid.c | 7 -------
> drivers/gpu/drm/sun4i/sun4i_drv.c | 2 +-
> drivers/gpu/drm/tilcdc/tilcdc_drv.c | 2 +-
> drivers/gpu/drm/vc4/vc4_bo.c | 2 --
> drivers/gpu/drm/vc4/vc4_drv.c | 2 +-
> drivers/gpu/drm/vc4/vc4_gem.c | 11 +++--------
> drivers/gpu/drm/vgem/vgem_drv.c | 2 +-
> drivers/gpu/drm/virtio/virtgpu_drv.c | 2 +-
> 35 files changed, 27 insertions(+), 130 deletions(-)
>
> --
> 2.8.1
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 44+ messages in thread